Repository navigation
Harmonice P0: stereo lead Pitch Tune, register-aware ensemble and compact switch - #529
Conversation
|
/arsonmix-ci ui b582f2c |
|
/arsonmix-ci fat b582f2c |
Deploying arsonmix with
|
| Latest commit: |
d5e4387
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f42d59b.arsonmix.pages.dev |
| Branch Preview URL: | https://integration-harmonice-lead-e.arsonmix.pages.dev |
|
Owner-reported UX parity addition to preserve in this active Harmonice P0 source branch: Current main GUI has only VOICES 3/4/5 while factory Do not confuse Canonical owner execution spec: docs PR #532 · tracking issue #533. Keep #529's stereo lead, natural Pitch Tune, existing PDC, premium compact toggle, native ACK/readback and CI evidence intact. |
* fix(harmony): keep stable signed epochs for quiet/high backing vowels * fix(harmony): bridge brief pitch-confidence gaps and prevent PSOLA dropout noise * test(harmony): cover soft soprano signed epochs and 64/257 block parity * fix(harmonice-ui): expose supported two-harmony-voice Duo selector * test(gui): exercise Natural Duo preset and direct two-voice native readback * test(harmony): assert VOICES 2 and Duo preset parity in approved editor * style(harmonice): fit four voice buttons on compact editor widths
|
/arsonmix-ci ui a1ef226 |
|
/arsonmix-ci fat a1ef226 |
* fix(harmony): smooth voiced and epoch handoffs on noisy long vibrato without callback allocation * feat(harmonice): hard-pan LOW/HIGH roles and prioritize high-register audibility * feat(harmonice): perceptual constant-power stereo width with Space zero preserved * test(harmonice): long vibrato/noisy chorus 5-voice continuity, hard-pan level and PCM parity * fix(harmony): sub-sample epoch alignment for mono HIGH/LOW backing voices * feat(harmonice): directional HIGH intelligibility without added room or latency * feat(harmonice): retain HIGH direct clarity inside wide spatial stage * test(harmonice): verify HIGH direct focus at wide stage and Space0 neutrality
… renders * test(harmony): render authentic LOW/MID/HIGH independent backing stems and verify linear recombination * feat(harmony-ab): report independent register RMS for HIGH/MID/LOW diagnosis * ci(harmony): qualify native offline register-stem A/B edits with inexpensive DSP lane
|
/arsonmix-ci fat 2a8c4e8 |
2026-11-11 field retest → P0 M2 milestone integratedOwner still reports very short crackle/stutter on loud/chorus/long singer vibrato, especially HIGH; LOW is already noticeable but wants harder left/right perceived depth. This is an acoustic blocker, regardless of past Windows 80/80 CTest or successful synthetic CPU profile. Changes reconciled into this PR via merged #541 (engine continuity/role stereo) and #543 (isolated role-stem diagnostics). Current exact candidate: Engine: smooth PSOLA validity (5ms) and renderer transition (30ms) instead of immediate granular phase flip; tolerate up to 5 energetic uncertain F0 windows (~33ms) but still release real silence; 8ms amplitude gate rather than 2ms; bound/slew input F0 period between analysis hops; fractional peak refinement for mono LOW/HIGH; hard-width LOW/HIGH placement with prepared constant-power sqrt(Space) and high direct-position intelligibility gain. No extra plugin, no heap in PCM callback, unchanged 1536-sample PDC @48k, lead preserved at correction OFF and Wet0. Tested on this exact SHA: Native DSP compile & PCM regression PASS, fast native PASS, fast UI PASS, and existing Windows PR quick lane PASS. Added deterministic synthetic 5.1Hz / 70-cent vibrato, high chorus level, repeated 14ms consonant/noise, 48k/64 vs 257 frame parity, 5-voice continuity/finite/mono; role stem A/B self-test verifies LOW+MID+HIGH recombine into the full wet-minus-dry backing. Owner-directed single exact-source Windows FAT dispatched: run #42913531733. No public main merge yet. Next real admission, not optional: adult singer lead (quiet, loud chorus, sustained vibrato) against dry, backing-only and isolated 14_low/15_mid/16_high recordings from the same source; compare artifact audibility, RMS, glitch boundaries and formants; physical ASIO 64/128/256 sample callback/XRUN/cpu evidence on the same PC. Do NOT claim crackle fully fixed solely from CTest. P1 true Doubler #537 and shared preset storage #539 remain isolated draft milestones. |
|
CI cost optimization merged into |
* feat(harmony): bounded period tracker rejects one-off octave errors without resetting active PSOLA grains * fix(harmony): preserve overlapping PSOLA grains through octave outliers and retune only confirmed leaps * test(harmony): two-frame harmonic octave rejection, sustained transition and bounded PSOLA period slew
|
/arsonmix-ci fat 7496fee |
|
Cross-thread maintainability integrated update (2026-11-11). #569 is now MERGED to main Rechecked latest #529 head |
…d DSP snapshots for EQ, Compressor, Harmonice, Throw
…recall, and precise two-target CTest
|
/arsonmix-ci ui 6548800 |
… ACK and exact accepted readback
… selective full UI lane
|
/arsonmix-ci ui 831a312 |
…so mounts shared bar
|
/arsonmix-ci ui 0660032 |
…ure Windows preset CI to actual source deltas
…ACK/readback and Chromium safety test
|
/arsonmix-ci fat ac5e6c1 |
|
/arsonmix-ci ui 2a3673f |
M4 cross-thread checkpoint — one native My Presets service, 4 built-in FXVerified and committed, without resetting other threads:
Measured CI: Real JUCE two-target Windows Release CTest 2/2 PASS run #42972620482: disk store + true accepted snapshots from four JUCE processors, cold reopen and wrong-catalog rejection. Full Chromium PASS on the three-editor candidate run #42974108206, including Compressor, Vocal Throw, Harmonice, WIRE, responsive mixer. All fast CI succeeded on Parallel owner coordination: Another active agent added Open gates (not proven by synthetic/stub tests): full Windows host/installer FAT for final EQ-bearing SHA, real native cross-channel cold restart/disk UAT, physical ASIO at low buffers, human-singer HIGH continuity/crackles and Duo/Doubler listening A/B. Keep #529 Draft until qualified. User-presets M4 GUI is 4/4 implemented on latest branch but the EQ flow is sequential/ordered with explicit partial failure semantics, not an atomic PCM bank switch. |
Milestone M4 — native Parametric EQ My Presets (exact HEAD
|
…ACK timeout; test rejected second band
|
/arsonmix-ci ui d5e4387 |
|
/arsonmix-ci fat d5e4387 |
M4.1 closeout: honest EQ partial-recall lifecycle — exact SHA
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
November 11 integrated completion checkpoint — exact SHA
d5e4387f44f07601c5530ad2de45ad445b5d2b8bImplementation scope complete for software qualification; NOT a physical audio release certification. The current PR is clean and 0 commits behind
main@fd2dd0c4. No second PCM authority or GUI implementation..armixfxrepository for Harmonice, Compressor, EQ, Vocal Throw; Save As / Overwrite / Rename / Delete / Recall; exact ChannelId/slot/instance/epoch/revision lease; accepted DSP settings only, no file I/O on callback..armixfxstore + actual JUCE accepted DSP snapshot test for all four FX 2/2 PASS on #42972620482; current source-only tests scoped, not repeated for UI-only SHA.Merge decision: preserve Draft until latest Windows and the separate hardware listening gate are either evidenced or explicitly retained as a non-release qualification issue. Do not silently infer field acceptance from green CI. Cross-thread
mainwork (multi-output and maintainability) must remain untouched. See M4.1 engineering note.Implementation
main@a07b16e1c6f04473d328ddd1deab607774375ee3; the intervening docs(architecture): executable maintainability workpack, ownership map and new-thread prompt #528 is a documentation change. DRAFT Harmonice P1 — nine-file offline study cleanly based on merged branded main #521 remains the separate 24/16 ms research branch.Reference decisions
Qualification
Exact-SHA evidence