Repository navigation
P0 Harmonice M2: noisy sustained-vibrato anti-stutter and true wide LOW/HIGH stereo stage - #541
Merged
masarray merged 8 commits intoNov 10, 2026
Conversation
…without callback allocation
…an level and PCM parity
masarray
marked this pull request as ready for review
November 10, 2026 22:14
masarray
merged commit Nov 10, 2026
99bfbc4
into
integration/harmonice-lead-ensemble-20261111
4 of 5 checks passed
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field symptom from singer retest 2026-11-11
Despite M1 #535, owner still hears sub-second clicks/stuttering during loud/chorus/long vibrato. LOW is noticeable; HIGH and other pitched harmonies intermittent/robotic. Owner requests wider L/R 3D stage.
Audio engine hypotheses addressed (native PCM only)
sync.readylosses hard-switched to a phase-unrelated granular sample. Reuse current PSOLA filter state with a 5ms validity crossfade and 30ms overall algorithm blend; never zero-source a valid backing. Each F0 analysis now slews source period toward latest measured period at ±5% bounded window and .30 update rather than instantaneous resynthesis window shifts. Confirmed octave-size transitions re-seed grains without clearing active output blend to zero.sqrt(space)constant-power pan prepared on CONTROL. High presence 1.37 (was 1.12), LOW ~1.20 (was 1.16), MID reduced to .94; total ensemble remains exactly normalized as before. At Space=0 all harmony returns to center; no dry stereo, PDC, or wet=0 change. This is wide stereo/precedence/room, not a measured personalized HRTF or claimed physical metres.Admission
Stacked on #529 current head
a1ef2265624b8cfc6248064a2ee45b6313b8e92e, not on main. Exact intent is to merge into #529 only after fast CI and review; do not separately merge this into current production main or leak unqualified work from #537 Doubler and #539 User Presets. Pitch Tune stereo OFF default, correction state, native settings, fixed PDC 1536 @48k and no RT malloc remain unchanged.Remaining blockers