Skip to content

P0 Harmonice M2: noisy sustained-vibrato anti-stutter and true wide LOW/HIGH stereo stage - #541

Merged
masarray merged 8 commits into
integration/harmonice-lead-ensemble-20261111from
fix/harmonice-vibrato-crackle-wide-stage-20261111
Nov 10, 2026
Merged

masarray merged 8 commits into
integration/harmonice-lead-ensemble-20261111from
fix/harmonice-vibrato-crackle-wide-stage-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

Field symptom from singer retest 2026-11-11

Despite M1 #535, owner still hears sub-second clicks/stuttering during loud/chorus/long vibrato. LOW is noticeable; HIGH and other pitched harmonies intermittent/robotic. Owner requests wider L/R 3D stage.

Audio engine hypotheses addressed (native PCM only)

  1. Voiced continuity: formerly two ambiguous (energetic) F0 hops (~13ms) caused a note release/restart with a 2ms gate — potentially audible as high-rate tremolo during busy singing. Keep confirmed note for five ambiguous hops (~33ms at 48k), still release immediately when PCM is truly silent; use an 8ms gate to avoid razor-edge transitions. Never latch unpitched silence indefinitely.
  2. Renderer continuity: existing sync.ready losses hard-switched to a phase-unrelated granular sample. Reuse current PSOLA filter state with a 5ms validity crossfade and 30ms overall algorithm blend; never zero-source a valid backing. Each F0 analysis now slews source period toward latest measured period at ±5% bounded window and .30 update rather than instantaneous resynthesis window shifts. Confirmed octave-size transitions re-seed grains without clearing active output blend to zero.
  3. Depth and separation: role anchors LOW=-.94, HIGH=+.95, supports ±~.66; psychoacoustically steeper sqrt(space) constant-power pan prepared on CONTROL. High presence 1.37 (was 1.12), LOW ~1.20 (was 1.16), MID reduced to .94; total ensemble remains exactly normalized as before. At Space=0 all harmony returns to center; no dry stereo, PDC, or wet=0 change. This is wide stereo/precedence/room, not a measured personalized HRTF or claimed physical metres.
  4. Tests: deterministic 5.1Hz/70c, loud chorus, artificial 14ms noisy consonant repeatedly, 48k/64-vs-257 callback parity, finite PCM/stereo/mono, voiced continuity and bounded sample jump; hard-pan/relative-HIGH gains and Space0 checks; existing CTest unchanged.

Admission

Stacked on #529 current head a1ef2265624b8cfc6248064a2ee45b6313b8e92e, not on main. Exact intent is to merge into #529 only after fast CI and review; do not separately merge this into current production main or leak unqualified work from #537 Doubler and #539 User Presets. Pitch Tune stereo OFF default, correction state, native settings, fixed PDC 1536 @48k and no RT malloc remain unchanged.

Remaining blockers

  • Source F0 and actual PSOLA epoch search may still create audible clicks, particularly on real unvoiced bursts. Synthetic continuity test alone cannot qualify formant or artifact-free HIGH.
  • Check 48k 64/128/256 physical ASIO full music-vocal chorus and long vibrato, CPU p95/p99 callback/xruns vs A/B wet-only stems. Do not call this a final crackle fix or infer physical 3D.
  • Reconcile Harmonice P0: stereo lead Pitch Tune, register-aware ensemble and compact switch #529 with latest main and build one exact-SHA Windows FAT only if qualified by targeted Linux test and UI contracts.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86783a7
Status:⚡️  Build in progress...

View logs

@masarray
masarray marked this pull request as ready for review November 10, 2026 22:14
@masarray
masarray merged commit 99bfbc4 into integration/harmonice-lead-ensemble-20261111 Nov 10, 2026
4 of 5 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant