Skip to content

[P1][HARMONICE] Qualify Duo, real Doubler and built-in FX user presets #533

Open

Description

@masarray

Milestone B verified triage — 2026-11-17: P1 / harmonice / feature / planned. Classification ≠ completion of product feature or physical FAT.

Scope / release boundary: Portions may already ship; verify current before claiming work is missing.

Exit criteria:

  • Audit current Windows product for VOICES=2 Duo, genuine separately controlled unison Doubler, native ACK and legacy 3/4/5 compatibility.
  • Verify per-effect user presets survive .smix reopen, device switch and app restart; fill only source-proven gaps with real native PCM tests.

Canonical issue ledger. Preserve historical evidence below; no speculative merging or rewriting approved audio.


Owner feedback (2026-11-11)

Harmonice VOICES offers only 3/4/5, but factory Natural Duo uses 2 (native DSP already supports 2). There is no quick unison Doubler like BOSS VE; a real Doubler must be distinct from Duo (2 pitched backing harmony voices). In addition, every native built-in FX—EQ, Compressor, Harmonice, Vocal Throw—needs durable user-created per-effect presets saved with a professional compact Save As / recall / manage UX.

Executable spec & references: PR #532 / full workpack. Includes FabFilter/iZotope/Valhalla preset UX research and BOSS VE Double vs Unison/Harmony semantics.

Acceptance gates

  • Direct VOICES 2 button with correct native ACK/readback, selected state, Duo preset synchronization, all current 3/4/5 workflows, compact GUI screenshots and persistence.
  • Genuine deterministic Doubler unison DSP mode with versioned state migration, not a relabeled pitched voice count or fake selector; wet A/B stems, stereo/mono/PDC/CPU regression.
  • One reusable per-FX preset bar (Factory vs My Presets, Modified, Save As, Save, Rename/Delete, duplicate/overwrite/cancel) in each built-in editor.
  • Single native versioned, durable per-FX preset repository. After app restart, preset still accessible and can be applied audibly on another ChannelId; controls require matching DSP ACK/readback.
  • Factory immutable; wrong-plugin, corrupt, duplicate, disk full/read-only, stale graph/epoch, moved FX fail without changing accepted audio.
  • .smix mixer session and .armix My Sounds chain formats remain separate and compatible; no browser-only localStorage, no callback disk/heap/locks, no Monitor/Arm workflow.
  • Selective Windows native + Chromium tests, actual GUI evidence and separately qualified physical ASIO/listening A/B.

Concurrency/ownership: draft #529 already edits Harmonice GUI, lead Pitch Tune and toggle; integrate 2-button fix with its owner or immediately following it, without overwriting #529. #521 shorter latency remains experimental. This issue does not claim features are implemented.

Activity

  1. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    Execution specification is now merged into main via #532 at ddf7b2a9b8c97eadccb2bb96f06bf3abcafd5ddc.

    Canonical workpack: HARMONICE_DUO_DOUBLER_BUILTIN_FX_USER_PRESETS_20261111.md.

    This merged milestone is docs only. Keep this issue open until direct 2-voice native GUI parity, real unison Doubler and durable native user presets for all built-in FX are implemented and validated. Coordinate overlapping Harmonice GUI work with draft #529.

  2. masarray commented on Nov 10, 2026

    @masarray
    OwnerAuthor

    2026-11-11 execution status (continued after Work quota exhaustion)

    • P0 lead/high continuity + native Duo: stacked PR #535 merged into the source branch of draft Harmonice P0: stereo lead Pitch Tune, register-aware ensemble and compact switch #529, not production main; candidate HEAD a1ef2265624b8cfc6248064a2ee45b6313b8e92e. Fast native/DSP/UI and exact-SHA full Chromium passed. One new owner-dispatched Windows installer/FAT workflow 42901588669 underway. Owner's real HIGH voice crackle remains subject to recorded-vocal/ASIO listening gate; never claim resolved from synthetic checks.
    • True unison Doubler distinct from 2 pitched Harmony voices: Draft PR #537, separate P1 branch; mode, versioned v3 migration, real DSP unison, GUI factory Double Light/Wide, and tests. Fast DSP/UI native checks are being qualified. Do not confuse its voiceMode=1 with voices=2.
    • All native built-in FX user presets: Draft PR #539 starts one typed durable .armixfx user library for EQ/Compressor/Harmonice/Throw, with atomic Save As/overwrite/rename/delete, corruption/identity/portable tests. This is storage M1 only; not a completed end-to-end live DSP preset recall nor GUI Save Preset. Native Windows CTest 42902768602 underway.

    Keep this issue OPEN until all four FX Save/Recall actions are wired to native accepted DSP snapshots and ACK/readback through one reusable compact preset editor. Do not merge user-preset storage as a release feature just because the store unit test compiles.

  3. masarray commented on Nov 11, 2026

    @masarray
    OwnerAuthor

    Harmonice execution checkpoint — 2026-11-11

    Actual confirmed milestones:

    • Last pre-Doubler candidate M3/M4 exact SHA dc63d1f92a9b877fac5cea22b97c1e467e2f465f Windows FAT #42923857425 succeeded. 12/12 focused Windows PCM/ASIO-boundary CTests PASS, real JUCE app and installer Preview/FAT artifact verified; still NOT a real singer/physical ASIO listening pass.
    • Natural Duo (2 pitched voices) and native lead Pitch Tune/LOW-HIGH wide 3D stage/period continuity remain part of draft #529.
    • True native unison Doubler M5 was safely ported from old divergent DRAFT Harmonice P1: genuine unison Doubler mode, native control and v3 session migration #537 (closed superseded) into the newest M3/M4 candidate via merged #554: one wet unison singer, not two pitched Duo singers, state migration AHM1 v1/v2=>Harmony and v3=>Doubler, real native HARMONY/DOUBLER control + Double Light/Wide, exact DSP ACK/readback. New candidate 87fd184b6dd39a81289d02c8220f42848372516c passes Native DSP compile/PCM, Fast Native, Fast UI. One full Windows FAT #42927616818 requested since shared src/Main.cpp was changed; one Chromium UI milestone requested, no claim of results before completion.
    • Four-FX native per-effect preset disk storage M1 now merged to main through #556 at 241dd7541582382c8ee14b378c7a187d8e0943dd; typed EQ/Comp/Harmony/Throw schemas, atomic versioned .armixfx, portable workspace, SaveNew/Overwrite/Rename/Delete/List/Read, corruption/size/name/identity guards. Dedicated Windows JUCE 8 Release CTest #42927387929 succeeded after tests were changed from NDEBUG-elided assert to live REQUIRE, and deliberately corrupt JSON assertions were fixed. Old divergent DRAFT Built-in FX user presets M1: native durable typed store for EQ, Compressor, Harmonice and Throw #539 closed superseded. This is native storage M1 only, not user-facing presets.

    Still open: true per-effect GUI Save As/Recall/Modified/Rename/Delete for all four editors and atomic matching accepted DSP ACK/readback on another ChannelId (M2/M3); naturalness/glitches/high voice & true Doubler real sung chorus/vibrato qualification, physical ASIO 64/128/256 and XRUN/CPU, chord-aware music planner, final main integration. Do not count CI-green synthetic tests as proof that every remaining crackle is gone. Avoid simultaneous redundant expensive CI, and keep #529 draft until field audio acceptance and shared-main reconciliation.

  4. masarray commented on Nov 11, 2026

    @masarray
    OwnerAuthor

    Harmonice / four-FX My Presets — final field acceptance handoff (2026-11-11)

    The source implementation and UI qualification now live in draft PR #529 @ d5e4387f44f07601c5530ad2de45ad445b5d2b8b. Latest full native-assembled Chromium #42994757894 PASS. The one pinned Windows FAT build is #42995166158; verify its final CI and actual installer ZIP artifact before choosing a build for this test. Prior JUCE 4-FX accepted snapshot and cold on-disk store tests #42972620482 2/2 PASS, not proof of physical cross-channel audio.

    Minimal reproducible owner/witness gate on the exact verified installer (no DSP code changes needed):

    1. Record installer/EXE SHA from BUILD_PROVENANCE.json, ASIO interface name, capture pins, render pins, rate, actual buffer, Windows version and exact plugin preset. Open app cleanly and ensure monitoring/audio is ready without the old Monitor/Arm setup. Preserve device identity.
    2. A/B the same recorded/live singer, same gain and wiring, for DRY, Pitch Tune lead, Natural Duo (2 pitched harmonies), HIGH register with correction on/off, and native Doubler (one unison singer), including sustained vowel, plosive, vibrato, note changes, silence/restart. Specifically mark any robotic HIGH, crackle, stutter, glitch, formant unnaturalness, mute or dropout. Record a short dry/wet comparison if convenient.
    3. At native ASIO buffer 64, 128, 256 (and actual rate 44.1/48 kHz if supported), capture processed sound plus XRUN counter, sample-rate readback, load/CPU, latency and device reconnect/reopen behavior. A green synthetic CTest does not substitute for these measurements.
    4. After exact plugin Save As to .armixfx, fully exit the app, relaunch, insert the same catalog on a different ChannelId, recall the named preset and verify physical audio changes only after DSP ACK/readback. Verify Rename/Delete don't change audio, factory is immutable, corrupt/stale/wrong catalog fails safely. Repeat on EQ (eight sequential band acknowledgements), Compressor, Vocal Throw and Harmonice when practical.
    5. If using collect_hardware_fat_windows.ps1 from the verified FAT ZIP for general hardware comparison, collect its required same-device 30-minute wired 0FX baseline and 30-minute wired 1FX with witness and full report; that collector is an evidence recorder only and is not a direct Harmonice quality metric.

    Exit: attach verified file/report and an explicit CLEAR/CRACKLE/INCONCLUSIVE verdict with corresponding exact SHA. Until then leave physical sound / ASIO field qualification OPEN. A clean software merge, if separately approved after Windows FAT, must not be advertised as a hardware-qualified stable release. This handoff intentionally does not change main or other PRs.

  5. added a commit that references this issue on Nov 11, 2026
  6. masarray commented on Nov 11, 2026

    @masarray
    OwnerAuthor

    Integration complete — code merged, physical acceptance still open

  7. changed the title [-][P0/P1] Harmonice direct Duo & real Doubler + shared native user presets for all built-in FX[/-] [+][P1][HARMONICE] Qualify Duo, real Doubler and built-in FX user presets[/+] on Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions