Repository navigation
Description
Milestone B verified triage — 2026-11-17:
P1/harmonice/feature/planned. Classification ≠ completion of product feature or physical FAT.Scope / release boundary: Portions may already ship; verify current before claiming work is missing.
Exit criteria:
- Audit current Windows product for VOICES=2 Duo, genuine separately controlled unison Doubler, native ACK and legacy 3/4/5 compatibility.
- Verify per-effect user presets survive .smix reopen, device switch and app restart; fill only source-proven gaps with real native PCM tests.
Canonical issue ledger. Preserve historical evidence below; no speculative merging or rewriting approved audio.
Owner feedback (2026-11-11)
Harmonice VOICES offers only 3/4/5, but factory Natural Duo uses 2 (native DSP already supports 2). There is no quick unison Doubler like BOSS VE; a real Doubler must be distinct from Duo (2 pitched backing harmony voices). In addition, every native built-in FX—EQ, Compressor, Harmonice, Vocal Throw—needs durable user-created per-effect presets saved with a professional compact Save As / recall / manage UX.
Executable spec & references: PR #532 / full workpack. Includes FabFilter/iZotope/Valhalla preset UX research and BOSS VE Double vs Unison/Harmony semantics.
Acceptance gates
- Direct VOICES 2 button with correct native ACK/readback, selected state, Duo preset synchronization, all current 3/4/5 workflows, compact GUI screenshots and persistence.
- Genuine deterministic Doubler unison DSP mode with versioned state migration, not a relabeled pitched voice count or fake selector; wet A/B stems, stereo/mono/PDC/CPU regression.
- One reusable per-FX preset bar (Factory vs My Presets, Modified, Save As, Save, Rename/Delete, duplicate/overwrite/cancel) in each built-in editor.
- Single native versioned, durable per-FX preset repository. After app restart, preset still accessible and can be applied audibly on another ChannelId; controls require matching DSP ACK/readback.
- Factory immutable; wrong-plugin, corrupt, duplicate, disk full/read-only, stale graph/epoch, moved FX fail without changing accepted audio.
-
.smixmixer session and.armixMy Sounds chain formats remain separate and compatible; no browser-only localStorage, no callback disk/heap/locks, no Monitor/Arm workflow. - Selective Windows native + Chromium tests, actual GUI evidence and separately qualified physical ASIO/listening A/B.
Concurrency/ownership: draft #529 already edits Harmonice GUI, lead Pitch Tune and toggle; integrate 2-button fix with its owner or immediately following it, without overwriting #529. #521 shorter latency remains experimental. This issue does not claim features are implemented.
Activity
masarray commentedon Nov 10, 2026
Execution specification is now merged into
mainvia #532 atddf7b2a9b8c97eadccb2bb96f06bf3abcafd5ddc.Canonical workpack: HARMONICE_DUO_DOUBLER_BUILTIN_FX_USER_PRESETS_20261111.md.
This merged milestone is docs only. Keep this issue open until direct 2-voice native GUI parity, real unison Doubler and durable native user presets for all built-in FX are implemented and validated. Coordinate overlapping Harmonice GUI work with draft #529.
masarray commentedon Nov 10, 2026
2026-11-11 execution status (continued after Work quota exhaustion)
a1ef2265624b8cfc6248064a2ee45b6313b8e92e. Fast native/DSP/UI and exact-SHA full Chromium passed. One new owner-dispatched Windows installer/FAT workflow 42901588669 underway. Owner's real HIGH voice crackle remains subject to recorded-vocal/ASIO listening gate; never claim resolved from synthetic checks.voiceMode=1withvoices=2..armixfxuser library for EQ/Compressor/Harmonice/Throw, with atomic Save As/overwrite/rename/delete, corruption/identity/portable tests. This is storage M1 only; not a completed end-to-end live DSP preset recall nor GUI Save Preset. Native Windows CTest 42902768602 underway.Keep this issue OPEN until all four FX Save/Recall actions are wired to native accepted DSP snapshots and ACK/readback through one reusable compact preset editor. Do not merge user-preset storage as a release feature just because the store unit test compiles.
masarray commentedon Nov 11, 2026
Harmonice execution checkpoint — 2026-11-11
Actual confirmed milestones:
dc63d1f92a9b877fac5cea22b97c1e467e2f465fWindows FAT #42923857425 succeeded. 12/12 focused Windows PCM/ASIO-boundary CTests PASS, real JUCE app and installer Preview/FAT artifact verified; still NOT a real singer/physical ASIO listening pass.87fd184b6dd39a81289d02c8220f42848372516cpasses Native DSP compile/PCM, Fast Native, Fast UI. One full Windows FAT #42927616818 requested since sharedsrc/Main.cppwas changed; one Chromium UI milestone requested, no claim of results before completion.241dd7541582382c8ee14b378c7a187d8e0943dd; typed EQ/Comp/Harmony/Throw schemas, atomic versioned.armixfx, portable workspace, SaveNew/Overwrite/Rename/Delete/List/Read, corruption/size/name/identity guards. Dedicated Windows JUCE 8 Release CTest #42927387929 succeeded after tests were changed from NDEBUG-elidedassertto liveREQUIRE, and deliberately corrupt JSON assertions were fixed. Old divergent DRAFT Built-in FX user presets M1: native durable typed store for EQ, Compressor, Harmonice and Throw #539 closed superseded. This is native storage M1 only, not user-facing presets.Still open: true per-effect GUI Save As/Recall/Modified/Rename/Delete for all four editors and atomic matching accepted DSP ACK/readback on another ChannelId (M2/M3); naturalness/glitches/high voice & true Doubler real sung chorus/vibrato qualification, physical ASIO 64/128/256 and XRUN/CPU, chord-aware music planner, final main integration. Do not count CI-green synthetic tests as proof that every remaining crackle is gone. Avoid simultaneous redundant expensive CI, and keep #529 draft until field audio acceptance and shared-main reconciliation.
masarray commentedon Nov 11, 2026
Harmonice / four-FX My Presets — final field acceptance handoff (2026-11-11)
The source implementation and UI qualification now live in draft PR #529 @
d5e4387f44f07601c5530ad2de45ad445b5d2b8b. Latest full native-assembled Chromium #42994757894 PASS. The one pinned Windows FAT build is #42995166158; verify its final CI and actual installer ZIP artifact before choosing a build for this test. Prior JUCE 4-FX accepted snapshot and cold on-disk store tests #42972620482 2/2 PASS, not proof of physical cross-channel audio.Minimal reproducible owner/witness gate on the exact verified installer (no DSP code changes needed):
BUILD_PROVENANCE.json, ASIO interface name, capture pins, render pins, rate, actual buffer, Windows version and exact plugin preset. Open app cleanly and ensure monitoring/audio is ready without the old Monitor/Arm setup. Preserve device identity..armixfx, fully exit the app, relaunch, insert the same catalog on a different ChannelId, recall the named preset and verify physical audio changes only after DSP ACK/readback. Verify Rename/Delete don't change audio, factory is immutable, corrupt/stale/wrong catalog fails safely. Repeat on EQ (eight sequential band acknowledgements), Compressor, Vocal Throw and Harmonice when practical.collect_hardware_fat_windows.ps1from the verified FAT ZIP for general hardware comparison, collect its required same-device 30-minute wired 0FX baseline and 30-minute wired 1FX with witness and full report; that collector is an evidence recorder only and is not a direct Harmonice quality metric.Exit: attach verified file/report and an explicit CLEAR/CRACKLE/INCONCLUSIVE verdict with corresponding exact SHA. Until then leave physical sound / ASIO field qualification OPEN. A clean software merge, if separately approved after Windows FAT, must not be advertised as a hardware-qualified stable release. This handoff intentionally does not change
mainor other PRs.Merge PR #529: Harmonice ensemble and shared native FX user presets
masarray commentedon Nov 11, 2026
Integration complete — code merged, physical acceptance still open
1a3741acffd34eef209ac9a5107088dacc703046, source testedd5e4387f44f07601c5530ad2de45ad445b5d2b8b.ArSonMix-Windows-FAT-Preview-42995166158, installer:ArSonMix-Windows-Installer-Preview-42995166158.main, not release authorization. Avoid reopening this finished source milestone merely because external hardware proof has not been collected.[-][P0/P1] Harmonice direct Duo & real Doubler + shared native user presets for all built-in FX[/-][+][P1][HARMONICE] Qualify Duo, real Doubler and built-in FX user presets[/+]