Repository navigation
Conversation
|
/arsonmix-ci native 02de9c6 |
|
2026-11-11 milestone recovery: previous Windows CTest 42902768602 failed at MSVC |
…ctual disk write/read, overwrite and UUID fencing
…g files in Release
…user preset store
…st failure instead of MSVC failfast
|
Superseded by clean latest-main PR #556, MERGED to |
Milestone M1 — shared native storage foundation (NOT yet complete end-user Save As feature)
Implements
src/BuiltInFxUserPresetStore.has one CONTROL/IO-thread service, backed by the installed/portablePortableWorkspaceroot and a separate versioned.armixfxuser preset format. EQ, Compressor, Harmonice and ArSon Vocal Throw use strict effect-scoped typed parameter validation, immutable generated preset IDs, bounded files, JSON content SHA, safe name rules, file staging + atomic replacement, enumerate/save-new/overwrite/rename/delete. No user data committed to repo. Different from.smixsession and.armixMy Sounds chain.Adds
tests/builtin_fx_user_preset_store_test.cpp(all four native schemas, save/read after new service instance, name collisions, rename/delete, hostile path, nonportable ChannelId, bad parameter, checksum tampering, wrong catalog) and one targeted JUCE CTest registration in CMake.Important ownership boundary: this stage intentionally does NOT mutate live published DSP or add fake browser preset buttons. The upcoming M2 native integration must capture accepted FX settings and apply through existing per-FX SPSC + audio-applied ACK/readback; M3 will add one shared compact preset control to all native FX editors, respecting factory/user, dirty state and save conflict UI. Do not advertise this PR as user-visible completed Save As.
Design/workpack issue #533, merged architecture. This branch is independent of current P0 Harmonice #529 and P1 Doubler #537; preserve their schema migrations before wiring the real controls. Test and integrate without plugin-instance-only storage or callback disk I/O.
CI policy: fast contracts, then one exact-SHA native Windows CTest via existing owner-dispatch; leave Draft until CTest and future native ACK/UI integration proves real audible recall.