Skip to content

DRAFT Built-in FX user presets M1: native durable typed store for EQ, Compressor, Harmonice and Throw - #539

Closed
masarray wants to merge 10 commits into
mainfrom
feature/builtin-fx-user-preset-store-20261111
Closed

masarray wants to merge 10 commits into
mainfrom
feature/builtin-fx-user-preset-store-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

Milestone M1 — shared native storage foundation (NOT yet complete end-user Save As feature)

Implements src/BuiltInFxUserPresetStore.h as one CONTROL/IO-thread service, backed by the installed/portable PortableWorkspace root and a separate versioned .armixfx user preset format. EQ, Compressor, Harmonice and ArSon Vocal Throw use strict effect-scoped typed parameter validation, immutable generated preset IDs, bounded files, JSON content SHA, safe name rules, file staging + atomic replacement, enumerate/save-new/overwrite/rename/delete. No user data committed to repo. Different from .smix session and .armix My Sounds chain.

Adds tests/builtin_fx_user_preset_store_test.cpp (all four native schemas, save/read after new service instance, name collisions, rename/delete, hostile path, nonportable ChannelId, bad parameter, checksum tampering, wrong catalog) and one targeted JUCE CTest registration in CMake.

Important ownership boundary: this stage intentionally does NOT mutate live published DSP or add fake browser preset buttons. The upcoming M2 native integration must capture accepted FX settings and apply through existing per-FX SPSC + audio-applied ACK/readback; M3 will add one shared compact preset control to all native FX editors, respecting factory/user, dirty state and save conflict UI. Do not advertise this PR as user-visible completed Save As.

Design/workpack issue #533, merged architecture. This branch is independent of current P0 Harmonice #529 and P1 Doubler #537; preserve their schema migrations before wiring the real controls. Test and integrate without plugin-instance-only storage or callback disk I/O.

CI policy: fast contracts, then one exact-SHA native Windows CTest via existing owner-dispatch; leave Draft until CTest and future native ACK/UI integration proves real audible recall.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 02de9c6

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 506e664
Status:⚡️  Build in progress...

View logs

Copy link
Copy Markdown
Owner Author

2026-11-11 milestone recovery: previous Windows CTest 42902768602 failed at MSVC juce::CharacterFunctions::isHexDigit (not available in pinned JUCE); the only reported compiler errors were C2039/C3861 on this call. Replaced with bounded portable ASCII hexadecimal validation, plus mixed-case UUID acceptance / G and slash rejection regressions. Latest branch HEAD b229e0125f151f94e13f2558c9227fb2fa300200; Fast Native and Native DSP jobs green. Windows native CTest has not yet been rerun on this SHA and storage M1 is still Draft. Live FX accepted-snapshot Save/Recall and compact preset selector for EQ/Compressor/Harmonice/Throw are still missing; never advertise user presets as a completed UI feature. Avoid simultaneous costly Windows jobs while P0 Harmonice focused FAT is active.

Copy link
Copy Markdown
Owner Author

Superseded by clean latest-main PR #556, MERGED to main at 241dd7541582382c8ee14b378c7a187d8e0943dd. The new branch preserves all four built-in FX type schemas, fixes Release/NDEBUG side-effecting asserts, fail-closes on corrupt libraries, and passes exact-source Windows MSVC Release disk roundtrip CTest. This old branch was behind main and failed an unrelated WaveShell quick test due to missing newer source; do not remerge its stale CMake/workflow. M2 live accepted-state Save/Recall and all four GUI preset controls remain open issue #533. Closing this obsolete draft only.

@masarray masarray closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant