Skip to content

Built-in FX user presets M1: Release-tested native disk repository on latest main - #556

Merged
masarray merged 4 commits into
mainfrom
feature/native-fx-user-presets-m1-rebased-20261111
Nov 11, 2026
Merged

masarray merged 4 commits into
mainfrom
feature/native-fx-user-presets-m1-rebased-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

Reconciled milestone M1 (no abandoned-branch regressions)

This PR ports the native store from old draft #539 onto current main snapshot 7108959471f3d37006d7b36869e32794e211f31a without altering live audio, plugin host, session restore, or WebView GUI. Supersedes #539 once verified.

All four built-ins: EQ, Compressor, Harmonice, Vocal Throw. One typed, per-effect, user-owned .armixfx JSON library in the portable/native workspace; atomic replace and checksum, generated opaque UUID, save-as/overwrite/rename/delete/list/read. It is separate from .smix sessions and chain .armix presets; no file I/O or malloc in ASIO callback. Strict validation rejects cross-catalog and session-specific guide ChannelId, unsafe names, corrupt JSON and exceeding physical file quotas.

Release qualification correction: previous CTest used assert(...) around mutating Save/Read operations; with MSVC Release/NDEBUG that skipped the entire test. All checks now use ALWAYS-active REQUIRE and report a meaningful failed expression; corrupted JSON is parsed then checksum-tampered deterministically. Added a dedicated single-target Windows MSVC JUCE8 Release CTest workflow, not a full costly installer/80+ tests, and one CMake target. The old branch also missed a newer WaveShell quick test, hence fresh latest-main reconciliation instead of adding an exception.

Explicitly NOT yet M2/M3: no live accepted-state Save action, no native queued recall ACK/readback, and no reusable built-in FX editor preset bar. This infrastructure PR is not presented as the completed user-facing feature. Keep draft until actual Windows Release file-IO CTest green; next stage bridges 4 FX with exact live DSP ACK before release.

Cross-workstream safety: zero modifications to src/Main.cpp, VST3 host, user GUI, accepted PCM routing, Inno installer, ASIO or Harmony M3–M5 candidate.

@masarray
masarray marked this pull request as ready for review November 11, 2026 00:00
@masarray
masarray merged commit 241dd75 into main Nov 11, 2026
6 of 7 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-11T00:00:21.582230Z
We couldn’t complete this review. Comment @codex review to try again.
690838b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant