Repository navigation
Built-in FX user presets M1: Release-tested native disk repository on latest main - #556
Merged
masarray merged 4 commits intoNov 11, 2026
Merged
Conversation
…test main without stale workflow
…t.cpp onto latest main without stale workflow
…tive.yml onto latest main without stale workflow
masarray
marked this pull request as ready for review
November 11, 2026 00:00
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconciled milestone M1 (no abandoned-branch regressions)
This PR ports the native store from old draft #539 onto current
mainsnapshot7108959471f3d37006d7b36869e32794e211f31awithout altering live audio, plugin host, session restore, or WebView GUI. Supersedes #539 once verified.All four built-ins: EQ, Compressor, Harmonice, Vocal Throw. One typed, per-effect, user-owned
.armixfxJSON library in the portable/native workspace; atomic replace and checksum, generated opaque UUID, save-as/overwrite/rename/delete/list/read. It is separate from.smixsessions and chain.armixpresets; no file I/O or malloc in ASIO callback. Strict validation rejects cross-catalog and session-specific guide ChannelId, unsafe names, corrupt JSON and exceeding physical file quotas.Release qualification correction: previous CTest used
assert(...)around mutating Save/Read operations; with MSVC Release/NDEBUG that skipped the entire test. All checks now use ALWAYS-activeREQUIREand report a meaningful failed expression; corrupted JSON is parsed then checksum-tampered deterministically. Added a dedicated single-target Windows MSVC JUCE8 Release CTest workflow, not a full costly installer/80+ tests, and one CMake target. The old branch also missed a newer WaveShell quick test, hence fresh latest-main reconciliation instead of adding an exception.Explicitly NOT yet M2/M3: no live accepted-state Save action, no native queued recall ACK/readback, and no reusable built-in FX editor preset bar. This infrastructure PR is not presented as the completed user-facing feature. Keep draft until actual Windows Release file-IO CTest green; next stage bridges 4 FX with exact live DSP ACK before release.
Cross-workstream safety: zero modifications to
src/Main.cpp, VST3 host, user GUI, accepted PCM routing, Inno installer, ASIO or Harmony M3–M5 candidate.