Repository navigation
M4: typed FX host envelope hardening compatible with Harmonice presets and O1/O2 - #569
Merged
Merged
Conversation
Owner
Author
|
/arsonmix-ci native 798f315 |
Deploying arsonmix with
|
| Latest commit: |
798f315
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9fa0c2a2.arsonmix.pages.dev |
| Branch Preview URL: | https://guard-m4-fx-control-envelope.arsonmix.pages.dev |
This was referenced Nov 11, 2026
masarray
marked this pull request as ready for review
November 11, 2026 06:23
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#527 — Shared host contract, cross-thread compatible
Live reconciliation:
main@b5b03669c616ac55a5d935023e0402ec7a99f7be; Harmonice #529 headbc580cdfa851d5cb281e72b6f2e171f294171a03uses the byte-identicalsrc/NativeFxControlRequest.h(257a7a0eb0a8aa045c090ae87be05112aaa5a014) to validate editor and new My Presets commands. O1/O2 #563 is still running on a baseline before this header existed; its graph/device/GUI changes do not touch either modified file here. Other open #521/#512 also do not touch these files. Do not merge their unqualified DSP/ASIO branches into this PR.Concrete defect / improvement
All existing native built-in editors shared a CONTROL-thread request parser, but its
static_cast<int>(args.slot)silently coerced JS strings, fractional doubles and booleans;requestId.toString()converted non-string IDs, andworkspaceToken.toString()could turn a numeric token into an apparent logical authority. The same parser now serves Harmonice's editor/preset lifecycle—these ambiguous host identities are unsafe and harder to maintain.src/NativeFxControlRequest.h: reject non-object envelopes, non-integer slot types, non-string requestId, non-string workspace token, invalid max slot bounds. Retain all valid payload strings and integer slot semantics. No change to FX DSP, lease lifetime or graph publication.tests/native_fx_registry_extension_test.cpp: typed, malformed, bool, float, int64 slots; requestId and workspace token coercion; exactuint64identity; LOGICAL_ONLY epoch 0 still supports offline FX sequence without admitting LIVE PCM; Harmonice's newhpres-preset ID remains a valid target without accidentally becoming a DSPharm-mailbox.Qualification
One fast native path and one exact HEAD Windows MSVC/full CTest after green fast checks. No Chromium—only CONTROL C++ parsing and C++ test changed; no FAT ZIP or manual ASIO listening claimed. One authoritative
/preview/, one JUCE callback, real ChannelId/lease authority preserved. Test evidence and potential merge conflicts with Harmony/O branches must be checked before merge.