Repository navigation
O1–O6: native ASIO Multi-Out with safe per-ChannelId physical restore - #563
Conversation
… publish live output readback
…IO channel buffers
…ternal OUT selectors
…/Needs Remap readback
…n, ACK then readback
… FX-once and stale edits
Deploying arsonmix with
|
| Latest commit: |
aa917e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14dcf210.arsonmix.pages.dev |
| Branch Preview URL: | https://feature-o1-physical-multiout.arsonmix.pages.dev |
…ntrols in approved assembler
…ntrols in approved assembler
…c V28 HTML/CSS drift
|
/arsonmix-ci ui b67d3ba |
|
/arsonmix-ci fat b67d3ba |
…ly once per block
O2 latest additive checkpoint — 78f7813
|
|
Cross-thread qualification status (source audit, 2026-11-11): the original fully reconciled O1/O2 candidate Do not promote those results to the current #563 HEAD Maintainability #571/#572 are independent CONTROL-only candidates (M2 typed device identity, M3 renderer evidence, M4 built-in prepare preflight) under separate exact-SHA Windows CI; no O1 changed files were modified. No blocker to continued O1 work and no manual coordinator gate is being imposed. |
|
/arsonmix-ci ui 1504688 |
|
/arsonmix-ci fat 1504688 |
|
/arsonmix-ci ui 869b7cb |
|
/arsonmix-ci fat 603dc2a |
O4 PHYSICAL ASIO EIGHT-OUTPUT WITNESS SHEET — verification pending, not certificationCandidate: PR #563
Acceptance sequence (observe, do not assume): Confirm active driver/pin labels, start with safe speaker/amp gain. At 44.1 kHz and 48 kHz and supported 128/256-frame buffers, test each line with zero FX, then a distinctive real VST3 on BUS A only; physically listen or capture each stereo pair independently and record peak/RMS or loopback measurements. Turn MAIN MUTE ON: only MAIN 1/2 goes silent, EXTERNAL continues. Turn global hardware output MUTE ON: all four stereo pairs go silent. Choose shared 3/4 deliberately with two ChannelIds and verify controlled sum/no unexpected clipping. Retarget/remove each external patch, switch to a driver with a missing pin and back, and reload Record for each device: model, exact ASIO driver/version, active enabled physical pins, sample rate, buffer, USB/clock topology, observed routed pair, what the listener/loopback heard, XRUN evidence and witness. Do not mark PASSED until this is recorded. Windows CI output isolation CTest is not proof of a real DAC/speaker. |
|
/arsonmix-ci fat bc88ece |
|
/arsonmix-ci ui 542c93a |
|
/arsonmix-ci fat 542c93a |
O6 integrated software checkpoint (verified 2026-11-11)
|
|
/arsonmix-ci fat aa917e3 |
O6 final FAT infrastructure remediation (2026-11-11)
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Scope
Milestone O1 + O2 only. Milestone H is intentionally untouched. Base branch moves with other threads; this PR is dedicated to physical ASIO multi-output.
Integrated implementation
O2 deterministic PCM extension (2026-11-11)
d0ccd611e6ad59d0870cce9941102cd750ce0e0cextends the CTest harness with explicit 4- and 8-output PCM fixtures, three independently mapped logical sources and callback-applied readback versus CONTROL-only requested state.2d8e0d8cannot qualify this commit. Physical eight-output listening/capture remains PENDING.O1/O2 follow-on safety and qualification (2026-11-11)
ba409b361b604e083c0e817d7834fc1354f0e231; O1 engine/GUI/.smix is still ONE native callback and ONE approved/preview/bundle.DynamicNativeSessionPublisher::rendernow zeros all callback-provided physical output buffers on mute, stale device epoch, invalid render or failed graph publication; previously it cleared MAIN/MONITOR only.NDEBUGdisabled before<cassert>in the two affected physical tests so tests actually execute their sample assertions.main@c63e6abwith a two-parent merge retaining M5 exact logical FX/WIRE readback and FX lease ownership guards. Current main has since moved to M5: extract native operator presentation policies and guard failed-readback messaging #568; forward-reconcile again before any merge without invalidating in-flight exact-SHA FAT.Release gates
Concurrent work
Do not overwrite Maintainability, Harmonice, FX Presets or Release. Will reconcile the final PR head against latest main before merge.
O3 OUTPUTS overview + assembled external-routing acceptance (2026-11-11)
1504688e511375c2fbe4b588bbc7332d7af89b6f(the previously qualifiedcdc73973is not this head).web/approved-native-contract.jsandtests/approved_native_m2_contract.test.cjs. Runtime DOM writes only on patch-state changes:web/approved-native-bridge.js.tests/approved_native_wire_gain_smoke.pyexercises the genuinely assembled native/preview/HTML: physical ASIO selector ->routingExternalOutput-> rejected ACK rollback; accepted ACK still PENDING until later callback readback; LIVE, SHARED, MUTED and NEEDS_REMAP. The backend is controlled test instrumentation, not physical ASIO proof.cdc73973passed, but exact O3 HEAD FAT and real physical 44.1/48 kHz 4/8-output listening/capture, clip/XRUN and plugin qualification remain PENDING. Avoid duplicate expensive MSVC queues; do not merge or claim global DAW parity until gates/evidence are complete.O3 regression fix and exact-HEAD checkpoint (supersedes earlier SHA above)
869b7cb0cf309449666f342b7693d28dd16272a9; main comparison behind 0, ahead 52, Draft/mergeable at inspection.1504688erun 42979824287 FAILED: the new OUTPUTS<details>duplicated the existing Advanced<summary>and broketests/approved_native_cold_start_smoke.py's unique locator. This is a concrete O3 regression, not a hardware/PCM failure.869b7cb: OUTPUTS is now an always-visible, read-only compact<section>; Advanced remains the one original<details>, no broader test selectors or safety changes. The O3 source contract checks the unique disclosure. The new full Chromium run 42980609202 COMPLETED SUCCESS at this exact HEAD: the prior failing Cold Start First WIRE/VST3 step, the new assembled EXTERNAL OUT ACK/LIVE/MUTED/SHARED/REMAP scene, and all remaining full browser GUI checks passed. This proves the WebView/mock-control acceptance, NOT real ASIO analog output.1504688e: still IN PROGRESS at checkpoint. No second expensive MSVC build was triggered while it compiles. Because JS GUI and tests changed at869b7cb, the old FAT cannot qualify the latest SHA automatically. Final artifact remains UNQUALIFIED without 44.1/48 kHz real ASIO physical listening/loopback/XRUN evidence for 1/2,3/4,5/6,7/8.O4 Cross-pair alias hardening and exact-head Windows FAT (2026-11-11)
603dc2adef24514f4081b1462003225a3e5c2e0f, based onmain@fd2dd0c4d9cb78abd34c6f12e28f33f0e8a55b74(0 commits behind at checkpoint).engine/core/DynamicPreparedMixerBlock.hnow rejects any duplicate non-null physical output pointer before external summing. Bounded pointer comparisons, no allocations/locks/new DSP/second callback; the existing native publisher silences all output buffers on failure.verifyCrossExternalAliasFailsClosedAndRecovers()intests/physical_external_output_pcm_test.cpp: conflicting BUS A/B output memory makes the entire device output silent, then removing the alias restores distinct PCM automatically on the next callback with no re-ARM/WIRE. The test is included in existingO1PhysicalExternalOutputNativePcmAndFailClosedRoutingCTest via the existing CMake dependency.869b7cb: SUCCESS; no UI change in O4.1504688e: SUCCESS and produced bothArSonMix-Windows-FAT-Preview-42980101537andArSonMix-Windows-Installer-Preview-42980101537. This does NOT include O4.O5 — callback-failed PCM applied readback revocation (2026-11-11)
bc88ecebc9763087d04907c409d9b21b7d8700ed; mainfd2dd0c4d9cb78abd34c6f12e28f33f0e8a55b74(behind 0, ahead 54 at checkpoint). Kept Draft; do not conflate hardware installation proof with test backend PCM.externalAppliedTargets_retained prior callbackLIVEstatus. This could misleadingly paint an EXTERNAL ASIO patch LIVE while the last callback was rejected.engine/core/DynamicPreparedMixerBlock.h: bounded no-heap AUDIO helperinvalidateAppliedExternalOutputs()resets callback-applied evidence only, not CONTROL assignment or ChannelId/WIRE/FX graph.engine/core/DynamicNativeSessionPublisher.h: revoke on current-epoch unsafe graph render and input/quantum mismatch before existing all-output silence. The next legitimate callback restores applied identity; a stale other device epoch cannot revoke current graph.tests/physical_external_output_pcm_test.cpp: explicitly verifies bus A/B LIVE, cross-output aliased callback silence plus APPLIED revoked, successful automatic recovery of each independently mapped output, and current-epoch 3-in/4-in mismatch revoking readback without deleting the CONTROL patch.fatrequested by the GitHub owner through CI command; qualification/run and new artifacts pending. Do not launch a separatenativebuild for this HEAD.O6 — per-amplifier ASIO provenance, independent .smix recovery, Harmony reconciliation (2026-11-11)
542c93aff2d47dc32e106014f3c95a867e6ed430, two parents O6abc4d42fd1cea532a107e466b5290d08d8e99c00and latest mergedmain@1a3741acffd34eef209ac9a5107088dacc703046(PR 0 commits behind when inspected, mergeable, remains Draft).MixerDeviceBindingPolicy::apply()may replacedocument.binding.playbackon verified device switch. Previously EXTERNAL patches stored only generic physical pin labels, so an entirely DIFFERENT ASIO device with matchingOUT 3/4labels could be reauthorized from old .smix without renewed operator confirmation. A missing saved OUT pair also blocked all other exact valid pairs as one global all-or-nothing decision.src/NativeMixerSessionDocument.hpersists optional per-ChannelIdplaybackDeviceprovenance; legacy v1 .smix inherits ONLY original saved binding; rebinding retains old confirmed device identity, and exact user confirmation creates new identity. A pure control-threadcanRestoreExternalOutputvalidates physical enabled callback ordinals, exact pin names, driver identity and exclusive MAIN/MONITOR before approving a pair.src/LiveDryRoutingLab.hreinstalls only individually verified same-device physical EXTERNAL pairs. Unavailable/renamed/colliding/different-driver pairs stay remembered but DISARMED and report NEEDS_REMAP; no implicit second callback, WIRE, VST3 clone, or user Monitor/ARM step for a still-valid pair.tests/native_mixer_session_store_test.cppcovers changed driver with identical labels through bind, persistence across Save/Open, six-pin sparse active mask with one surviving valid pair, MAIN/MONITOR conflict, renamed labels, old .smix migration and malformed device provenance.abc4d42pre-reconciliation Fast UI, Fast Native, Harmony DSP and targeted Windows Release CTest passed. Final merged HEAD542c93aff2d47dc32e106014f3c95a867e6ed430fast checks and full exact-head Chromium UI are under qualification at this checkpoint; do not conflate prior SHA passes with final HEAD. Old O5 FAT 42997634632 was still compiling at this checkpoint, no O6 installer available yet.