Repository navigation
Release candidate: reconcile device and FX maintainability with Harmonice and Hotkeys - #573
Merged
Merged
Conversation
Owner
Author
|
/arsonmix-ci fat ad1c6a0 |
Deploying arsonmix with
|
| Latest commit: |
ad1c6a0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://467c97ea.arsonmix.pages.dev |
| Branch Preview URL: | https://integration-release-maintain.arsonmix.pages.dev |
masarray
marked this pull request as ready for review
November 11, 2026 10:38
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates #571 and #572 on main
1a3741acffd34eef209ac9a5107088dacc703046, which already includes Hotkeys H1/H2, Harmonice #529, and the shared native FX preset and GUI changes. Includes strict device identity ingress, sustained native render evidence and fail-fast FX preparation. The integration diff is seven files and has no GUI changes relative to main.Multi Out #563 remains an independent candidate with physical ASIO FAT pending. This PR does not retire the PCM compatibility path or publish a release.
Qualification: targeted local C++ and GUI contracts, then one Windows FAT build for the exact candidate, and Chromium for the combined candidate if the already qualified GUI tree cannot be reused. Physical evidence remains independent.