Repository navigation
M6: current FX ownership guide and safe Harmony/O1 integration rules - #570
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#527 — Maintainable onboarding, architecture truth and concurrent PR interoperability
Refresh the contributor entrypoint and feature-extension playbook from live
main@b5b03669c616ac55a5d935023e0402ec7a99f7be. Existing docs were frozen at the first M6 workpack and still omitted the actually merged #565, #567, #564, #568.Changes
CONTRIBUTING.md: explicit sharedNativeFxControlRequestownership and pure JS contract / browser adapter split; cross-thread guidance for active Harmonice #529, physical output #563, candidate M4: typed FX host envelope hardening compatible with Harmonice presets and O1/O2 #569. Require final combined HEAD CI, not a new sign-off committee.docs/architecture/FEATURE_EXTENSION_PLAYBOOK.md: production FX extension recipe now references exact native typed envelopes, logical-only epoch 0 andhpres-distinct from realtimeharm-commands; no new host or DSP stage.docs/architecture/README.md: accurate M0–M6 merged-versus-partial status; O1/O2 candidate not merged into main, physical ASIO FAT unproven; source map includes shared host request.All three changed paths are disjoint from active #529/#563/#521/#512 code work. Docs only: no C++, JavaScript runtime, GUI, DSP, ASIO, workflow or product behavior changes. By smart CI policy, inspect links and diff only; NO Windows or Chromium dispatch.