Repository navigation
Harmonice P0 A/B diagnostics: isolate LOW/MID/HIGH PCM stems and verify recombination - #543
Merged
masarray merged 3 commits intoNov 10, 2026
Conversation
…s and verify linear recombination
masarray
marked this pull request as ready for review
November 10, 2026 22:18
masarray
merged commit Nov 10, 2026
2a8c4e8
into
integration/harmonice-lead-ensemble-20261111
1 of 2 checks passed
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner reports HIGH intermittency, robotic stutter in dense chorus/long vibrato while LOW is audible. Extend the actual native
ARMixHarmonyOfflineAbWAV renderer to produce LOW/MID/HIGH separate wet-only outputs (including each voice's own early/late room contribution) and per-register RMS inmetrics.json, for a reproducible listening A/B. Implement by preparing a fresh nativeEngineper register and muting only other singers' prepared mix gains; original dry lead remains invariant and is subtracted. No browser DSP, no new realtime callback, no effects on shipped graph. Synthetic CTest recombines all three stems and checks numerical parity against whole backing, and asserts HIGH audible. Not yet a real-singer or ASIO certification. Stack on current #529 candidate99bfbc439d408343e99f744f23b56e8d85a168dd, merge only after fast DSP CI. The extra WAV files make it possible to distinguish actual HIGH synthesis glitches from mix masking without a second DSP codepath.