Skip to content

P0 Harmonice: high-vocal epoch continuity, anti-glitch render and direct Duo selector - #535

Merged
masarray merged 7 commits into
integration/harmonice-lead-ensemble-20261111from
fix/harmonice-high-voice-continuity-duo-20261111
Nov 10, 2026
Merged

masarray merged 7 commits into
integration/harmonice-lead-ensemble-20261111from
fix/harmonice-high-voice-continuity-duo-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

Direct follow-up to owner singer field report — stacked on #529

Owner hears fast interrupted/crackling harmonic tones, LOW improving, HIGH often absent/robotic, vibrato-like glitching. The previous 80/80 Windows CTest and single-engine CPU profile are not singer/ASIO guarantees.

Source-backed failure hypotheses and targeted corrections

  1. HarmonyPitchSynchronous::findPositiveEpoch() required positive waveform peaks >0.003 fixed full-scale. Faint upper-register harmonics and negative-skewed voiced signals can pass the upstream pitch detector yet yield no PSOLA grains. Replace with finite signed landmark selection at a conservative near-zero silence threshold; maintain each voice's chosen polarity through its phrase, refine extrema consistently and keep bounded <=one-period scans.
  2. HarmonyDsp::finishPitchAnalysis() immediately released voiced tracking on one uncertain non-silent hop; now bridges at most two ambiguous analyses (~13ms at 48k), while actual silence still releases immediately.
  3. shifted() previously filtered sync.sample=0 while PSOLA had ready=false, causing audible amplitude modulation during the 12ms renderer crossfade. Do not inject invalid samples; use continuously running granular fallback on missing PSOLA output. Apply note-rate hysteresis (enter .86, exit below .79 for 3 confirmed hops) to avoid switch-flapping at the .82 border.
  4. Expose native VOICES 2 next to 3/4/5 in approved Harmonice GUI. Duo remains two pitched backing voices + original lead; this is NOT the future unison Doubler. Narrow width hides only decorative glyphs, not count/controls.

Regression tests

  • Existing pure C++ PSOLA test now forces soft negative- and positive-polarity C6 singing with 64/257-size callbacks, checks nonzero sustained output and sample partition equality.
  • Existing approved native Harmony Chromium smoke explicitly selects every 2/3/4/5 button, tests Natural Duo preset, native DSP request/ACK/readback and correction state preservation.
  • Assembly contract verifies Duo control and valid range; all previous pitch/PDC/singer tests unchanged.

Constraints and coordination

Required follow-up

Check CI C++ DSP and Chromium on exact new SHA; avoid duplicate Windows full runs. Generate 3-stem quiet soprano, loud soprano and male low VocalSet loudness-matched ABX, plus physical ASIO callback/XRUN evidence. This source change is not proof that the singer crackle is fully fixed; distinguish DSP intermittency from hardware XRUNs with recorded evidence.

@masarray
masarray marked this pull request as ready for review November 10, 2026 20:48
@masarray
masarray merged commit a1ef226 into integration/harmonice-lead-ensemble-20261111 Nov 10, 2026
10 of 11 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T20:48:05.099367Z
We couldn’t complete this review. Comment @codex review to try again.
df8a593 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant