Repository navigation
P0 Harmonice: high-vocal epoch continuity, anti-glitch render and direct Duo selector - #535
Merged
masarray merged 7 commits intoNov 10, 2026
Conversation
masarray
marked this pull request as ready for review
November 10, 2026 20:48
masarray
merged commit Nov 10, 2026
a1ef226
into
integration/harmonice-lead-ensemble-20261111
10 of 11 checks passed
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Nov 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct follow-up to owner singer field report — stacked on #529
Owner hears fast interrupted/crackling harmonic tones, LOW improving, HIGH often absent/robotic, vibrato-like glitching. The previous 80/80 Windows CTest and single-engine CPU profile are not singer/ASIO guarantees.
Source-backed failure hypotheses and targeted corrections
HarmonyPitchSynchronous::findPositiveEpoch()required positive waveform peaks >0.003 fixed full-scale. Faint upper-register harmonics and negative-skewed voiced signals can pass the upstream pitch detector yet yield no PSOLA grains. Replace with finite signed landmark selection at a conservative near-zero silence threshold; maintain each voice's chosen polarity through its phrase, refine extrema consistently and keep bounded <=one-period scans.HarmonyDsp::finishPitchAnalysis()immediately released voiced tracking on one uncertain non-silent hop; now bridges at most two ambiguous analyses (~13ms at 48k), while actual silence still releases immediately.shifted()previously filteredsync.sample=0while PSOLA hadready=false, causing audible amplitude modulation during the 12ms renderer crossfade. Do not inject invalid samples; use continuously running granular fallback on missing PSOLA output. Apply note-rate hysteresis (enter .86, exit below .79 for 3 confirmed hops) to avoid switch-flapping at the .82 border.Regression tests
Constraints and coordination
b582f2cafee7d538d7927b901c2dea595c458171. This is a stacked PR and is intentionally NOT ready to merge to main directly. Don't rewrite main from an older ancestry. Merge this into Harmonice P0: stereo lead Pitch Tune, register-aware ensemble and compact switch #529 only after exact SHA CI and review; reconcile Harmonice P0: stereo lead Pitch Tune, register-aware ensemble and compact switch #529 with main M1: consolidate logical mixer control and restore native WIRE impact #530/docs(fx): Harmonice Duo/Doubler parity and universal built-in user preset architecture #532 before eventual final main merge..smix, native graph, 8ms bypass, 1536-sample 48k PDC; no new audio callback, allocations, device routing, library/algorithm external dependencies.Required follow-up
Check CI C++ DSP and Chromium on exact new SHA; avoid duplicate Windows full runs. Generate 3-stem quiet soprano, loud soprano and male low VocalSet loudness-matched ABX, plus physical ASIO callback/XRUN evidence. This source change is not proof that the singer crackle is fully fixed; distinguish DSP intermittency from hardware XRUNs with recorded evidence.