Skip to content

DRAFT Harmonice P1: genuine unison Doubler mode, native control and v3 session migration - #537

Closed
masarray wants to merge 12 commits into
integration/harmonice-lead-ensemble-20261111from
feature/harmonice-true-unison-doubler-20261111
Closed

masarray wants to merge 12 commits into
integration/harmonice-lead-ensemble-20261111from
feature/harmonice-true-unison-doubler-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

Product scope

Build an authentic unison vocal Doubler akin to BOSS VE's Double/Unison workflow, not a renamed voices=2 harmony preset.

Separate from P0: based on current Harmonice PR #529, including #535's quiet/HIGH continuity fix and direct VOICES 2. Does not affect main, public alpha or the unqualified #521 latency research.

Real native implementation

  • HarmonyDsp::Settings::voiceMode with strict values 0=Harmony, 1=Doubler. Harmony 2–5 semantics unchanged; Doubler prepares only one synthetic wet unison take, whose target pitch ratio is unity to follow the sung melody independent of key/scale. Existing individual micro-detune, onset, timbre, positional processing and shared room provide humanized doubling. Lead Pitch Tune is independent and remains OFF unless explicitly enabled.
  • Narrow native GUI HARMONY / DOUBLER segment, actual mode control sent to JUCE, DSP-accepted ACK/readback, disables irrelevant key/voice-count controls in Double; factory Double Light / Double Wide with different wet/Space and no implicit correction. Duo remains two pitched wet voices, not double.
  • Versioned native processor state AHM1/v3 includes voiceMode; readers accept v1/v2 as Harmony and v3 as requested. Native response schema 3 and strict typed settings ingestion. No second PCM graph or UI renderer, no delay/PDC change.

Coverage

  • Pure C++ PCM: one unison wet backing lane vs two pitched Duo roles; double unison unaffected by key/scale, distinct actual PCM output, 48/96k finite.
  • Windows JUCE code: cold legacy v1/v2→Harmony and v3 Doubler state roundtrip across sample-rate change.
  • Emulated JUCE Chromium: mode buttons keep accepted (not requested) state until ACK/readback, Duo and Double Wide presets, disabled irrelevant key/voices, switch-back restores Harmony control; same 1366/720/390 viewports.
  • Native contract static tests inspect Main.cpp and serializer, preserve existing FX picker.

Not yet acoustically qualified: 1 generated pitch-synchronous unison take still depends on source period/epoch quality and real singer evidence; no claim that it is indistinguishable from a manually doubled vocal. CPU/driver/XRUN and hardware ASIO remain independent FAT gates. User Presets are a separate shared native feature tracked in #533; this branch does not implement native preset storage or pretend JS factory presets are user files.

Release policy

Keep Draft; only integrate after fast native/UI+DSP checks and optional exact-SHA Windows FAT. Do not merge to main while P0 singer crackle and real-mic qualification are unresolved.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4321b7e
Status: ✅  Deploy successful!
Preview URL: https://d132225c.arsonmix.pages.dev
Branch Preview URL: https://feature-harmonice-true-uniso.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

Superseded safely by merged #554. All nine reviewed changes were ported with exact-context matching on top of Windows-FAT qualified M3/M4 candidate, rather than merging this old branch and reverting PSOLA/octave fixes. Current candidate is #529 head 87fd184b6dd39a81289d02c8220f42848372516c; Native DSP, Fast Native and Fast UI are green. Closing this obsolete diverged draft only; new M5 still requires Windows/ASIO and owner acoustic acceptance. Do not cherry-pick old PR after this point.

@masarray masarray closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant