Repository navigation
DRAFT Harmonice P1: genuine unison Doubler mode, native control and v3 session migration - #537
Closed
masarray wants to merge 12 commits into
Conversation
Deploying arsonmix with
|
| Latest commit: |
4321b7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d132225c.arsonmix.pages.dev |
| Branch Preview URL: | https://feature-harmonice-true-uniso.arsonmix.pages.dev |
This was referenced Nov 10, 2026
Merged
Owner
Author
|
Superseded safely by merged #554. All nine reviewed changes were ported with exact-context matching on top of Windows-FAT qualified M3/M4 candidate, rather than merging this old branch and reverting PSOLA/octave fixes. Current candidate is #529 head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product scope
Build an authentic unison vocal Doubler akin to BOSS VE's Double/Unison workflow, not a renamed
voices=2harmony preset.Separate from P0: based on current Harmonice PR #529, including #535's quiet/HIGH continuity fix and direct VOICES 2. Does not affect main, public alpha or the unqualified #521 latency research.
Real native implementation
HarmonyDsp::Settings::voiceModewith strict values0=Harmony,1=Doubler. Harmony 2–5 semantics unchanged; Doubler prepares only one synthetic wet unison take, whose target pitch ratio is unity to follow the sung melody independent of key/scale. Existing individual micro-detune, onset, timbre, positional processing and shared room provide humanized doubling. Lead Pitch Tune is independent and remains OFF unless explicitly enabled.HARMONY / DOUBLERsegment, actual mode control sent to JUCE, DSP-accepted ACK/readback, disables irrelevant key/voice-count controls in Double; factoryDouble Light/Double Widewith different wet/Space and no implicit correction. Duo remains two pitched wet voices, not double.AHM1/v3includes voiceMode; readers accept v1/v2 as Harmony and v3 as requested. Native response schema 3 and strict typed settings ingestion. No second PCM graph or UI renderer, no delay/PDC change.Coverage
Main.cppand serializer, preserve existing FX picker.Not yet acoustically qualified: 1 generated pitch-synchronous unison take still depends on source period/epoch quality and real singer evidence; no claim that it is indistinguishable from a manually doubled vocal. CPU/driver/XRUN and hardware ASIO remain independent FAT gates. User Presets are a separate shared native feature tracked in #533; this branch does not implement native preset storage or pretend JS factory presets are user files.
Release policy
Keep Draft; only integrate after fast native/UI+DSP checks and optional exact-SHA Windows FAT. Do not merge to main while P0 singer crackle and real-mic qualification are unresolved.