Repository navigation
Harmonice M5: native true-unison Doubler integrated over Windows FAT-qualified M3/M4 - #554
Merged
masarray merged 9 commits intoNov 10, 2026
Conversation
…nyProcessor.h onto tested M3 candidate
… onto tested M3 candidate
…x-rack.css onto tested M3 candidate
…ative-harmony.js onto tested M3 candidate
…smoke.py onto tested M3 candidate
…cpp onto tested M3 candidate
…test.py onto tested M3 candidate
masarray
marked this pull request as ready for review
November 10, 2026 23:48
masarray
merged commit Nov 10, 2026
87fd184
into
integration/harmonice-lead-ensemble-20261111
10 of 11 checks passed
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Nov 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconciliation of #537, preserving latest FAT candidate
The old draft #537 diverged from latest #529 after P0 octave/PSOLA continuity M3 and the busy-HIGH 5-voice CPU regression M4. This PR ports only the nine reviewed Doubler source/test changes from #537 onto exact Windows FAT-qualified candidate
dc63d1f92a9b877fac5cea22b97c1e467e2f465f. Per-file changes were applied only after requiring unique exact old context matches; the new PCM test was inserted alongside (not over) M3 long-vibrato/octave tests.Delivered native behavior
voiceMode=1follows original sung pitch as one wet unison take, with distinct PCM from pitched 2-voice harmony (Duo =voiceMode=0, voices=2).HarmonyDsp+ processor, versioned v3 session migration v1/v2=>Harmony, v3=>Doubler; sample rate/PDC and Lead Pitch Tune defaults unchanged.Admission gates
Fast native/DSP/UI first; fix failures before integrating this stacked PR into #529. A single new Windows FAT after merged candidate only if materially useful; owner sung HIGH, long vibrato, ASIO latency/XRUN and listening are separate release gates. Do not merge main or claim sound quality certification from synthetic tests.