Skip to content

Harmonice M5: native true-unison Doubler integrated over Windows FAT-qualified M3/M4 - #554

Merged
masarray merged 9 commits into
integration/harmonice-lead-ensemble-20261111from
integration/harmonice-m3-unison-doubler-20261111
Nov 10, 2026
Merged

masarray merged 9 commits into
integration/harmonice-lead-ensemble-20261111from
integration/harmonice-m3-unison-doubler-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

Reconciliation of #537, preserving latest FAT candidate

The old draft #537 diverged from latest #529 after P0 octave/PSOLA continuity M3 and the busy-HIGH 5-voice CPU regression M4. This PR ports only the nine reviewed Doubler source/test changes from #537 onto exact Windows FAT-qualified candidate dc63d1f92a9b877fac5cea22b97c1e467e2f465f. Per-file changes were applied only after requiring unique exact old context matches; the new PCM test was inserted alongside (not over) M3 long-vibrato/octave tests.

Delivered native behavior

  • Independent voiceMode=1 follows original sung pitch as one wet unison take, with distinct PCM from pitched 2-voice harmony (Duo = voiceMode=0, voices=2).
  • Single authoritative native HarmonyDsp + processor, versioned v3 session migration v1/v2=>Harmony, v3=>Doubler; sample rate/PDC and Lead Pitch Tune defaults unchanged.
  • Compact HARMONY/DOUBLER control and Double Light/Wide presets in existing editor; native ACK/readback controls selected state, not optimistic fake UI. Source Music Guide safely reverts to Manual when Doubler selected.
  • DSP tests for actual wet unison, deterministic key-independent melody, Duo distinction at 48/96k; native bridge snapshot, state migration and Chromium GUI tests.
  • All existing M3 PSOLA retention and M4 busy-high profile remain intact.

Admission gates

Fast native/DSP/UI first; fix failures before integrating this stacked PR into #529. A single new Windows FAT after merged candidate only if materially useful; owner sung HIGH, long vibrato, ASIO latency/XRUN and listening are separate release gates. Do not merge main or claim sound quality certification from synthetic tests.

@masarray
masarray marked this pull request as ready for review November 10, 2026 23:48
@masarray
masarray merged commit 87fd184 into integration/harmonice-lead-ensemble-20261111 Nov 10, 2026
10 of 11 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant