Repository navigation
M2b: serialize JUCE modal Audio Setup, Apply and ASIO recovery - #538
Merged
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
/arsonmix-ci native 2d426a9 |
1 of 8 tasks
Deploying arsonmix with
|
| Latest commit: |
2d426a9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c3f51f0.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-m2c-physical-device.arsonmix.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M2b — device lifecycle non-destructive transaction safety
Continuation of merged M2a #534, tracks #527. Base:
main@4eb541af90a8d9c1876fb49a014b7d7b34ebf62f. Implementation exact SHA2d426a91f17cb51ce9ef7609ba733e48c9d6f496.Concrete behavior fixed
showDeviceSetup()suspended output even if the JUCE selector was already visible; a repeated open could mute the session without a corresponding close/rebind. It also did not reserve the shared device transaction for the dialog's full visible lifetime.NativeDeviceApplyCoordinatornow owns one tagged control-thread lease (explicit Apply, modal Setup, or ASIO restart). The visible JUCE selector holds a persistent lease. Nested physical Apply and automatic ASIO restart cannot open/reconfigure the same DeviceManager while a selector is active.finishAudioSetupAndRecoverMixer(), native readback, and output-gating decisions. On ConsoleWindow destruction, the lease is released before the selector is destroyed, avoiding shutdown rebind callbacks.Tests
NativeDeviceApplyPinValidationAndRollbackEvidenceexpanded to prove whole-modal lifetime, nested Apply/ASIO refusal, closing/rebind lease ownership, and safe release.Qualification plan
/arsonmix-ci native <exact HEAD>MSVC/full CTest upon successful fast checks.Concurrency: draft #512 still changes
Main.cpp; do not blindly merge that old branch. Draft Harmonice #529/#521 and Hotkey #536 remain distinct and unmodified.Verification checkpoint (2d426a9)