Repository navigation
M2c: verify installed ASIO device and preserve accepted mixer during rebind - #540
Merged
Merged
Conversation
Deploying arsonmix with
|
| Latest commit: |
cf2ecdb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://91a24190.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-m2c-physical-device.arsonmix.pages.dev |
masarray
force-pushed
the
refactor/m2c-physical-device-readback-20261111
branch
from
November 10, 2026 21:33
3956503 to
b449a17
Compare
masarray
changed the base branch from
refactor/m2b-serialized-native-setup-20261111
to
main
November 10, 2026 21:33
masarray
marked this pull request as ready for review
November 10, 2026 21:34
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
/arsonmix-ci native b449a17 |
1 similar comment
Owner
Author
|
/arsonmix-ci native b449a17 |
Owner
Author
|
/arsonmix-ci native cf2ecdb |
1 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M2c — installed ASIO identity + non-destructive rebind policy
Based on current main:
29fef13e285c7be11f6541ffb0679747dc670ec2(M2b #538 merged with 81/81 Windows CTest). Exact M2c candidate:b449a17c36a8a901560f82dd95c5e36b27e3da95. This is a one-commit, five-file diff from current main, NOT a duplicate of M2b. Tracks physical issue #412 and maintainability plan #527 (closed by repo owner; this PR does not change issue state).Real code changes
src/NativeDeviceApplyCoordinator.h:inspectAppliedandinspectRollbacknow collect the actual open JUCE AudioIODevice name/type, active input/output port masks, rate and callback buffer together with current DeviceManager setup. The configuration remembered by DeviceManager is not accepted as proof of the actual ASIO callback.decideMixerRebindcontrol-plane policy expresses when to keep already-installed ChannelId PCM, restore the accepted retained/.smix session, accept the initial verified bound mixer, or reject an unauthorized device.Main.cpp::finishAudioSetupAndRecoverMixeruses this owner while keeping the original real engine and restore calls, including verified same-driver ASIO binding mode.Main.cppno longer assembles readback structs in two different ways. No new audio callback, DeviceManager, JS PCM, native graph or session store, no changed FX/VST3 DSP or UI layout.Final candidate qualification
cf2ecdbc9313d3cceb1df9fc62821b2368020593(adds strict live-rate/buffer sanity, including 0-rate and 0-buffer negative CTest cases).nativeWindows MSVC/CTest request has been posted for this candidate after fast PASS. Inspect resulting workflow success and CTest count before merge.CI and risk
a8f7b9d462da931b4337c0fa9c3c864dd4ea16edis unchanged across reparenting to latest main.nativequalification requested via owner-authenticated PR comment; inspect full Windows MSVC/CTest before any merge.