Skip to content

M2c: verify installed ASIO device and preserve accepted mixer during rebind - #540

Merged
masarray merged 2 commits into
mainfrom
refactor/m2c-physical-device-readback-20261111
Nov 10, 2026
Merged

masarray merged 2 commits into
mainfrom
refactor/m2c-physical-device-readback-20261111

Conversation

@masarray

@masarray masarray commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

M2c — installed ASIO identity + non-destructive rebind policy

Based on current main: 29fef13e285c7be11f6541ffb0679747dc670ec2 (M2b #538 merged with 81/81 Windows CTest). Exact M2c candidate: b449a17c36a8a901560f82dd95c5e36b27e3da95. This is a one-commit, five-file diff from current main, NOT a duplicate of M2b. Tracks physical issue #412 and maintainability plan #527 (closed by repo owner; this PR does not change issue state).

Real code changes

  • src/NativeDeviceApplyCoordinator.h: inspectApplied and inspectRollback now collect the actual open JUCE AudioIODevice name/type, active input/output port masks, rate and callback buffer together with current DeviceManager setup. The configuration remembered by DeviceManager is not accepted as proof of the actual ASIO callback.
  • For ASIO, mismatch of opened device class/name fails closed on both APPLY and ROLLBACK. Rollback also checks actual active masks, rate, buffer and unchanged ASIO port-name inventory (not just a cached setup).
  • A pure, exhaustive decideMixerRebind control-plane policy expresses when to keep already-installed ChannelId PCM, restore the accepted retained/.smix session, accept the initial verified bound mixer, or reject an unauthorized device. Main.cpp::finishAudioSetupAndRecoverMixer uses this owner while keeping the original real engine and restore calls, including verified same-driver ASIO binding mode.
  • Main.cpp no longer assembles readback structs in two different ways. No new audio callback, DeviceManager, JS PCM, native graph or session store, no changed FX/VST3 DSP or UI layout.
  • C++ tests cover forged ASIO name/type, stale physical channel masks, changed audio period, changed pin inventory, and the physical-authorization/rebind decision matrix. Native UI source contracts assert the equivalent hardware evidence at its new owning seam; assertions were not simply deleted.

Final candidate qualification

  • Exact candidate SHA: cf2ecdbc9313d3cceb1df9fc62821b2368020593 (adds strict live-rate/buffer sanity, including 0-rate and 0-buffer negative CTest cases).
  • Fast native contracts: PASS, run #42906822527. The original fast source tree before format hardening also passed.
  • Earlier dispatcher command at different SHA was rejected because fast CI was pending; its duplicate retry was skipped. That did not run Windows.
  • One correct exact-SHA native Windows MSVC/CTest request has been posted for this candidate after fast PASS. Inspect resulting workflow success and CTest count before merge.
  • Real device/ASIO physical FAT remains PENDING. Code/CI cannot certify driver hotplug or glitch-free live monitoring.

CI and risk

  • First candidate code tree PASS fast native check: run #42906015262. Tree SHA a8f7b9d462da931b4337c0fa9c3c864dd4ea16ed is unchanged across reparenting to latest main.
  • Current exact-SHA fast native run #42906299554 started. One exact-SHA manual native qualification requested via owner-authenticated PR comment; inspect full Windows MSVC/CTest before any merge.
  • Physical ASIO FAT still PENDING (real ASIO4ALL, MAONO, restart/rebind, pin swap, 0-IN monitoring). Running CTest is NOT a hardware certification.
  • Do not merge if full native checks fail or a new main/PR conflict appears. No FAT ZIP or redundant native+FAT run requested.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: cf2ecdb
Status: ✅  Deploy successful!
Preview URL: https://91a24190.arsonmix.pages.dev
Branch Preview URL: https://refactor-m2c-physical-device.arsonmix.pages.dev

View logs

@masarray
masarray force-pushed the refactor/m2c-physical-device-readback-20261111 branch from 3956503 to b449a17 Compare November 10, 2026 21:33
@masarray masarray changed the title M2c: verify actual JUCE ASIO device instance, ports and quantum before Apply/rollback M2c: verify installed ASIO device and preserve accepted mixer during rebind Nov 10, 2026
@masarray
masarray changed the base branch from refactor/m2b-serialized-native-setup-20261111 to main November 10, 2026 21:33
@masarray
masarray marked this pull request as ready for review November 10, 2026 21:34
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T21:34:07.665383Z
We couldn’t complete this review. Comment @codex review to try again.
b449a17 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native b449a17

1 similar comment

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native b449a17

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native cf2ecdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant