Repository navigation
M3a: prove actual native ChannelId vs M4 PCM callback owner before compatibility retirement - #542
Merged
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
/arsonmix-ci native dccd277 |
Deploying arsonmix with
|
| Latest commit: |
c159109
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5b5554d4.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-m3a-render-path-evi.arsonmix.pages.dev |
Owner
Author
|
/arsonmix-ci native c159109 |
1 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engineering milestone M3a — actual PCM render evidence, not another engine
Base:
main@c48bdce0d680c020cf6236cf1882331a29c13305after verified M2c PR #540.Commit:
dccd277406ea3ae81194682e922d83e4224bb863.Real implementation
engine/core/ProductionRenderAudit.h: allocation-free, lock-free relaxed-atomic evidence tracker for actual audio callback attempts/completions/failures on native ChannelId and legacy M4 fallback, overlapping-callback refusals, unpatched silent blocks and output-muted blocks without DSP.LiveDryRoutingLab::process()now records the selected render path exactly once per full JUCE callback, not per DSP chunk/strip. An aborted native render does NOT count as a successful native PCM pass; no DSP algorithms, VST3 leases, graph authority, output gate or hardware selection change.dryRoutingLab.status()publishes read-onlyrenderAuditcounters. No polling, new UI or second PCM device/callback.M3ActualProductionRenderPathAndFailSilentCountersproves separation of path attempts/completions/faults and denied/muted/unpatched evidence. Existing ChannelId WIRE/SOURCE ONLY golden-PCM and RT regressions remain mandatory.docs/architecture/M3_RENDER_PATH_EVIDENCE_20261111.mdtraces the actual callback and DSP owner call graph, readback field meaning and strict gates before removing any M4 path. Architecture map updated.Important safety
Qualify selectively
nativerun upon pass. No FAT ZIP or UI screenshot lane required.Updated exact-SHA qualification checkpoint
dccd2774: fast native + Harmony DSP passed; Windows run #42912197111 stopped in the early Node contract stage: 323/324 passed, one source-text MUTE regex expected an inline guard. DSP and the fail-silent behavior did not change.c1591090bc71aa5cb18e04e262e0d83e8a603b8e: updated the contract to requireif(!meterOnly)followed by the bounded audit,silence();return true;in order; this preserves and strengthens the mandatory safety check./arsonmix-ci nativewas requested after fast PASS. Windows MSVC/CTest not yet confirmed at this checkpoint. No duplicate FAT or UI lane.