Skip to content

M3a: prove actual native ChannelId vs M4 PCM callback owner before compatibility retirement - #542

Merged
masarray merged 2 commits into
mainfrom
refactor/m3a-render-path-evidence-20261111
Nov 10, 2026
Merged

masarray merged 2 commits into
mainfrom
refactor/m3a-render-path-evidence-20261111

Conversation

@masarray

@masarray masarray commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Engineering milestone M3a — actual PCM render evidence, not another engine

Base: main@c48bdce0d680c020cf6236cf1882331a29c13305 after verified M2c PR #540.
Commit: dccd277406ea3ae81194682e922d83e4224bb863.

Real implementation

  • engine/core/ProductionRenderAudit.h: allocation-free, lock-free relaxed-atomic evidence tracker for actual audio callback attempts/completions/failures on native ChannelId and legacy M4 fallback, overlapping-callback refusals, unpatched silent blocks and output-muted blocks without DSP.
  • LiveDryRoutingLab::process() now records the selected render path exactly once per full JUCE callback, not per DSP chunk/strip. An aborted native render does NOT count as a successful native PCM pass; no DSP algorithms, VST3 leases, graph authority, output gate or hardware selection change.
  • Existing CONTROL-thread dryRoutingLab.status() publishes read-only renderAudit counters. No polling, new UI or second PCM device/callback.
  • Dedicated portable C++ CTest M3ActualProductionRenderPathAndFailSilentCounters proves separation of path attempts/completions/faults and denied/muted/unpatched evidence. Existing ChannelId WIRE/SOURCE ONLY golden-PCM and RT regressions remain mandatory.
  • docs/architecture/M3_RENDER_PATH_EVIDENCE_20261111.md traces the actual callback and DSP owner call graph, readback field meaning and strict gates before removing any M4 path. Architecture map updated.

Important safety

  • Source still includes two alternate internal render paths inside ONE JUCE callback. M4 is not proven dead; it stays intact. No fake GUI status, no ambient auto-ARM, no blanket compatibility removal.
  • Observational counters cannot certify hardware audibility, ASIO pin identity or crackle-free live monitoring. Physical ASIO FAT remains PENDING.
  • Current open P0 draft P0 reconcile: preserve native mixer, recover verified ASIO and clickless Harmony without hiding GUI #512 and Harmonice/Hotkey/FX user-preset PRs remain independent; this PR does not cherry-pick their work.

Qualify selectively

  • New code not yet compiled at PR creation. Fast native checks first, then one exact-SHA Windows MSVC/full CTest native run upon pass. No FAT ZIP or UI screenshot lane required.
  • Do not merge on a red regression, stale main, or unreviewed DSP behavior. Follow docs/SMART_CI_RUNNER_WORKFLOW.md.

Updated exact-SHA qualification checkpoint

  • First head dccd2774: fast native + Harmony DSP passed; Windows run #42912197111 stopped in the early Node contract stage: 323/324 passed, one source-text MUTE regex expected an inline guard. DSP and the fail-silent behavior did not change.
  • Revised exact HEAD c1591090bc71aa5cb18e04e262e0d83e8a603b8e: updated the contract to require if(!meterOnly) followed by the bounded audit, silence();return true; in order; this preserves and strengthens the mandatory safety check.
  • Fast native #42912618990: PASS. Harmony DSP #42912618957: PASS.
  • One new exact-SHA Windows native /arsonmix-ci native was requested after fast PASS. Windows MSVC/CTest not yet confirmed at this checkpoint. No duplicate FAT or UI lane.
  • Hardware ASIO FAT PENDING; M4 compatibility not removed.

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T22:10:05.489252Z
We couldn’t complete this review. Comment @codex review to try again.
dccd277 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native dccd277

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: c159109
Status: ✅  Deploy successful!
Preview URL: https://5b5554d4.arsonmix.pages.dev
Branch Preview URL: https://refactor-m3a-render-path-evi.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native c159109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant