Repository navigation
P0: fix Waves WaveShell wrong VST3 class and repeated startup FX crashes - #545
Merged
masarray merged 1 commit intoNov 10, 2026
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
masarray
force-pushed
the
fix/p0-waveshell-class-and-startup-recovery-20261111
branch
from
November 10, 2026 22:51
53f0b9b to
e07c8e7
Compare
Deploying arsonmix with
|
| Latest commit: |
e610bbd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d5489c8a.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-p0-waveshell-class-and-s.arsonmix.pages.dev |
Owner
Author
|
/arsonmix-ci fat e07c8e7 |
This was referenced Nov 10, 2026
masarray
force-pushed
the
fix/p0-waveshell-class-and-startup-recovery-20261111
branch
from
November 10, 2026 23:24
e07c8e7 to
3a3c5e8
Compare
Owner
Author
|
/arsonmix-ci native 3a3c5e8 |
masarray
force-pushed
the
fix/p0-waveshell-class-and-startup-recovery-20261111
branch
from
November 10, 2026 23:32
3a3c5e8 to
e610bbd
Compare
masarray
added a commit
that referenced
this pull request
Nov 10, 2026
#545) Preserve latest native host + CMake Waves safety, and all H2 verified parameter mappings. Do not touch External OUT or additional callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-reported P0: Waves plugin shows a different actual processor; some machines crash on every open
Current base:
main@dae1440f6edd5ec5f0b2d91d9ec4476a5c6bff82(M3a #542 merged, Windows 82/82 CTest). Candidate53f0b9b7d9a2e9d9b02d11f6afc03f29564aaaaf. Neither issue is claimed as hardware-field verified.Confirmed upstream host root cause
ArSonMix pins JUCE 8.0.15 and uses
juce_audio_processors_headless/format_types/juce_VST3PluginFormatImpl.h, whoseVST3ModuleHandle::create()looks up a class index beforeIPluginFactory3::setHostContext(). Waves WaveShell can append controller classes and shift factory indices when context is set, loading a different plugin from the named class. JUCE upstream fixed this on 2026-09-03. Our pinned tag predates it.scripts/patch_juce_vst3_waveshell.pyapplies the exact upstream ordering correction to checked-out pinned JUCE BEFOREadd_subdirectory(), idempotently and with fail-closed pattern checks; no uncontrolled JUCE 9 upgrade or parallel VST3 host.DescriptionCacheresolves by UID and exact named class, refusing ambiguous UID collisions or stale display identities rather than returning the first WaveShell class. Direct ADD, native ChannelId ADD, legacy restore, and saved.smixVST3 restore pass the verified catalog name. No saved catalog ID or schema migration.Startup crash mitigation
Vst3RestoreCrashGuardwrites a tiny marker before automatic saved-VST3 restore. If vendor code terminates the process, the marker remains, and next cold launch does not automatically instantiate the same crashing VST3 again..smixJSON, FX binary state, favorite catalog and valid GUI. Users can explicitly Open their session after investigation. A successful 15s post-restore stability window/graceful shutdown clears the marker. Failure to create the marker prevents an unsafe automatic restore.Testing & review
/preview/, audio callback, routings, DSP, or third-party license handling; unrelated Harmonice/Hotkey draft heads untouched.Exact qualified candidate / parallel-main reconciliation
Hotkey-main reconciled qualification
main@7da5451e4e395d2fb7a1d4c215b4ba41e6fba1af, preserving merged Hotkey/FX and CI changes instead of replacingMain.cppor the workflow with the older branch snapshot.3a3c5e8f41cd71a474f65d78e2cc06ae9e427d7e, one commit / 12-file PR, mergeable against that main. Fast native, Harmonice DSP and Chromium on this SHA PASS.e07c8e79passed Windows 84/84 CTest, FAT ZIP + installer #42918578102. Those artifacts predate this combined source and are not evidence that the integrated Hotkey+Waves build passes.Reconciled source-equivalent candidate after focused-FAT CI merge
e610bbd143d818f92b200ededccb361eb81bfeafis now a one-commit PR onmain@c65c695d7f70fa2a43c6e668d6b9a689462fd322, preserving merged Hotkey and the newer selective Harmonice FAT preflight. Mergeable at audit.3a3c5e8f41cd71a474f65d78e2cc06ae9e427d7ehas one Windows native MSVC/full CTest run #42923360681 in progress..github/workflows/p1-windows.ymlandtests/ci_workflow_efficiency_test.mjsdiffer. Thus no PCM/VST3 implementation was changed during CI reconciliation.mainhas no new conflicting runtime edit.