Skip to content

P0: fix Waves WaveShell wrong VST3 class and repeated startup FX crashes - #545

Merged
masarray merged 1 commit into
mainfrom
fix/p0-waveshell-class-and-startup-recovery-20261111
Nov 10, 2026
Merged

masarray merged 1 commit into
mainfrom
fix/p0-waveshell-class-and-startup-recovery-20261111

Conversation

@masarray

@masarray masarray commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

User-reported P0: Waves plugin shows a different actual processor; some machines crash on every open

Current base: main@dae1440f6edd5ec5f0b2d91d9ec4476a5c6bff82 (M3a #542 merged, Windows 82/82 CTest). Candidate 53f0b9b7d9a2e9d9b02d11f6afc03f29564aaaaf. Neither issue is claimed as hardware-field verified.

Confirmed upstream host root cause

ArSonMix pins JUCE 8.0.15 and uses juce_audio_processors_headless/format_types/juce_VST3PluginFormatImpl.h, whose VST3ModuleHandle::create() looks up a class index before IPluginFactory3::setHostContext(). Waves WaveShell can append controller classes and shift factory indices when context is set, loading a different plugin from the named class. JUCE upstream fixed this on 2026-09-03. Our pinned tag predates it.

  • Deterministic scripts/patch_juce_vst3_waveshell.py applies the exact upstream ordering correction to checked-out pinned JUCE BEFORE add_subdirectory(), idempotently and with fail-closed pattern checks; no uncontrolled JUCE 9 upgrade or parallel VST3 host.
  • New Python regression fixture verifies host context precedes class lookup, idempotence, partial/unknown-source refusal; fast native CI runs this fixture.
  • DescriptionCache resolves by UID and exact named class, refusing ambiguous UID collisions or stale display identities rather than returning the first WaveShell class. Direct ADD, native ChannelId ADD, legacy restore, and saved .smix VST3 restore pass the verified catalog name. No saved catalog ID or schema migration.

Startup crash mitigation

  • Vst3RestoreCrashGuard writes a tiny marker before automatic saved-VST3 restore. If vendor code terminates the process, the marker remains, and next cold launch does not automatically instantiate the same crashing VST3 again.
  • Preserves the user's .smix JSON, FX binary state, favorite catalog and valid GUI. Users can explicitly Open their session after investigation. A successful 15s post-restore stability window/graceful shutdown clears the marker. Failure to create the marker prevents an unsafe automatic restore.
  • C++ regression: ambiguous Waves UID/name selection, crash marker survival and safe subsequent launch, session file unchanged.
  • This does NOT claim to fix unrelated pre-WebView, corrupted driver or third-party scan crashes. Gather WER dump and vendor/version evidence separately.

Testing & review

  • Not yet qualified when PR opened: fast native + Python fixture, then one exact-SHA Windows MSVC/full CTest milestone; verify build and the new CTests before merge.
  • Field FAT PENDING: licensed WaveShell v17 Saphira vs GW MixCentric, actual GUI/processor identity, ASIO audio, saved session reopen, repeated cold launch/recovery.
  • No change to approved /preview/, audio callback, routings, DSP, or third-party license handling; unrelated Harmonice/Hotkey draft heads untouched.

Exact qualified candidate / parallel-main reconciliation

Hotkey-main reconciled qualification

Reconciled source-equivalent candidate after focused-FAT CI merge

  • HEAD e610bbd143d818f92b200ededccb361eb81bfeaf is now a one-commit PR on main@c65c695d7f70fa2a43c6e668d6b9a689462fd322, preserving merged Hotkey and the newer selective Harmonice FAT preflight. Mergeable at audit.
  • Exact prior combined candidate 3a3c5e8f41cd71a474f65d78e2cc06ae9e427d7e has one Windows native MSVC/full CTest run #42923360681 in progress.
  • Git tree object comparison across both candidates (950 entries each, not truncated) proves all production C++ source, CMakeLists, WaveShell patch and C++ tests have identical blob SHAs; only .github/workflows/p1-windows.yml and tests/ci_workflow_efficiency_test.mjs differ. Thus no PCM/VST3 implementation was changed during CI reconciliation.
  • Current HEAD fast native, Harmony DSP and Chromium tests all PASS. Do not dispatch another expensive Windows/FAT run for identical native code. Check Windows outcome on the source-equivalent candidate and merge only if it passes, new CI checks remain green and main has no new conflicting runtime edit.
  • Stacked recovery #549 requires separate reconciliation against the merged main, preserving native Hotkey session imports and protecting pre-graph logical FX preparation.

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T22:49:45.460827Z
We couldn’t complete this review. Comment @codex review to try again.
53f0b9b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray force-pushed the fix/p0-waveshell-class-and-startup-recovery-20261111 branch from 53f0b9b to e07c8e7 Compare November 10, 2026 22:51
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: e610bbd
Status: ✅  Deploy successful!
Preview URL: https://d5489c8a.arsonmix.pages.dev
Branch Preview URL: https://fix-p0-waveshell-class-and-s.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat e07c8e7

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 3a3c5e8

@masarray
masarray force-pushed the fix/p0-waveshell-class-and-startup-recovery-20261111 branch from 3a3c5e8 to e610bbd Compare November 10, 2026 23:32
@masarray
masarray merged commit 7108959 into main Nov 10, 2026
9 checks passed
masarray added a commit that referenced this pull request Nov 10, 2026
#545)

Preserve latest native host + CMake Waves safety, and all H2 verified parameter mappings. Do not touch External OUT or additional callback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant