Skip to content

P0b: restore normal startup after verified manual VST3 crash recovery - #549

Merged
masarray merged 1 commit into
mainfrom
fix/p0-explicit-vst3-recovery-rearm-20261111
Nov 11, 2026
Merged

masarray merged 1 commit into
mainfrom
fix/p0-explicit-vst3-recovery-rearm-20261111

Conversation

@masarray

@masarray masarray commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Follow-on to #545 and issue #547. This stacked draft contains only the second-stage crash recovery handoff; it does not duplicate WaveShell/JUCE or modify DSP.

Bug found in current P0 candidate: after an abnormal VST3 automatic restore, the marker intentionally makes the next launch safe. However, after the user explicitly Opens and successfully restores a session with the repaired/updated vendor plugin, the marker would never clear; every subsequent launch stays in safe mode indefinitely.

Actual behavior fix:

  • Manual .smix Open's physical vendor-instantiation path now uses the same durable VST3 restore marker before potentially unsafe DLL creation.
  • On explicit retry after a prior crash, it keeps the marker active during plugin construction and for the same 15-second stability window after the newly installed graph. If that succeeds, the shared control timer clears it and subsequent cold starts can resume ordinary automatic restore.
  • If the explicit retry crashes, the marker remains; the following application startup is still safe. If the user operation returns an ordinary error without an earlier crash, clear only the newly armed marker. Do not delete old crash evidence or alter the saved .smix.
  • An earlier startup success timer cannot erroneously clear a newer explicit retry's pending crash marker; it is retired before opening the new vendor graph.
  • Offline/logical-only Open stays offline and does not instantiate vendor code or change crash recovery.
  • Extended C++ regression checks interrupted automatic restore, manual re-attempt, second simulated crash, successful recovery and preserved .smix.

Dependencies/gates: Do not merge this PR until parent #545 passes exact-SHA Windows MSVC/CTest, is merged to main, and this child is reconciled and qualified on its own SHA. No separate hardware/FAT CI request from this draft. Real Waves ASIO FAT remains PENDING.

P0b integration hardening and Hotkey-safe rebase

2026-11-11 parent integration status

  • Parent P0: fix Waves WaveShell wrong VST3 class and repeated startup FX crashes #545 merged into main@7108959471f3d37006d7b36869e32794e211f31a, Windows MSVC 85/85 CTest PASS on source-equivalent integrated candidate; physical licensed Waves FAT remains independent.
  • This PR is now based on main, and GitHub reported the four-file child diff mergeable/clean; explicit manual Open still arms vendor crash guard before pre-graph FX materialization while retaining Hotkey session import.
  • Exact child HEAD 1159f84a3fbc2b7101bf6b325151fda5adfb1588: fast native PASS; one native Windows exact-SHA qualification https://github.com/masarray/arsonmix/actions/runs/42927241520 is IN PROGRESS. Do not merge until it passes and main is rechecked. Do not dispatch duplicate FAT.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1159f84
Status: ✅  Deploy successful!
Preview URL: https://4a9d4583.arsonmix.pages.dev
Branch Preview URL: https://fix-p0-explicit-vst3-recover.arsonmix.pages.dev

View logs

@masarray
masarray force-pushed the fix/p0-waveshell-class-and-startup-recovery-20261111 branch from e07c8e7 to 3a3c5e8 Compare November 10, 2026 23:24
@masarray
masarray force-pushed the fix/p0-waveshell-class-and-startup-recovery-20261111 branch from 3a3c5e8 to e610bbd Compare November 10, 2026 23:32
@masarray
masarray force-pushed the fix/p0-explicit-vst3-recovery-rearm-20261111 branch from 9c636a4 to 1159f84 Compare November 10, 2026 23:38
@masarray
masarray changed the base branch from fix/p0-waveshell-class-and-startup-recovery-20261111 to main November 10, 2026 23:54

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 1159f84

@masarray
masarray marked this pull request as ready for review November 11, 2026 00:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T00:30:22.104147Z 1159f84 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 6406292 into main Nov 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant