Repository navigation
P0b: restore normal startup after verified manual VST3 crash recovery - #549
Merged
Merged
Conversation
Deploying arsonmix with
|
| Latest commit: |
1159f84
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4a9d4583.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-p0-explicit-vst3-recover.arsonmix.pages.dev |
masarray
force-pushed
the
fix/p0-waveshell-class-and-startup-recovery-20261111
branch
from
November 10, 2026 23:24
e07c8e7 to
3a3c5e8
Compare
masarray
force-pushed
the
fix/p0-waveshell-class-and-startup-recovery-20261111
branch
from
November 10, 2026 23:32
3a3c5e8 to
e610bbd
Compare
masarray
force-pushed
the
fix/p0-explicit-vst3-recovery-rearm-20261111
branch
from
November 10, 2026 23:38
9c636a4 to
1159f84
Compare
masarray
changed the base branch from
fix/p0-waveshell-class-and-startup-recovery-20261111
to
main
November 10, 2026 23:54
Owner
Author
|
/arsonmix-ci native 1159f84 |
masarray
marked this pull request as ready for review
November 11, 2026 00:29
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #545 and issue #547. This stacked draft contains only the second-stage crash recovery handoff; it does not duplicate WaveShell/JUCE or modify DSP.
Bug found in current P0 candidate: after an abnormal VST3 automatic restore, the marker intentionally makes the next launch safe. However, after the user explicitly Opens and successfully restores a session with the repaired/updated vendor plugin, the marker would never clear; every subsequent launch stays in safe mode indefinitely.
Actual behavior fix:
.smixOpen's physical vendor-instantiation path now uses the same durable VST3 restore marker before potentially unsafe DLL creation..smix..smix.Dependencies/gates: Do not merge this PR until parent #545 passes exact-SHA Windows MSVC/CTest, is merged to main, and this child is reconciled and qualified on its own SHA. No separate hardware/FAT CI request from this draft. Real Waves ASIO FAT remains PENDING.
P0b integration hardening and Hotkey-safe rebase
1159f84a3fbc2b7101bf6b325151fda5adfb1588, one commit on current parent P0: fix Waves WaveShell wrong VST3 class and repeated startup FX crashes #545e610bbd1, four-file diff only. Parent remains unaffected.src/Main.cpp::openMixerFilenow arms the persistent VST3 crash marker BEFOREmaterializeLogicalFxForBinding, which can itself prepare vendor FX, not just before final native session restore. This closes a genuine pre-instantiation fault window.activateSession(id,&importedHotkeys)is retained on successful Open. Newtests/live_routing_ui_contract_test.mjsverifies both the ordering and this Hotkey handoff, while C++ tests verify repeated crash marker and explicit retry recovery.2026-11-11 parent integration status
main@7108959471f3d37006d7b36869e32794e211f31a, Windows MSVC 85/85 CTest PASS on source-equivalent integrated candidate; physical licensed Waves FAT remains independent.1159f84a3fbc2b7101bf6b325151fda5adfb1588: fast native PASS; one native Windows exact-SHA qualification https://github.com/masarray/arsonmix/actions/runs/42927241520 is IN PROGRESS. Do not merge until it passes and main is rechecked. Do not dispatch duplicate FAT.