Repository navigation
M4: verified native FX registry extension with real processor PCM and state gates - #553
Merged
Merged
Conversation
Owner
Author
|
/arsonmix-ci native 773edab |
1 of 8 tasks
Deploying arsonmix with
|
| Latest commit: |
1312145
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b2c52204.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-m4-native-fx-extens.arsonmix.pages.dev |
Owner
Author
|
/arsonmix-ci native 1312145 |
masarray
marked this pull request as ready for review
November 11, 2026 00:51
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M4 — Native FX host extension seam, code + real CTest
Based on
main@c65c695d7f70fa2a43c6e668d6b9a689462fd322(not on Harmonice/Waves/Hotkey drafts). Proves a native FX can register through the same descriptor lookup and prepare/restore function as production EQ, Compressor, Harmonice and Throw, without adding another branch in Main/WebView/PCM.Changes
src/NativeBuiltInFx.h: compile-time registration contract fails build on duplicate/invalid IDs, missing prepare callback, or invalid supported rates; one injection-capable exact-ID lookup shared by actual production lookup and tests. Reject inconsistent state pointer/byte count before instantiation, rather than silently defaulting a corrupted stored FX.tests/native_fx_registry_extension_test.cpp: real JUCE AudioProcessor fixture registered through that same extension path, prepared and restored with valid float state, then processes deterministic stereo PCM. Proves exact class ID, latency = 0, bad/NaN/empty state refusal, duplicate catalog compile-time refusal and existing production IDs.CMakeLists.txt: addM4NativeFxCatalogExtensionAndStatePreparationto existing native mixer build; no additional workflow lane or user-facing/plugin product code.Boundaries: No audio callback/graph/ASIO/device/GUI changes; no plugin DSP changes; external Waves fix #545 and draft #549 left untouched. This is M4 host extension fixture and malformed-state gate, not a claim that every M4 host lifecycle/parameter/editor migration or hardware FAT is complete.
Qualification: Run fast PR checks, then exactly one exact-SHA Windows native MSVC/full CTest milestone (not FAT and not UI). No hardware audio claim.
Deferred: broader M4 host parameter/ACK lease convergence; M3 PCM legacy retirement requires real native render-path evidence; M5 bridge reduction and M6 guardrails; WaveShell P0 PRs independent.
2026-11-11 branch reconciliation — no other product changes overwritten
773edab3f21698d7ae9ef30335218673b32dba86, which passed 84/84 CTest, including M4 extension fixture.13121450eef46488ce51d1cfabfeb5b137c39b67mergesmain@0d4bb2c2ec539d8156d2e43c5ef6f02e23df2d12(contains merged Waves P0b, Hotkey H2, FX presets and M5) and preserves earlier M4 commits as a second parent. Merge was fast-forward on the PR branch with expected old head.CMakeLists.txt(+11 M4 test lines),src/NativeBuiltInFx.h,tests/native_fx_registry_extension_test.cpp; no other file differences, no GUI/ASIO/PCM graph changes.