Skip to content

M4: verified native FX registry extension with real processor PCM and state gates - #553

Merged
masarray merged 6 commits into
mainfrom
refactor/m4-native-fx-extension-fixture-20261111
Nov 11, 2026
Merged

masarray merged 6 commits into
mainfrom
refactor/m4-native-fx-extension-fixture-20261111

Conversation

@masarray

@masarray masarray commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

M4 — Native FX host extension seam, code + real CTest

Based on main@c65c695d7f70fa2a43c6e668d6b9a689462fd322 (not on Harmonice/Waves/Hotkey drafts). Proves a native FX can register through the same descriptor lookup and prepare/restore function as production EQ, Compressor, Harmonice and Throw, without adding another branch in Main/WebView/PCM.

Changes

  • src/NativeBuiltInFx.h: compile-time registration contract fails build on duplicate/invalid IDs, missing prepare callback, or invalid supported rates; one injection-capable exact-ID lookup shared by actual production lookup and tests. Reject inconsistent state pointer/byte count before instantiation, rather than silently defaulting a corrupted stored FX.
  • tests/native_fx_registry_extension_test.cpp: real JUCE AudioProcessor fixture registered through that same extension path, prepared and restored with valid float state, then processes deterministic stereo PCM. Proves exact class ID, latency = 0, bad/NaN/empty state refusal, duplicate catalog compile-time refusal and existing production IDs.
  • CMakeLists.txt: add M4NativeFxCatalogExtensionAndStatePreparation to existing native mixer build; no additional workflow lane or user-facing/plugin product code.

Boundaries: No audio callback/graph/ASIO/device/GUI changes; no plugin DSP changes; external Waves fix #545 and draft #549 left untouched. This is M4 host extension fixture and malformed-state gate, not a claim that every M4 host lifecycle/parameter/editor migration or hardware FAT is complete.

Qualification: Run fast PR checks, then exactly one exact-SHA Windows native MSVC/full CTest milestone (not FAT and not UI). No hardware audio claim.

Deferred: broader M4 host parameter/ACK lease convergence; M3 PCM legacy retirement requires real native render-path evidence; M5 bridge reduction and M6 guardrails; WaveShell P0 PRs independent.

2026-11-11 branch reconciliation — no other product changes overwritten

  • M4 registry and real JUCE test file are exact byte-identical (same blob IDs) to Windows-qualified old head 773edab3f21698d7ae9ef30335218673b32dba86, which passed 84/84 CTest, including M4 extension fixture.
  • Current merge-head 13121450eef46488ce51d1cfabfeb5b137c39b67 merges main@0d4bb2c2ec539d8156d2e43c5ef6f02e23df2d12 (contains merged Waves P0b, Hotkey H2, FX presets and M5) and preserves earlier M4 commits as a second parent. Merge was fast-forward on the PR branch with expected old head.
  • Explicit comparison against this main = only three intended files: CMakeLists.txt (+11 M4 test lines), src/NativeBuiltInFx.h, tests/native_fx_registry_extension_test.cpp; no other file differences, no GUI/ASIO/PCM graph changes.
  • New SHA needs fast Linux validation, then one exact-SHA native MSVC/full CTest only if needed. Previous CI is supporting byte-equivalent M4 evidence, not new SHA's own PASS.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 773edab

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1312145
Status: ✅  Deploy successful!
Preview URL: https://b2c52204.arsonmix.pages.dev
Branch Preview URL: https://refactor-m4-native-fx-extens.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 1312145

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T00:52:59.954342Z 1312145 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 2de71f8 into main Nov 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant