Repository navigation
M5: reject malformed native FX lease snapshots without corrupting accepted GUI state - #561
Merged
masarray merged 4 commits intoNov 11, 2026
Merged
Conversation
Deploying arsonmix with
|
| Latest commit: |
b143e59
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a7117643.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-m5-native-fx-instance-sn.arsonmix.pages.dev |
Owner
Author
|
/arsonmix-ci ui b143e59 |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (reviewed against actual native projection)
normalizeSnapshotchecked that channelinsertswas an array, but did not validate each insert or global instance-token uniqueness. Native FX MOVE/REMOVE/readback/editor paths dereferenceinsert.idand assume one instance identity across all channels. A malformed native snapshot could become accepted and cause JS exceptions or duplicate lease attribution.Fix — two files, no DSP/ASIO/UI restyle
id, nonemptycatalogId, optional typedname/bypassed, max eight slots/channel, and unique token across channels before admitting installed PCM snapshot.readbackProvesIntentnow returnsfalsefor null/unadmitted snapshot or malformed pending input rather than dereferencing it.INVALID_NATIVE_SNAPSHOT, no fake native command, and an existing fader intent can still finish only after valid ACK plus later readback.Source authority: one approved /preview/ renderer, one native producer, same controller; no new subscriptions, processor construction, audio callback, or browser-simulated DSP.
Qualification: fast native+UI contracts, then exactly one UI full Chromium qualification at exact PR SHA; no Windows JUCE job necessary because only JS adapter & its test changed. Do not merge until green. M3b #560 and M4 #553 already merged into main; issue #527 stays open.