Skip to content

M4: reject duplicate FX instance tokens at the native lease-bank authority - #565

Merged
masarray merged 1 commit into
mainfrom
guard/m4-fx-token-ownership-20261111
Nov 11, 2026
Merged

masarray merged 1 commit into
mainfrom
guard/m4-fx-token-ownership-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

#527 — M4 common host ownership safety

Source defect

DynamicChannelFxLeaseBank::prepare rejects the same shared FxInstance pointer being used twice, but two distinct processors carrying the same restored instanceId still passed that check. MOVE, rack bypass, native vendor editor identity and durable .smix readback all key by that token. The producer (#562) and UI (#561) reject duplicates later; the PCM bank must enforce this at graph admission.

Implemented

  • engine/core/DynamicChannelFxLeaseBank.h: reject duplicate instance tokens both across ChannelIds and within a rack in the existing CONTROL-only owner inventory traversal. Keep pointer guard too. Empty tokens fail closed. No additional sets/allocations, no new callback, graph, JS subscription, DSP or VST3 algorithm changes.
  • tests/live_channel_fx_graph_test.cpp: construct two independent JUCE processors with the same restored token, prove cross-channel and same-channel rejection, and previous accepted bank unchanged. Existing positive real VST3/PCM fixture remains.

Qualification

One code milestone based on main@64b123fbbfc3ed6ed5d11faee37b5aed372ef697. Run fast native/contracts, then one exact-SHA native MSVC/full CTest after fast green; no duplicate FAT ZIP. Physical ASIO/VST3 vendor listening PENDING. Preserves unrelated Harmonice, hotkeys and O1/O2 branches. M4 still has future parameter/editor consolidation; this closes the unique lease-owner gate, not the whole epic.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native f0f8f7f

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: f0f8f7f
Status: ✅  Deploy successful!
Preview URL: https://10937ad8.arsonmix.pages.dev
Branch Preview URL: https://guard-m4-fx-token-ownership.arsonmix.pages.dev

View logs

@masarray
masarray marked this pull request as ready for review November 11, 2026 03:31
@masarray
masarray merged commit c63e6ab into main Nov 11, 2026
6 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T03:33:09.562116Z f0f8f7f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant