Repository navigation
M4: reject duplicate FX instance tokens at the native lease-bank authority - #565
Merged
Merged
Conversation
Owner
Author
|
/arsonmix-ci native f0f8f7f |
Deploying arsonmix with
|
| Latest commit: |
f0f8f7f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10937ad8.arsonmix.pages.dev |
| Branch Preview URL: | https://guard-m4-fx-token-ownership.arsonmix.pages.dev |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#527 — M4 common host ownership safety
Source defect
DynamicChannelFxLeaseBank::preparerejects the same shared FxInstance pointer being used twice, but two distinct processors carrying the same restoredinstanceIdstill passed that check. MOVE, rack bypass, native vendor editor identity and durable .smix readback all key by that token. The producer (#562) and UI (#561) reject duplicates later; the PCM bank must enforce this at graph admission.Implemented
engine/core/DynamicChannelFxLeaseBank.h: reject duplicate instance tokens both across ChannelIds and within a rack in the existing CONTROL-only owner inventory traversal. Keep pointer guard too. Empty tokens fail closed. No additional sets/allocations, no new callback, graph, JS subscription, DSP or VST3 algorithm changes.tests/live_channel_fx_graph_test.cpp: construct two independent JUCE processors with the same restored token, prove cross-channel and same-channel rejection, and previous accepted bank unchanged. Existing positive real VST3/PCM fixture remains.Qualification
One code milestone based on
main@64b123fbbfc3ed6ed5d11faee37b5aed372ef697. Run fast native/contracts, then one exact-SHAnativeMSVC/full CTest after fast green; no duplicate FAT ZIP. Physical ASIO/VST3 vendor listening PENDING. Preserves unrelated Harmonice, hotkeys and O1/O2 branches. M4 still has future parameter/editor consolidation; this closes the unique lease-owner gate, not the whole epic.