Repository navigation
M4: unify native FX host request identity and mailbox sequence across all built-in editors - #567
Merged
masarray merged 1 commit intoNov 11, 2026
Conversation
Owner
Author
|
/arsonmix-ci native 556eb2c |
Deploying arsonmix with
|
| Latest commit: |
556eb2c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dbf5405b.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-m4-native-fx-host-c.arsonmix.pages.dev |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#527 — M4 maintainability / one verified built-in FX control ingress
Problem: the four live built-in handlers (EQ, Compressor, Harmonice, Vocal Throw) each duplicated a 14-line ChannelId/device epoch/graph revision/insert token/slot/requestId validator and an additional independent ad-hoc mailbox sequence parser. A future effect would require copy-pasting these security and stale-state rules inside the 6,800-line
Main.cpp, risking mismatched VST3 editor identity or accidental JS numeric coercion.Implementation:
src/NativeFxControlRequest.hbecomes the one CONTROL-only parsed request identity, using the existing canonicalapprovedNativeIdrules.sequence(prefix)replaces all four exception-basedstd::stoullparsers with an exactly-prefixed, bounded, deterministic ASCII decimal parser.src/Main.cppreuses this one policy in four existing editor routes; plugin-specialized DSP parameter validation, queue, GUI editor, native/LOGICAL_ONLY processing, ACK events and realtime callback are unchanged.Regression:
tests/native_fx_registry_extension_test.cppnow exercises large ChannelIds, valid/stale/malformed identity fields, duplicate host request prefixes, offline workspace indication, bounded/nondecimal/leading-zero sequence and max 19-digit integer. Existing FX registration fixture and native host/PCM CTest remain.Safety: no new graph, device manager, audio callback, VST instance, GUI renderer, external interface or DSP processing logic. This is M4 common host plumbing, not an experimental Harmony algorithm change. Current main baseline
c63e6ab42dfc00d002f0aeea44b8b20a7dc6b9f3includes #565 exact token uniqueness. Keep separate concurrent Harmony #529, #521, routing #563 and recovery #512 untouched.Validation: fast native contracts first, then one exact-SHA Windows MSVC + 88/88 CTest lane; no Chromium because neither HTML nor bridge changes, no redundant FAT ZIP. Physical ASIO/VST3 listening remains PENDING.