Skip to content

M5: extract native operator presentation policies and guard failed-readback messaging - #568

Merged
masarray merged 5 commits into
mainfrom
refactor/m5-native-presentation-policy-20261111
Nov 11, 2026
Merged

masarray merged 5 commits into
mainfrom
refactor/m5-native-presentation-policy-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

#527 — M5 domain separation, user-facing status reliability

The native web/approved-native-bridge.js had more presentation-only policy than needed: exact channel name/color/icon rules and a lengthy native-to-operator message converter lived among live ACK handlers, DOM selectors, device apply, FX, and WIRE transactions. They were not independently tested.

Implementation

  • Move the existing channel identity validation and human-facing operatorMessage to the already-loaded pure web/approved-native-contract.js; the bridge delegates to these exported rules. The approved /preview/ page, one WebView DOM, one native subscription/graph and JUCE host stay unchanged; no new script/resource is bundled.
  • Fix an actual bug uncovered by pure tests: INVALID_NATIVE_SNAPSHOT and ACK_READBACK_EFFECT_MISMATCH previously fell through to success-looking "Mixer settings updated". The normalized native-status helper now classifies exact leading/embedded invalid/stale/mismatch codes as "Change not applied · Previous mixer settings kept". The raw diagnostic remains available internally.
  • Add deterministic Node assertions on accepted/invalid identity values, error, pending, WIRE, FX, device, FAT/QA, and operator-facing messages. Pure helpers do not mutate accepted state.

Scope: GUI adapter/presentation only; no change to Harmony/FX DSP, device I/O, WIRE PCM, hotkeys, routing, or graphics. M5 logical-only ACK proof #564 and current M4 lease-owner #565 remain intact. Source baseline main@c63e6ab42dfc00d002f0aeea44b8b20a7dc6b9f3. Concurrent #563 / #529 / #512 / #521 not touched.

Validation: fast UI Node contracts first, then exactly one exact-SHA ui Chromium qualification (approved renderer + WIRE/browser interaction). No Windows runner or FAT ZIP for JS-only changes. Physical ASIO FAT is still PENDING.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5684e5d
Status: ✅  Deploy successful!
Preview URL: https://a9675c23.arsonmix.pages.dev
Branch Preview URL: https://refactor-m5-native-presentat.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 5684e5d

@masarray
masarray marked this pull request as ready for review November 11, 2026 03:54
@masarray
masarray merged commit 01e4a97 into main Nov 11, 2026
15 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T03:56:37.330541Z 5684e5d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant