Repository navigation
M5: extract native operator presentation policies and guard failed-readback messaging - #568
Merged
Merged
Conversation
Deploying arsonmix with
|
| Latest commit: |
5684e5d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a9675c23.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-m5-native-presentat.arsonmix.pages.dev |
Owner
Author
|
/arsonmix-ci ui 5684e5d |
masarray
marked this pull request as ready for review
November 11, 2026 03:54
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#527 — M5 domain separation, user-facing status reliability
The native
web/approved-native-bridge.jshad more presentation-only policy than needed: exact channel name/color/icon rules and a lengthy native-to-operator message converter lived among live ACK handlers, DOM selectors, device apply, FX, and WIRE transactions. They were not independently tested.Implementation
operatorMessageto the already-loaded pureweb/approved-native-contract.js; the bridge delegates to these exported rules. The approved/preview/page, one WebView DOM, one native subscription/graph and JUCE host stay unchanged; no new script/resource is bundled.INVALID_NATIVE_SNAPSHOTandACK_READBACK_EFFECT_MISMATCHpreviously fell through to success-looking "Mixer settings updated". The normalized native-status helper now classifies exact leading/embedded invalid/stale/mismatch codes as "Change not applied · Previous mixer settings kept". The raw diagnostic remains available internally.Scope: GUI adapter/presentation only; no change to Harmony/FX DSP, device I/O, WIRE PCM, hotkeys, routing, or graphics. M5 logical-only ACK proof #564 and current M4 lease-owner #565 remain intact. Source baseline
main@c63e6ab42dfc00d002f0aeea44b8b20a7dc6b9f3. Concurrent #563 / #529 / #512 / #521 not touched.Validation: fast UI Node contracts first, then exactly one exact-SHA
uiChromium qualification (approved renderer + WIRE/browser interaction). No Windows runner or FAT ZIP for JS-only changes. Physical ASIO FAT is still PENDING.