Repository navigation
M6: fail-closed native FX lease uniqueness before approved snapshot publication - #562
Merged
Merged
Conversation
…erfull racks mutation-free
Owner
Author
|
/arsonmix-ci native a3bde75 |
Deploying arsonmix with
|
| Latest commit: |
a3bde75
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a276b524.arsonmix.pages.dev |
| Branch Preview URL: | https://guard-m6-native-fx-producer.arsonmix.pages.dev |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M6 architecture safety — authoritative native FX instance identity
The native CONTROL producer
projectNativeGraphalready validates the installed processor token, catalog identity, bypass and channel IDs, but did not check duplicate FX instance tokens across two strips or a rack exceeding eight slots. M5 JS hardening in parallel PR #561 rejects such malformed snapshots. This changes the native producer to fail closed before publishing them, reducing cross-side contract drift.Two files only:
integration/ApprovedNativeV8Projection.h: reject duplicateinstanceIdacross all channels and >8 inserts/strip before authoritative snapshot mutation. Distinct inserts of the same vendor catalog remain valid (only tokens, not catalog IDs, must be unique).tests/approved_native_v8_projection_test.cpp: real JUCE projection fixtures for duplicate lease on the same strip, reused lease across MAIN/INPUT, and nine unique inserts, each checking that a rejected graph leaves the accepted snapshot byte-for-byte unchanged.Safety: zero DSP or native audio callback changes; no GUI assets/repaint; no extra graph owner; validation and temporary set allocations only on CONTROL thread. Keeps existing AV8 projection ABI.
Qualification: fast native contracts; one exact-SHA Windows C++/CTest after fast green. Native producer is independent of JS M5 #561; reconcile current main before merging. This is M6 guardrail slice, not entire M6 or physical ASIO FAT.