Skip to content

M6: fail-closed native FX lease uniqueness before approved snapshot publication - #562

Merged
masarray merged 2 commits into
mainfrom
guard/m6-native-fx-producer-identity-20261111
Nov 11, 2026
Merged

masarray merged 2 commits into
mainfrom
guard/m6-native-fx-producer-identity-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

M6 architecture safety — authoritative native FX instance identity

The native CONTROL producer projectNativeGraph already validates the installed processor token, catalog identity, bypass and channel IDs, but did not check duplicate FX instance tokens across two strips or a rack exceeding eight slots. M5 JS hardening in parallel PR #561 rejects such malformed snapshots. This changes the native producer to fail closed before publishing them, reducing cross-side contract drift.

Two files only:

  • integration/ApprovedNativeV8Projection.h: reject duplicate instanceId across all channels and >8 inserts/strip before authoritative snapshot mutation. Distinct inserts of the same vendor catalog remain valid (only tokens, not catalog IDs, must be unique).
  • tests/approved_native_v8_projection_test.cpp: real JUCE projection fixtures for duplicate lease on the same strip, reused lease across MAIN/INPUT, and nine unique inserts, each checking that a rejected graph leaves the accepted snapshot byte-for-byte unchanged.

Safety: zero DSP or native audio callback changes; no GUI assets/repaint; no extra graph owner; validation and temporary set allocations only on CONTROL thread. Keeps existing AV8 projection ABI.

Qualification: fast native contracts; one exact-SHA Windows C++/CTest after fast green. Native producer is independent of JS M5 #561; reconcile current main before merging. This is M6 guardrail slice, not entire M6 or physical ASIO FAT.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native a3bde75

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: a3bde75
Status: ✅  Deploy successful!
Preview URL: https://a276b524.arsonmix.pages.dev
Branch Preview URL: https://guard-m6-native-fx-producer.arsonmix.pages.dev

View logs

@masarray
masarray marked this pull request as ready for review November 11, 2026 02:51
@masarray
masarray merged commit 64b123f into main Nov 11, 2026
6 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T02:52:30.214726Z a3bde75 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant