Repository navigation
M5: extract offline mixer readback proof and verify exact FX/WIRE edits - #564
Merged
Merged
Conversation
Owner
Author
|
/arsonmix-ci ui 9d2694e |
Deploying arsonmix with
|
| Latest commit: |
9d2694e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88a60540.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-m5-logical-readback.arsonmix.pages.dev |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / issue #527
The native WebView bridge previously contained its own untested
logicalReadbackProvesfor LOGICAL_ONLY .smix edits. It acceptedADD_FX_REFERENCEwhenever any existing insert had the same catalog;REMOVE_FX_REFERENCEproved only rack count; and WIRE only checked the first change. These are mismatched effect proofs even after a legitimate logical ACK.Coherent implementation
web/approved-native-contract.js: introduce pure, exportedlogicalReadbackProvesbeside the installed/native controller. Require exact ACK revision, typed controls and ordered before/after FX catalogs; for WIRE require one valid operation/source and verify original EdgeId, new send identity or primary output as appropriate.web/approved-native-bridge.js: remove duplicate domain readback function; capture minimal before-state for each pending logical transaction and call the pure contract before projecting accepted offline .smix. Keep existing one native subscription and /preview/ renderer. No audio device/PCM/DSP changes.tests/approved_native_m2_contract.test.cjs: deterministic Node fixture for ADD (duplicate catalog), REMOVE (wrong slot same count), control value types, create/delete, revision mismatch, disconnect/remove/connect/retarget/route-only and multi-change negative cases.Acceptance: one coherent M5 seam; no speculative native PCM admission; preserve last accepted document on mismatched readback. Source baseline
main@64b123fbbfc3ed6ed5d11faee37b5aed372ef697(includes M6 #562). Scope is JS bridge/protocol/tests only; all Harmony/ASIO/Hotkeys/Milestone O unchanged.CI: path-scoped fast UI/native checks first. Exactly one
uiChromium exact-SHA milestone after fast green. No duplicate Windows MSVC job; physical hardware FAT remains PENDING. Do not merge until UI tests and canonical renderer pass.