Skip to content

M5: extract offline mixer readback proof and verify exact FX/WIRE edits - #564

Merged
masarray merged 1 commit into
mainfrom
refactor/m5-logical-readback-ownership-20261111
Nov 11, 2026
Merged

masarray merged 1 commit into
mainfrom
refactor/m5-logical-readback-ownership-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

Purpose / issue #527

The native WebView bridge previously contained its own untested logicalReadbackProves for LOGICAL_ONLY .smix edits. It accepted ADD_FX_REFERENCE whenever any existing insert had the same catalog; REMOVE_FX_REFERENCE proved only rack count; and WIRE only checked the first change. These are mismatched effect proofs even after a legitimate logical ACK.

Coherent implementation

  • web/approved-native-contract.js: introduce pure, exported logicalReadbackProves beside the installed/native controller. Require exact ACK revision, typed controls and ordered before/after FX catalogs; for WIRE require one valid operation/source and verify original EdgeId, new send identity or primary output as appropriate.
  • web/approved-native-bridge.js: remove duplicate domain readback function; capture minimal before-state for each pending logical transaction and call the pure contract before projecting accepted offline .smix. Keep existing one native subscription and /preview/ renderer. No audio device/PCM/DSP changes.
  • tests/approved_native_m2_contract.test.cjs: deterministic Node fixture for ADD (duplicate catalog), REMOVE (wrong slot same count), control value types, create/delete, revision mismatch, disconnect/remove/connect/retarget/route-only and multi-change negative cases.

Acceptance: one coherent M5 seam; no speculative native PCM admission; preserve last accepted document on mismatched readback. Source baseline main@64b123fbbfc3ed6ed5d11faee37b5aed372ef697 (includes M6 #562). Scope is JS bridge/protocol/tests only; all Harmony/ASIO/Hotkeys/Milestone O unchanged.

CI: path-scoped fast UI/native checks first. Exactly one ui Chromium exact-SHA milestone after fast green. No duplicate Windows MSVC job; physical hardware FAT remains PENDING. Do not merge until UI tests and canonical renderer pass.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 9d2694e

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d2694e
Status: ✅  Deploy successful!
Preview URL: https://88a60540.arsonmix.pages.dev
Branch Preview URL: https://refactor-m5-logical-readback.arsonmix.pages.dev

View logs

@masarray
masarray marked this pull request as ready for review November 11, 2026 03:05
@masarray
masarray merged commit ff65172 into main Nov 11, 2026
15 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T03:07:28.485497Z 9d2694e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant