Skip to content

M3b: fail-closed native PCM render-evidence window for legacy retirement - #560

Merged
masarray merged 3 commits into
mainfrom
test/m3-render-evidence-window-gate-20261111
Nov 11, 2026
Merged

masarray merged 3 commits into
mainfrom
test/m3-render-evidence-window-gate-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

M3b — Fail-closed evidence gate for retiring legacy PCM

This is source-and-test progress toward M3b. It is not retirement of M4, a changed DSP algorithm, or a physical audio FAT claim.

Actual production LiveDryRoutingLab::process() already increments ProductionRenderAudit atomics once per JUCE outer callback, and dryRoutingLab.renderAudit publishes cumulative values. The missing piece was a bounded window interpretation that does not falsely reuse lifetime native/M4 totals or claim success from partial relaxed-atomic snapshots.

Changes (3 source/test/doc files):

  • engine/core/ProductionRenderAudit.h adds a constexpr, allocation-free, control-only assessWindow(before,after,sameProcess,sameDeviceEpoch,channelIdAdmittedAtBothEnds).
  • Positive exclusiveNativeObserved requires a settled before/after snapshot, monotonic counters, independent same-process/device epoch + ChannelId-installed witness, at least one successful native PCM callback, no M4 callback in window, no faults, overlap or unpatched/muted no-render exit. Otherwise returns a specific fail-closed reason.
  • tests/production_render_audit_test.cpp exercises actual counter increments, stale legacy totals versus new legacy callback, epoch/process/admission discontinuity, incomplete callback, reset/regression, native failure, overlap, muted and zero-PCM windows.
  • docs/architecture/M3_RENDER_PATH_EVIDENCE_20261111.md records what a field assessor must verify and forbids treating this status as audible hardware proof or deleting M4 prematurely.

Single owner: existing atomic ProductionRenderAudit; no additional DSP callback, new telemetry writer, audio routing, /preview/ changes, plugin state, or device restart handler.

CI strategy: source-local C++ test and fast PR native, then one exact-SHA native MSVC/full CTest when green. Do not duplicate M4's expensive run. M4 extension PR #553 is independent and being qualified. Hardware ASIO FAT and proof across CH05/SOURCE ONLY/WIRE/BUS/FX/restarts remain PENDING.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 8f8b450

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8f8b450
Status: ✅  Deploy successful!
Preview URL: https://0a83886f.arsonmix.pages.dev
Branch Preview URL: https://test-m3-render-evidence-wind.arsonmix.pages.dev

View logs

@masarray
masarray marked this pull request as ready for review November 11, 2026 01:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T01:45:59.958810Z 8f8b450 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit c62ccfa into main Nov 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant