Repository navigation
M3b: fail-closed native PCM render-evidence window for legacy retirement - #560
Merged
Merged
Conversation
…ts in native evidence window
Owner
Author
|
/arsonmix-ci native 8f8b450 |
1 of 8 tasks
Deploying arsonmix with
|
| Latest commit: |
8f8b450
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a83886f.arsonmix.pages.dev |
| Branch Preview URL: | https://test-m3-render-evidence-wind.arsonmix.pages.dev |
masarray
marked this pull request as ready for review
November 11, 2026 01:44
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M3b — Fail-closed evidence gate for retiring legacy PCM
This is source-and-test progress toward M3b. It is not retirement of M4, a changed DSP algorithm, or a physical audio FAT claim.
Actual production
LiveDryRoutingLab::process()already incrementsProductionRenderAuditatomics once per JUCE outer callback, anddryRoutingLab.renderAuditpublishes cumulative values. The missing piece was a bounded window interpretation that does not falsely reuse lifetime native/M4 totals or claim success from partial relaxed-atomic snapshots.Changes (3 source/test/doc files):
engine/core/ProductionRenderAudit.hadds a constexpr, allocation-free, control-onlyassessWindow(before,after,sameProcess,sameDeviceEpoch,channelIdAdmittedAtBothEnds).exclusiveNativeObservedrequires a settled before/after snapshot, monotonic counters, independent same-process/device epoch + ChannelId-installed witness, at least one successful native PCM callback, no M4 callback in window, no faults, overlap or unpatched/muted no-render exit. Otherwise returns a specific fail-closed reason.tests/production_render_audit_test.cppexercises actual counter increments, stale legacy totals versus new legacy callback, epoch/process/admission discontinuity, incomplete callback, reset/regression, native failure, overlap, muted and zero-PCM windows.docs/architecture/M3_RENDER_PATH_EVIDENCE_20261111.mdrecords what a field assessor must verify and forbids treating this status as audible hardware proof or deleting M4 prematurely.Single owner: existing atomic
ProductionRenderAudit; no additional DSP callback, new telemetry writer, audio routing, /preview/ changes, plugin state, or device restart handler.CI strategy: source-local C++ test and fast PR native, then one exact-SHA native MSVC/full CTest when green. Do not duplicate M4's expensive run. M4 extension PR #553 is independent and being qualified. Hardware ASIO FAT and proof across CH05/SOURCE ONLY/WIRE/BUS/FX/restarts remain PENDING.