Skip to content

H2: real VST3 hosted ParamID hotkeys, Last Touched and searchable FX parameter browser - #551

Merged
masarray merged 18 commits into
mainfrom
feature/h2-vst3-parameter-hotkeys-20261111
Nov 11, 2026
Merged

masarray merged 18 commits into
mainfrom
feature/h2-vst3-parameter-hotkeys-20261111

Conversation

@masarray

@masarray masarray commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

H2 — verified VST3 parameter hotkeys

  • Keep exactly one native /preview/ context handler and JUCE PCM owner. Right-click a populated FX slot → Browse Parameters… or Last Touched Hotkey…. The latter is based on a genuine vendor beginChangeGesture signal; otherwise the dialog provides the explicit browser fallback, never a guessed index. Shortcut capture uses the existing Win32 H1 registry.
  • Host parameter lookup uses JUCE HostedAudioProcessorParameter::getParameterID() and rejects absent/duplicate identifiers, nonautomatable/meta parameters, unsupported actions and missing/replaced VST3 instances. Persist ChannelId + FX instanceId + catalogId + vendor ParamID; slot is only a hint. Instance lookup follows a real moved VST3 and revalidates after .smix restore.
  • Operations: two-state TOGGLE and continuous/discrete STEP UP / DOWN with bounded normalized delta. All writes execute via JUCE message/control thread using setValueNotifyingHost, never audio callback. Last-touched is recorded using an atomic gesture index; own hotkey writes suppress phantom gestures.
  • Added NativeFxParameterHotkey.h, headless deterministic CTest for ID stability across reorder, action capability and duplicate/missing-ID rejection, native registry/.smix migration tests and GUI bundle contract assertions.
  • Existing H1 OS-wide keyboard, FX rack bypass, WIRE, native Harmony, ASIO device and approved /preview/ preserved. Native editor right-click is not intercepted; vendor IComponentHandler3 is not claimed without actual JUCE support.
  • CI exact SHA: quick UI/native/DSP PASS; Full Chromium #42923406298 PASS, including actual assembled GUI H2 fixture and previous WIRE, EQ, FX, compressor regression tests. Full Windows/FAT #42923380029 IN PROGRESS, currently compiling MSVC executable/CTest; not yet qualified and not merged.
  • Gate: Real vendor VST3/Windows minimized keyboard + exact processor parameter change on user hardware PENDING, not claimed from mock UI or policy CTest. A vendor plugin without stable hosted ParamID fails closed instead of binding to an index. O1 physical External OUT is the next independent milestone.

Base: main 7da5451e4e395d2fb7a1d4c215b4ba41e6fba1af.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7805798
Status: ✅  Deploy successful!
Preview URL: https://73fd872f.arsonmix.pages.dev
Branch Preview URL: https://feature-h2-vst3-parameter-ho.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 255f528

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 255f528

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat df431f4

Copy link
Copy Markdown
Owner Author

H-only CI failure triage — 2026-11-11

  • Failing exact-SHA Windows run 42923380029: 83/84 native CTest PASS. Only H1NativeGlobalShortcutRegistrationConflictAndPersistence failed on tests/native_hotkey_registry_test.cpp:44 (assertion expecting rejection of a string containing literal backslash+n, not a newline). H2HostedParamIdStableAndAutomationSafe was PASS and native executable compiled successfully. This is a fixture defect, not proven DSP/callback regression.
  • Fix df431f41e708b1894eace162c778257baf5dd644: tests now pass true C++ LF/CR/TAB escape sequences and separately assert a legitimate literal backslash+n remains allowed. The existing native validator still rejects CR/LF/TAB.
  • Current SHA quick UI/native/DSP PASS. One exact-SHA Windows FAT/CTest rerun #42926608454 dispatched. Prior full Chromium 42923406298 PASS on same H2 implementation before test-only change; no GUI code changed.
  • Milestone O intentionally untouched, owned by another thread. Keep this PR draft until MSVC/CTest and artifact validation complete.

#545)

Preserve latest native host + CMake Waves safety, and all H2 verified parameter mappings. Do not touch External OUT or additional callback.

Copy link
Copy Markdown
Owner Author

H2 merge reconciliation checkpoint (2026-11-11)

  • main advanced to 7108959471f3d37006d7b36869e32794e211f31a with P0: fix Waves WaveShell wrong VST3 class and repeated startup FX crashes #545 (real Waves VST3 class selection and startup recovery). This overlaps H2 src/Main.cpp and CMakeLists.txt; PR initially became nonmergeable.
  • Reconciled both actual overlapping files by applying each H2 diff hunk exactly once to new main; retained StartupVst3RecoveryGuard.h, patch_juce_vst3_waveshell.py, and existing Waves native tests. Added untouched H2 blobs for 10 other scoped files. Created two-parent merge commit 7805798646f445da3273993b35021b127f0dc056 with both H2 and current main parents; optimistic branch lease succeeded.
  • PR H2: real VST3 hosted ParamID hotkeys, Last Touched and searchable FX parameter browser #551 now mergeable, behind main 0, exactly 12 H2-related changed paths. No External OUT or O milestone changes.
  • Previous H2 exact SHA df431f41... Windows FAT #42926608454 still building. New HEAD quick native/UI/DSP started automatically; request one final latest-SHA Windows qualification once quick tests pass and previous CTest behavior known. Do not treat the old SHA Windows test as same-SHA merge evidence.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 7805798

Copy link
Copy Markdown
Owner Author

H-only verification evidence update:

  • Windows FAT #42926608454 at df431f41...: MSVC executable PASS, all native CTest step PASS, independent ZIP/GUI/engine verification PASS. Final installer/artifact publication still in progress as of this comment.
  • The previously red H1 negative fixture now passes with real CR/LF/TAB and valid literal backslash-n distinction. No native H2 behavior changed to mask the test.
  • Final combined H2+Waves head 7805798646f445da3273993b35021b127f0dc056 fast UI/native/DSP PASS and exact-SHA Windows/FAT #42927881962 still compiling. That run—not the older standalone H2 SHA—is the native gate for PR H2: real VST3 hosted ParamID hotkeys, Last Touched and searchable FX parameter browser #551.
  • Physical vendor VST3 foreground/background audition remains an external hardware FAT, separate from green CI. Milestone O remains out of scope.

@masarray
masarray marked this pull request as ready for review November 11, 2026 00:23
@masarray
masarray merged commit 0626591 into main Nov 11, 2026
13 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T00:24:38.589025Z 7805798 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant