Repository navigation
H2: real VST3 hosted ParamID hotkeys, Last Touched and searchable FX parameter browser - #551
Merged
Merged
Conversation
… and normalized control
…ealtime allocation
…n native hotkey journal and .smix
…n and safe background parameter shortcuts
… exact ParamID shortcut capture
… duplicate-ID fail-closed
…ls and unsafe mapping rejections
Deploying arsonmix with
|
| Latest commit: |
7805798
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73fd872f.arsonmix.pages.dev |
| Branch Preview URL: | https://feature-h2-vst3-parameter-ho.arsonmix.pages.dev |
…ACK/readback and stale FX refusal
…nd Chromium smoke
Owner
Author
|
/arsonmix-ci fat 255f528 |
Owner
Author
|
/arsonmix-ci ui 255f528 |
…teral backslash-n
Owner
Author
|
/arsonmix-ci fat df431f4 |
Owner
Author
|
H-only CI failure triage — 2026-11-11
|
#545) Preserve latest native host + CMake Waves safety, and all H2 verified parameter mappings. Do not touch External OUT or additional callback.
Owner
Author
|
H2 merge reconciliation checkpoint (2026-11-11)
|
Owner
Author
|
/arsonmix-ci fat 7805798 |
Owner
Author
|
H-only verification evidence update:
|
masarray
marked this pull request as ready for review
November 11, 2026 00:23
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
H2 — verified VST3 parameter hotkeys
beginChangeGesturesignal; otherwise the dialog provides the explicit browser fallback, never a guessed index. Shortcut capture uses the existing Win32 H1 registry.HostedAudioProcessorParameter::getParameterID()and rejects absent/duplicate identifiers, nonautomatable/meta parameters, unsupported actions and missing/replaced VST3 instances. PersistChannelId + FX instanceId + catalogId + vendor ParamID; slot is only a hint. Instance lookup follows a real moved VST3 and revalidates after .smix restore.setValueNotifyingHost, never audio callback. Last-touched is recorded using an atomic gesture index; own hotkey writes suppress phantom gestures.NativeFxParameterHotkey.h, headless deterministic CTest for ID stability across reorder, action capability and duplicate/missing-ID rejection, native registry/.smix migration tests and GUI bundle contract assertions.Base: main
7da5451e4e395d2fb7a1d4c215b4ba41e6fba1af.