Repository navigation
M4: fail-fast native FX prepare guard before any plugin allocation - #572
Merged
1 commit merged intoNov 11, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
Owner
Author
|
/arsonmix-ci native 4497119 |
1 of 8 tasks
Deploying arsonmix with
|
| Latest commit: |
4497119
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c4251d4.arsonmix.pages.dev |
| Branch Preview URL: | https://guard-m4-builtin-fx-prepare.arsonmix.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#527 — host-wide safe FX preparation
Current
main@fd2dd0c4d9cb78abd34c6f12e28f33f0e8a55b74supports built-in EQ, Compressor, Harmonice and Vocal Throw via oneNativeBuiltInFxregistry. Its preparation wrapper previously constructed a plugin and calledprepareToPlayeven for an invalid/NaN/Inf device rate or absurd block count, relying on each effect's local behavior to reject the request. A future built-in FX could allocate enormous buffers before returning not-ready.Change:
src/NativeBuiltInFx.hnow rejects non-finite, sub-8k/>384k rates, block counts outside [16,8192] and invalid state pointer/size beforestd::make_unique<Processor>(). The bound uses the samePreparedMixerBlock::hardFrameLimitas native graph PCM; legitimate 16-frame ASIO is still admitted at the generic host boundary and individual processors can require more. This has NO changes to valid EQ/Compressor/Harmonice/Throw DSP or editor behavior.tests/native_fx_registry_extension_test.cpprecords fixture construction to prove fail-closed negative cases occur before allocation, and checks 16-frame ownership remains processor-specific.Branch compatibility: direct patch only in the common native FX registration and its existing CTest. Neither currently changing Harmonice #529 nor O1/O2 #563 edits those files; no changes to live Main.cpp, audio callback, ASIO routing, OSC/UI, .smix schema or current Harmony sound. M2/M3 #571 is a separate source-disjoint PR.
Qualification: fast native contracts then one exact SHA Windows MSVC/CTest when the code reaches a stable checkpoint; no Chromium or FAT artifact for host-preparation-only change. Physical audio remains unverified. Keep epic #527 OPEN.