Repository navigation
M2a: isolate native device Apply owner, verified pin preflight and rollback - #534
Merged
Merged
Conversation
… verified rollback
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Deploying arsonmix with
|
| Latest commit: |
02b7c2d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f0f698bb.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-m2-device-apply-bou.arsonmix.pages.dev |
Owner
Author
|
/arsonmix-ci native 02b7c2d |
1 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M2a — functional maintainability milestone (follows merged M1 #530)
Tracks #527 and preserves P0 hardware source truth #412.
Base:
main@68e74ee332c3258900c2bbce2a8da635a3d0b62cImplementation:
65e46f34d367aa9d5303bd8ccfab6ebcc4302b99Actual source changes
src/NativeDeviceApplyCoordinator.h: one message-thread Apply/restart reentrancy lease; native typed request validation; JUCE-reported backend/input/output names; exact sparse physical input/output pin masks; hardware Apply readback and verified rollback policy; existing direct JUCE open routine extracted fromMain.cpp. Does NOT own a second AudioDeviceManager, mixer/session document, graph, callback or renderer.src/Main.cpp: owns only high-level transaction orchestration and messaging, uses the shared guard in explicit Apply and ASIO restart; delegates parsing/physical masks, open, and accepted/rollback verification to coordinator. No changes to actual ChannelId audio render, DSP, .smix, startup policy or native GUI. Existing diagnostics/ACK strings maintained.tests/native_device_apply_coordinator_test.cpp: new deterministic JUCE no-hardware CTest exercises re-entrant Apply lease, valid/invalid backend and 0-IN selection, mask validation, accepted device readback, safe ASIO pin-name rollback and closed-device rejection.CMakeLists.txt: dedicated native test target; architecture map updated to mark M2a ownership boundary.Execution / validation
/arsonmix-ci native <exact PR HEAD>using documented owner-authorized dispatcher (no fat ZIP needed for pure device-boundary refactoring); inspect full MSVC/CTest result.Concurrency / follow-on
LiveAudioEngine. Do not close [P1][ARCHITECTURE] Long-term maintainability: consolidate mixer/FX host ownership and reduce high-coupling modules #527 yet.Qualification checkpoint — current exact SHA