Repository navigation
docs(fx): Harmonice Duo/Doubler parity and universal built-in user preset architecture - #532
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-requested execution plan, no product code in this PR
Adds
docs/HARMONICE_DUO_DOUBLER_BUILTIN_FX_USER_PRESETS_20261111.mdas the executable product/DSP/UX/native-storage workpack.Why: Harmonice currently exposes only 3/4/5 voice buttons although native + factory Natural Duo already support 2; a genuine BOSS VE-style unison Doubler is a different DSP mode; all built-in EQ/Compressor/Harmonice/Vocal Throw must support persistent native user-made presets.
Key decisions
.smixsession,.armixwhole-chain My Sounds, and per-FX presets distinct; safe typed state capture, worker persistence, exact native recall ACK/readback.Coordination: #529 already owns Pitch Tune, register-aware harmony and checkbox→toggle. This PR does not modify source and must not supersede #529. #521 remains research-only.
Status: Requirements/implementation roadmap only. Future DSP, GUI and persistence PRs must deliver code/tests; nothing in this docs PR should be advertised as shipped sound functionality.