Skip to content

docs(fx): Harmonice Duo/Doubler parity and universal built-in user preset architecture - #532

Merged
masarray merged 1 commit into
mainfrom
docs/harmonice-duo-doubler-user-presets-20261111
Nov 10, 2026
Merged

masarray merged 1 commit into
mainfrom
docs/harmonice-duo-doubler-user-presets-20261111

Conversation

@masarray

Copy link
Copy Markdown
Owner

Owner-requested execution plan, no product code in this PR

Adds docs/HARMONICE_DUO_DOUBLER_BUILTIN_FX_USER_PRESETS_20261111.md as the executable product/DSP/UX/native-storage workpack.

Why: Harmonice currently exposes only 3/4/5 voice buttons although native + factory Natural Duo already support 2; a genuine BOSS VE-style unison Doubler is a different DSP mode; all built-in EQ/Compressor/Harmonice/Vocal Throw must support persistent native user-made presets.

Key decisions

  • First-class 2-voice selector, connected to native ACK/readback and Duo preset (coordinate with in-flight Harmonice P0: stereo lead Pitch Tune, register-aware ensemble and compact switch #529 to avoid concurrent file edits).
  • Separate real unison Doubler DSP mode from 2 pitched Harmony voices; migrate old sessions without changing their meaning.
  • One compact professional per-effect PresetBar + one native durable repository and per-FX codec, not four JS-only managers.
  • Keep .smix session, .armix whole-chain My Sounds, and per-FX presets distinct; safe typed state capture, worker persistence, exact native recall ACK/readback.
  • Cite FabFilter, iZotope Nectar, Valhalla, BOSS VE reference UX and specify negative tests, screenshots, low-cost CI and physical ASIO gates.

Coordination: #529 already owns Pitch Tune, register-aware harmony and checkbox→toggle. This PR does not modify source and must not supersede #529. #521 remains research-only.

Status: Requirements/implementation roadmap only. Future DSP, GUI and persistence PRs must deliver code/tests; nothing in this docs PR should be advertised as shipped sound functionality.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T20:12:49.055278Z ad1df57 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant