Skip to content

H1: Win32 global Hotkey Register with native ChannelId commands and .smix persistence - #536

Merged
masarray merged 33 commits into
mainfrom
feature/h1-hotkey-native-register-20261111
Nov 10, 2026
Merged

masarray merged 33 commits into
mainfrom
feature/h1-hotkey-native-register-20261111

Conversation

@masarray

@masarray masarray commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

H1 implementation (native, not prototype)

  • New JUCE control-thread NativeHotkeyRegistry: global Win32 RegisterHotKey, WM_HOTKEY, MOD_NOREPEAT, app/session scopes, OS conflict validation, atomic file replacement, and unregister on deletion/session changes.
  • Existing /preview/ native-only context menu adds compact movable capture, searchable register, native ACK then fresh readback, direct MUTE/SOLO target by stable ChannelId. Existing Rename/Delete/Orbit remain.
  • One existing native dispatcher: global key builds same arMixConsoleIntent as GUI button with installed device/graph/roster revisions; no browser click or extra audio callback.
  • Optional validated .smix hotkey entries, original session schema preserved; persistence app-scoped in native registry.
  • Added ARMixNativeHotkeyTests CTest, .smix codec negative/rename identity tests, GUI bundle contract guard.

Safety and coordination

Based on main@68e74ee332c3258900c2bbce2a8da635a3d0b62c. This PR does not edit Harmonice DSP, PCM graph, ASIO device callback, or maintainability PR branches. Existing PR #529/#521/#512 are untouched.

Evidence/status

JS source syntax parsed in V8 during authoring. Focused CTest, Windows GUI smoke and actual minimized/background OS shortcut must be checked before production merge. O1 physical multi-output and H2 VST3 parameter mapping not included in H1. Real hardware FAT remains PENDING.

Draft until exact SHA native + GUI verification.

Current authoritative execution checkpoint — 2026-11-11

  • H1 HEAD: 31a2499b26777c8b148e37269d1623d203bf4729. Current main baseline: 4eb541af90a8d9c1876fb49a014b7d7b34ebf62f. H1 branch includes a two-parent merge commit with this baseline. No force-push/reset; M2a NativeDeviceApplyCoordinator intact, and hotkey gates now use deviceApply_.busy().
  • Earlier Windows FAT failed from Win32 shortcut header min/max macros leaking into JUCE/DSP source. Fixed in src/NativeHotkeyRegistry.h with NOMINMAX and defensive #undef. No Harmonice algorithm or RT callback modified.
  • Fast UI, fast native and portable DSP checks on current HEAD: PASS. Exact-SHA Windows FAT run #42903740489: IN PROGRESS at latest inspection (native MSVC build/CTest, package not proven). Never claim PASS or available installer until actual evidence.
  • Approved /preview/ retained. Native service, context capture, registration readback, optional .smix persistence and focused tests implemented. Physical Windows minimized/background keyboard test and ASIO interface hardware FAT remain PENDING.
  • Parallel Harmonice/Doubler/presets/M2b PRs not edited. Do not merge until current-HEAD Windows evidence read and failures repaired. H2 vendor parameter mapping and O1/O2 physical outputs are next independent milestones.

H1 FX POWER / DURABLE IDENTITY — 2026-11-11

  • Right-click POWER: entire rack (fxOn) and each populated insert (slotPower) show Assign Hotkey, Change Hotkey, Remove Hotkey. Mute/Solo wording aligned. Native-only context GUI; no second mixer or DSP.
  • OS-global path: RegisterHotKey / WM_HOTKEY uses the same JUCE native action routingNativeFxRackBypass / routingNativeFxInsertBypass, fenced by current accepted ChannelId, graph revision, device epoch and, for inserts, exact instance token. Replaced/reordered plugins cannot inherit a positional shortcut; invalid targets report NEEDS_REMAP.
  • Durable .smix identity: the real FxInstance::instanceId is saved as an optional, validated insert property alongside vendor state and reconstructed on native FX restore, with monotonic next-ID reservation. Older v1 sessions without this field still decode and freshly created FX still use new IDs. Regression test checks JSON roundtrip, retained shortcut target, negative malformed/duplicate IDs and old schema.
  • Main reconciliation: H1 branch includes M2c native device readback merged main c48bdce0d680c020cf6236cf1882331a29c13305; no Harmonice or WIRE DSP rewrite. Current HEAD 18d7278ecfeab1c9ad3c6443e36835b216f4fa8e, PR remains Draft.
  • CI evidence: latest-head fast UI, fast native, portable Harmony DSP PASS. Exact-SHA full Windows MSVC/CTest and Chromium jobs dispatched: Windows #42915280087 and UI #42915318197. These are IN PROGRESS at last review; do not call them passed until full logs are read.
  • Release gate: live Windows minimized/background physical hotkey input, ASIO audio hardware impact, and install/reopen FAT remain PENDING. No merge into main until properly qualified. H2 parameter mapping and O1/O2 physical output routing outside this H1 milestone.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 18d7278
Status: ✅  Deploy successful!
Preview URL: https://81a4db00.arsonmix.pages.dev
Branch Preview URL: https://feature-h1-hotkey-native-reg.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui f90e978

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat f90e978

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 31a2499

Copy link
Copy Markdown
Owner Author

H1 native MSVC recovery & main reconciliation — 2026-11-11

  • Root cause of previous Windows FAT failure (run 42899161581): new Win32 shortcut header exported legacy Windows min/max macros, corrupting std::min, std::max, and std::numeric_limits in unrelated JUCE/DSP headers. This was a single transitive include boundary error, not independent failures in Harmonice/Compressor/WIRE.
  • Fixed in src/NativeHotkeyRegistry.h using NOMINMAX before Windows headers, plus defensive #undef min/max after the Win32 includes. No DSP logic or RT callback modified.
  • Reconciled merged main 4eb541af90a8d9c1876fb49a014b7d7b34ebf62f (M2a device Apply coordinator) with Hotkey changes via two-parent merge commit 31a2499b26777c8b148e37269d1623d203bf4729. New hotkey controller gates now use deviceApply_.busy(); the refactored native device setup remains intact. Other PRs not modified.
  • Fast UI/native/DSP checks on 31a2499b: PASS. Exact SHA FAT dispatch accepted: Windows native run #42903740489; full MSVC build/CTest is still executing as of this checkpoint. Do not infer a PASS or merge until its actual result.
  • H2/VST3 parameter and O1 physical multichannel output remain separate upcoming milestones. Physical ASIO hardware FAT and minimized-foreground keyboard listening remain PENDING even if simulated Win32 registration tests pass.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 34c33a7

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 34c33a7

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 18d7278

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 18d7278

@masarray
masarray marked this pull request as ready for review November 10, 2026 23:10
@masarray
masarray merged commit 7da5451 into main Nov 10, 2026
16 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T23:10:46.818274Z
We couldn’t complete this review. Comment @codex review to try again.
18d7278 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant