Repository navigation
H1: Win32 global Hotkey Register with native ChannelId commands and .smix persistence - #536
Merged
Merged
Conversation
…tion and persistent stable targets
…thout changing legacy schema
…ntrols, native ACK and session integration
…and restore on exit
…nfirmed readback UI
…lifetime in registry load
…d mapping rejection
…in bundle contract test
…ity is not admitted
Deploying arsonmix with
|
| Latest commit: |
18d7278
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://81a4db00.arsonmix.pages.dev |
| Branch Preview URL: | https://feature-h1-hotkey-native-reg.arsonmix.pages.dev |
…ty mappings and rollback on IO failure
…mix Open imports with visible error
Owner
Author
|
/arsonmix-ci ui f90e978 |
Owner
Author
|
/arsonmix-ci fat f90e978 |
…entries, not block session Save
…etargeting another channel
…sion and reject noncanonical ID
…k JUCE DSP MSVC build
…ture and fix Win32 macro pollution
Owner
Author
|
/arsonmix-ci fat 31a2499 |
Owner
Author
H1 native MSVC recovery & main reconciliation — 2026-11-11
|
… target rejection
… session registry
Owner
Author
|
/arsonmix-ci ui 34c33a7 |
Owner
Author
|
/arsonmix-ci fat 34c33a7 |
… lease without new DSP owner
…Open without schema bump
…nsertion and invalid duplicates
Owner
Author
|
/arsonmix-ci fat 18d7278 |
Owner
Author
|
/arsonmix-ci ui 18d7278 |
masarray
marked this pull request as ready for review
November 10, 2026 23:10
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
H1 implementation (native, not prototype)
NativeHotkeyRegistry: global Win32RegisterHotKey,WM_HOTKEY,MOD_NOREPEAT, app/session scopes, OS conflict validation, atomic file replacement, and unregister on deletion/session changes.arMixConsoleIntentas GUI button with installed device/graph/roster revisions; no browser click or extra audio callback..smixhotkey entries, original session schema preserved; persistence app-scoped in native registry.ARMixNativeHotkeyTestsCTest,.smixcodec negative/rename identity tests, GUI bundle contract guard.Safety and coordination
Based on
main@68e74ee332c3258900c2bbce2a8da635a3d0b62c. This PR does not edit Harmonice DSP, PCM graph, ASIO device callback, or maintainability PR branches. Existing PR #529/#521/#512 are untouched.Evidence/status
JS source syntax parsed in V8 during authoring. Focused CTest, Windows GUI smoke and actual minimized/background OS shortcut must be checked before production merge. O1 physical multi-output and H2 VST3 parameter mapping not included in H1. Real hardware FAT remains PENDING.
Draft until exact SHA native + GUI verification.
Current authoritative execution checkpoint — 2026-11-11
31a2499b26777c8b148e37269d1623d203bf4729. Current main baseline:4eb541af90a8d9c1876fb49a014b7d7b34ebf62f. H1 branch includes a two-parent merge commit with this baseline. No force-push/reset; M2aNativeDeviceApplyCoordinatorintact, and hotkey gates now usedeviceApply_.busy().min/maxmacros leaking into JUCE/DSP source. Fixed insrc/NativeHotkeyRegistry.hwithNOMINMAXand defensive#undef. No Harmonice algorithm or RT callback modified./preview/retained. Native service, context capture, registration readback, optional.smixpersistence and focused tests implemented. Physical Windows minimized/background keyboard test and ASIO interface hardware FAT remain PENDING.H1 FX POWER / DURABLE IDENTITY — 2026-11-11
fxOn) and each populated insert (slotPower) show Assign Hotkey, Change Hotkey, Remove Hotkey. Mute/Solo wording aligned. Native-only context GUI; no second mixer or DSP.RegisterHotKey/WM_HOTKEYuses the same JUCE native actionroutingNativeFxRackBypass/routingNativeFxInsertBypass, fenced by current accepted ChannelId, graph revision, device epoch and, for inserts, exact instance token. Replaced/reordered plugins cannot inherit a positional shortcut; invalid targets reportNEEDS_REMAP.FxInstance::instanceIdis saved as an optional, validated insert property alongside vendor state and reconstructed on native FX restore, with monotonic next-ID reservation. Older v1 sessions without this field still decode and freshly created FX still use new IDs. Regression test checks JSON roundtrip, retained shortcut target, negative malformed/duplicate IDs and old schema.c48bdce0d680c020cf6236cf1882331a29c13305; no Harmonice or WIRE DSP rewrite. Current HEAD18d7278ecfeab1c9ad3c6443e36835b216f4fa8e, PR remains Draft.