Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
b582f2c
fix(harmonice): recover stereo lead tuning and stable backing registers
masarray Nov 10, 2026
a1ef226
fix(harmony): stabilize quiet/high backing and expose Duo
masarray Nov 10, 2026
99bfbc4
fix(harmonice): smooth chorus/vibrato and widen HIGH/LOW stage
masarray Nov 10, 2026
2a8c4e8
test(harmony): isolate register vocals with authentic native PCM stem…
masarray Nov 10, 2026
7496fee
fix(harmony): keep PSOLA active through octave-harmonic transients
masarray Nov 10, 2026
dc63d1f
test(harmony): benchmark high-register vibrato and busy chorus callba…
masarray Nov 10, 2026
87fd184
feat(harmonice): genuine native Doubler with accepted GUI and state m…
masarray Nov 10, 2026
be19b73
fix(harmony): carry PSOLA source epochs until unvoiced wet tail is si…
masarray Nov 11, 2026
2745a2c
test(harmony): qualify full HIGH unvoiced-tail continuity at 48k and …
masarray Nov 11, 2026
836f4c7
Harmonice M7: offline 10ms stem glitch evidence and native block parity
masarray Nov 11, 2026
bfb324f
fix(harmonice-m7): use explicit WAV sample rate type in offline evidence
masarray Nov 11, 2026
3dd6345
Harmonice M7: reconcile native vocal DSP, Duo/Doubler and diagnostics…
masarray Nov 11, 2026
f258d0b
Harmonice M7: native wet-only Duo vs Doubler listening A/B and exact …
masarray Nov 11, 2026
8954da7
Harmonice P1: native portable user Save As and recalled DSP ACK/readback
masarray Nov 11, 2026
05c0562
test(harmonice): verify expanded hidden form selector without stale C…
masarray Nov 11, 2026
d43cfbe
Harmonice P1: integrate portable native preset recall with latest sha…
masarray Nov 11, 2026
a36176f
Harmonice P1: full user preset lifecycle, confirmed overwrite, dirty-…
masarray Nov 11, 2026
bc580cd
test(harmonice): compare numeric browser action counts directly in P1…
masarray Nov 11, 2026
7258712
Built-in FX M4: single catalog-safe native preset service and accepte…
masarray Nov 11, 2026
0057cc5
Built-in FX M4: reusable native My Presets bar, Compressor audio-ACK …
masarray Nov 11, 2026
6548800
fix(preset): retain exactly 18 approved GUI stylesheet owners
masarray Nov 11, 2026
921feb2
fix(preset): exact Windows CTest regex and hold Compressor recall unt…
masarray Nov 11, 2026
92367d4
Built-in FX M4: Vocal Throw My Presets native recall via existing DSP…
masarray Nov 11, 2026
831a312
test(presets): include Vocal Throw real Chromium My Presets recall in…
masarray Nov 11, 2026
0660032
test(preset): scope Compressor controls by editor when Vocal Throw al…
masarray Nov 11, 2026
ac5e6c1
Reconcile Harmonice P1 presets with main typed FX envelope; scope fut…
masarray Nov 11, 2026
2a3673f
Built-in FX M4: EQ eight-band user presets with ordered native AUDIO …
masarray Nov 11, 2026
d5e4387
fix(preset): preserve EQ partial-recall warning and align multi-band …
masarray Nov 11, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 53 additions & 8 deletions .github/workflows/builtin-fx-preset-native.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ on:
paths:
- 'src/BuiltInFxUserPresetStore.h'
- 'tests/builtin_fx_user_preset_store_test.cpp'
- 'src/BuiltInFxAcceptedSnapshot.h'
- 'tests/builtin_fx_accepted_snapshot_test.cpp'
- 'engine/builtin_fx/ChannelEq.h'
- 'engine/builtin_fx/ChannelEqProcessor.h'
- 'engine/builtin_fx/ChannelCompressorProcessor.h'
- 'engine/builtin_fx/ChannelHarmonyProcessor.h'
- 'engine/builtin_fx/VocalThrowProcessor.h'
- '.github/workflows/builtin-fx-preset-native.yml'
- 'CMakeLists.txt'

Expand All @@ -16,8 +23,45 @@ concurrency:
cancel-in-progress: true

jobs:
scope:
name: Verify tip commit actually changed native preset sources
runs-on: ubuntu-latest
outputs:
build: ${{ steps.diff.outputs.build }}
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 2
- name: Check current tip delta, not entire historical PR
id: diff
shell: bash
env:
PR_ACTION: ${{ github.event.action }}
run: |
if [[ "$PR_ACTION" != "synchronize" ]] || ! git rev-parse --verify HEAD^ >/dev/null 2>&1; then
echo 'build=true' >> "$GITHUB_OUTPUT"
elif git diff --name-only HEAD^ HEAD -- \
CMakeLists.txt src/BuiltInFxUserPresetStore.h \
src/BuiltInFxAcceptedSnapshot.h \
tests/builtin_fx_user_preset_store_test.cpp \
tests/builtin_fx_accepted_snapshot_test.cpp \
engine/builtin_fx/ChannelEq.h \
engine/builtin_fx/ChannelEqProcessor.h \
engine/builtin_fx/ChannelCompressorProcessor.h \
engine/builtin_fx/ChannelHarmonyProcessor.h \
engine/builtin_fx/VocalThrowProcessor.h \
.github/workflows/builtin-fx-preset-native.yml | grep -q .; then
echo 'build=true' >> "$GITHUB_OUTPUT"
else
echo 'build=false' >> "$GITHUB_OUTPUT"
echo 'No native preset target changes at HEAD; Windows CTest already qualified earlier'
fi

native-preset:
name: Windows MSVC single-target actual disk CTest (Release)
name: Windows MSVC two-target disk + accepted DSP CTest (Release)
needs: scope
if: ${{ needs.scope.outputs.build == 'true' }}
runs-on: windows-2022
timeout-minutes: 22
steps:
Expand Down Expand Up @@ -56,19 +100,20 @@ jobs:
$catalogText = & ctest --test-dir build -C Release --show-only=json-v1
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
$catalog = ($catalogText | Out-String | ConvertFrom-Json)
if ('BuiltInFxUserPresetNativePortableSaveAndRecovery' -notin
@($catalog.tests | ForEach-Object { $_.name })) {
throw 'PRESET_CTEST_MISSING_EXACT_SOURCE'
$names = @($catalog.tests | ForEach-Object { $_.name })
foreach ($required in @('BuiltInFxUserPresetNativePortableSaveAndRecovery',
'BuiltInFxUserPresetFourRealJuceAdaptersAndColdReopen')) {
if ($required -notin $names) { throw "PRESET_CTEST_MISSING:$required" }
}
- name: Compile only native preset store test (not the whole mixer)
- name: Compile only two native preset targets (not the mixer)
shell: pwsh
run: |
cmake --build build --config Release --parallel 2 --target ARMixBuiltInFxPresetStoreTests
cmake --build build --config Release --parallel 2 --target ARMixBuiltInFxPresetStoreTests ARMixBuiltInFxAcceptedSnapshotTests
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
- name: Run immutable-source Release CTest (assertions always enabled)
shell: pwsh
run: |
ctest --test-dir build -C Release --output-on-failure `
-R '^BuiltInFxUserPresetNativePortableSaveAndRecovery$'
-R '^BuiltInFxUserPreset(NativePortableSaveAndRecovery|FourRealJuceAdaptersAndColdReopen)$'
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
Write-Host 'PRESET_NATIVE_MSVC_TARGET_AND_DISK_ROUNDTRIP=PASS'
Write-Host 'PRESET_NATIVE_TWO_TARGETS_STORE_AND_ACCEPTED_PCM_SNAPSHOT=PASS'
1 change: 1 addition & 0 deletions .github/workflows/harmony-fast-dsp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
paths:
- 'engine/builtin_fx/Harmony*.h'
- 'tests/harmony*.cpp'
- 'tools/harmony_offline_ab.cpp'
- 'CMakeLists.txt'
- '.github/workflows/harmony-fast-dsp.yml'
permissions:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ui-smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,8 @@ jobs:
run: python tests/approved_native_peq_smoke.py
- name: Native Compressor real Chromium FX, transfer curve, ACK and responsive editor
run: python tests/approved_native_compressor_smoke.py
- name: Native Vocal Throw portable My Presets, audio ACK and responsive editor
run: python tests/approved_native_vocal_throw_smoke.py
- name: Native Harmony effective-key LCD, Music/Manual ACK, slow readback and geometry
run: python tests/approved_native_harmony_smoke.py
- name: Cold start first WIRE and original-channel VST3 picker editor
Expand Down
15 changes: 15 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,21 @@ if(BUILD_TESTING)
juce::juce_core juce::juce_cryptography juce::juce_recommended_config_flags)
target_compile_features(ARMixBuiltInFxPresetStoreTests PRIVATE cxx_std_20)
add_test(NAME BuiltInFxUserPresetNativePortableSaveAndRecovery COMMAND ARMixBuiltInFxPresetStoreTests)
# Real JUCE adapters for all four built-in FX: capture ONLY accepted
# settings, validate portable types and re-open .armixfx in another store.
# Never serialize from a published callback or an offline browser fake.
juce_add_console_app(ARMixBuiltInFxAcceptedSnapshotTests PRODUCT_NAME
"ArSonMix Native Built-in FX Accepted Preset Snapshot Tests")
target_sources(ARMixBuiltInFxAcceptedSnapshotTests PRIVATE
tests/builtin_fx_accepted_snapshot_test.cpp
src/BuiltInFxAcceptedSnapshot.h)
target_link_libraries(ARMixBuiltInFxAcceptedSnapshotTests PRIVATE
juce::juce_audio_processors juce::juce_cryptography
juce::juce_recommended_config_flags)
target_compile_features(ARMixBuiltInFxAcceptedSnapshotTests PRIVATE cxx_std_20)
add_test(NAME BuiltInFxUserPresetFourRealJuceAdaptersAndColdReopen
COMMAND ARMixBuiltInFxAcceptedSnapshotTests)

add_executable(ARMixFxStructuralHandoffTests tests/live_fx_structural_handoff_test.cpp)
target_compile_features(ARMixFxStructuralHandoffTests PRIVATE cxx_std_20)
add_test(NAME R0BStructuralFxAckAndControlThreadRetirement COMMAND ARMixFxStructuralHandoffTests)
Expand Down
11 changes: 7 additions & 4 deletions engine/builtin_fx/ChannelHarmonyProcessor.h
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ class ChannelHarmonyProcessor final : public juce::AudioProcessor,
void getStateInformation(juce::MemoryBlock& out) override {
juce::MemoryOutputStream stream(out,false);
stream.writeInt(0x41484d31); // AHM1
stream.writeInt(2);
stream.writeInt(3);
stream.writeInt(accepted_.key);
stream.writeInt(accepted_.scale);
stream.writeInt(accepted_.voices);
Expand All @@ -176,29 +176,32 @@ class ChannelHarmonyProcessor final : public juce::AudioProcessor,
stream.writeFloat(accepted_.gainDb);
stream.writeInt(accepted_.guideMode);
stream.writeInt64(static_cast<juce::int64>(accepted_.guideChannelId));
stream.writeInt(accepted_.voiceMode);
}
bool restoreUnpublishedState(const void* bytes,int len) {
if(published_||!bytes||len<=0||len>128)return false;
juce::MemoryInputStream stream(bytes,static_cast<std::size_t>(len),false);
if(stream.readInt()!=0x41484d31)return false;
const int version=stream.readInt();
if(version!=1&&version!=2)return false;
if(version!=1&&version!=2&&version!=3)return false;
armix::harmony::Settings incoming{};
incoming.key=stream.readInt();incoming.scale=stream.readInt();
incoming.voices=stream.readInt();incoming.correction=stream.readBool();
incoming.wet=stream.readFloat();incoming.space=stream.readFloat();
incoming.color=stream.readFloat();incoming.gainDb=stream.readFloat();
if(version==2){
if(version>=2){
incoming.guideMode=stream.readInt();
const auto guide=stream.readInt64();
if(guide<0)return false;
incoming.guideChannelId=static_cast<std::uint64_t>(guide);
}
if(version==3)incoming.voiceMode=stream.readInt();
// v1/v2 lacked an explicit Doubler; they stay pitched Harmony.
if(stream.getPosition()!=stream.getTotalLength()||
!armix::harmony::valid(incoming))return false;
if(ready_&&!dsp_.setSettings(incoming))return false;
// NativeMixerSessionFxRestore restores AFTER prepareToPlay. An accepted
// v2 ChannelId must become the actual AUDIO guide source, not merely a
// v2/v3 ChannelId must become the actual AUDIO guide source, not merely a
// saved GUI value. This is unpublished/control-thread only.
if(ready_) {
guide_.reset();
Expand Down
Loading
Loading