Repository navigation
P0 Harmonice M3: preserve PSOLA overlap across octave readout errors and real vocal leaps - #548
Merged
masarray merged 3 commits intoNov 10, 2026
Conversation
…ithout resetting active PSOLA grains
…rs and retune only confirmed leaps
…ion and bounded PSOLA period slew
masarray
marked this pull request as ready for review
November 10, 2026 23:05
masarray
merged commit Nov 10, 2026
7496fee
into
integration/harmonice-lead-ensemble-20261111
3 of 4 checks passed
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User field evidence
Latest Windows FAT for #529 significantly reduced but did not fully eliminate short harmony crackle and stutter. LOW is audible; busy chorus and sustained vibrato are still acceptance-critical, especially HIGH.
Root-path audit / precise change
The last
HarmonyDsp::finishPitchAnalysispath still hard-reset all 5pitchSync_voice grains whenever the incoming source period differed by >25% from the previously tracked F0. Two analysis windows can confidently report an octave harmonic during a loud vowel; such a reset replaces all active singer grains by a fresh renderer and leaves dropout holes while it reacquires stable epochs. This is in the audio thread, even though PCM processing itself is realtime-safe.HarmonyPeriodContinuity.hpolicy: 1–2 large F0 period outliers are ignored, 3 consistent analyses admit a real new period, and source-period motion is capped at 11% per analysis hop withoutpitchSync_.reset(). Small genuine vibrato continues using the existing bounded 5% / 0.30 rate logic.Admission plan
This is a focused DSP-only draft stacked on #529 and not on production main. Run portable CI first; then merge only to #529 candidate after evidence. Use the new scoped Windows FAT once per qualified source SHA; no Windows churn for speculative edits. Real singer A/B and physical ASIO XRUN remain open. Do not interpret synthetic pass as zero crackle in a live vocalist.