Skip to content

Fix P0: true DAW FX insert drag, atomic realtime order, flat fader recess & single-instance - #102

Closed
masarray wants to merge 43 commits into
mainfrom
fix/p0-daw-drag-flat-fader-single-instance-20261028
Closed

masarray wants to merge 43 commits into
mainfrom
fix/p0-daw-drag-flat-fader-single-instance-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

Corrective action for user 2026-10-28 screenshot and K500 Mass Upload UX reference

Supersedes visual-only PR #99 / #97 approach; refs #95, #56, #15.

FX Rack / native JUCE

  • Six identical insert slots per MIX channel and MASTER; all unused rows say + ADD FX, never em-dash placeholders.
  • CH1 displays the actual native plugin names and bypass states, with remaining slots always ADD FX (also when no VST loaded). Other channels/master remain clearly non-routed and do NOT fabricate DSP.
  • Real pointer-held DAW drag ghost follows mouse, 2px insertion position marker, threshold/cancel/out-of-target handling. Single fxMove command at drop; keyboard arrow buttons remain. Idle mouse has no new pointermove listeners.
  • Engine uses x64 atomic 64-bit packed logical order. Callback reads one immutable order snapshot per buffer, never detaches/re-attaches audio for MOVE, nor moves/destroys VST3 objects. Existing Orbit and plugin editor objects retained and slot maps/bypass/timing/state serialization follow logical order. ADD/REMOVE remain separate guarded lifecycle.

Hardware UI & startup

  • Uniform 46px flat dark fader recess with four physical bevel edges on CH1–10 and MASTER; independent central 5px slot, unchanged 36×77 thumb art, calibrated 38px detent and gain/meter rulers, no blur/gradients on bed.
  • Lime-olive selected toolbar remains BTN-180 #b9cf77.
  • JUCE enforces one running app instance and raises previous main window on repeated EXE launch, avoiding competing WebView2/device sessions; this does not prove all causes of Windows freezes have been isolated.

Tests / gates

  • Pure C++ FxOrderPlan covers all from/to/count permutations and a 20k-message publication/load stress; wired into existing CTest Windows workflow.
  • Node regression exercises real preview move function with linked metadata+bypass and checks drag/native/visual contracts; wired into Windows and Chromium jobs. Existing live-graph test updates expected MOVE semantics.
  • Generated CSS, embedded standalone HTML+JS source parity verified.
  • No hardware stability/latency certification before Windows build, Playwright, and physical ASIO/WASAPI test. No claim CH2–10 MASTER has independent DSP yet (later P1–P3).

Copy link
Copy Markdown
Owner Author

Follow-up GUI and DSP audit (2026-10-28)

  • FX slot-attached native picker CSS explicitly scoped to #nativeFxSelector; no full-screen dimming, no blur, 386px max width, flipped pointer arrow, selected slot outline; six insert choices remain consistent.
  • Disabled native ADD action for CH2–10/MASTER until real per-channel source routing/DSP exists. Catalogue visibility never implies audio is processed.
  • Reworked milled fader trough again: flat #24333b graphite interior, four subtle inset folds, curved radius, no bright outer rectangular border, fixed 46px for MASTER + CH1–10. Source/compiled/offline CSS regenerated.
  • Existing branch already contains Material bin right-click removal, Orbit-highlighted active plugin, FX reorder ghost, and block-boundary fade. Audibly clean drops across vendor VST3s and 10 real DSP channels are NOT certified by this PR. They need real hardware verification and follow-on multi-channel graph work (ARD: All-channel native FX Rack + safe drag reorder + yellow-green toolbar + recessed fader #95).
  • CI pending for latest head.

Copy link
Copy Markdown
Owner Author

Cross-thread reconciliation — 2026-10-28 (PR #107)

main advanced to 20222c6 (meter PR #106 merged). A separate P0 PR #107 fixes FX ON/OFF crackle with RT-owned per-physical-slot de-click envelopes in src/LiveAudioEngine.h, plus unit/Windows CTest. Your PR #102 changes this same file and is currently non-mergeable. Do not force-merge/reuse older Main/GUI code. Rebase #102 onto latest main after #107 integrates, preserve Graph::bypassEnvelope[physicalIndex] and make FxOrderPlan use the physical index for FX processing, requested bypass flags, and envelope/timer state. During materializeOrderOnStoppedCallback, reset/migrate envelope consistently with the processor identity. Test 0-latency bypass crossfade, latency-bearing fade-through-zero, atomic FX MOVE while Orbit is running, and ADD/REMOVE separately. Handoff: docs/ARSONMIX_CROSS_THREAD_HANDOFF_20261028.md in PR #107. PR #105 Orbit/POLAR and approved GUI must remain unchanged.

Copy link
Copy Markdown
Owner Author

Reconciliation 2026-10-28: this draft PR is currently mergeable_state=dirty against advanced main (PR #105/other ongoing changes). Do NOT force-merge or wholesale copy its UI and real-time engine changes. The isolated P1A ten-channel source-routing DSP foundation is now in draft PR #108, based on a clean main, with separate tests. PR #102 still needs deliberate conflict resolution and live FX drag hardware click/crackle A/B qualification; the existing 0-FX issue #15 remains open.

Copy link
Copy Markdown
Owner Author

Update: P0 bypass de-click is now MERGED in main — PR #107 -> c0d7c794a27fcdc7adbe77c6166a2e97b848b82c (source-tree identical to Windows/Chromium PASS run). PR #102 is still unmergeable against main. Rebase this DAW drag/reorder PR on c0d7c79 and preserve Graph::bypassEnvelope + dry scratch + realtime per-physical-slot transition. In MOVE DSP loop, use physical for slots, bypassFlags, bypassEnvelope; reset/migrate envelopes when physical slots are materialized during callback detach. Verify test P0FXBypassSampleAccurateDeClick alongside FxOrderPlan/MOVE CTests. Leave dearVR Orbit/POLAR and approved GUI/meter unchanged. This is the latest authority, superseding older comments.

Copy link
Copy Markdown
Owner Author

Current baseline sync · 2026-10-28. Main remains c0d7c79 including #107 FX ON/OFF sample-level de-click, #106 meter, #105 dearVR Orbit/POLAR. This DAW reorder PR is still draft and reports merge conflicts. It must be rebased/reconciled by logic, not copied as a stale LiveAudioEngine.h replacement. Atomic logical-to-physical order must use the physical processor index for bypassEnvelope, bypassFlags, processor metadata, preset state, and Orbit target; preserve transition history on MOVE, valid reset/rebind on structural ADD/REMOVE, and test rapid ON/OFF while MOVE runs. Do not touch approved GUI/reverb/Orbit beyond narrowly necessary conflict resolution. Release CTest P0FXBypassSampleAccurateDeClick and your FX order/move tests required before merge. Stacked routing PRs #108/#110/#111 are independent pure-plan work and not a reason to declare live multichannel processing finished.

Copy link
Copy Markdown
Owner Author

Cross-thread merge warning (2026-10-28): latest main@4951f3b now contains merged ten-channel P1D #114, pre-fader/DAG correction #118 and Studio Backup P3 #116. P1E #119 adds native opt-in DRY physical input routing and guarded FX/preset/clock operations in src/LiveAudioEngine.h, src/Main.cpp, monitor UI and CI. This #102 FX drag branch still has an old base and conflicts in the SAME LiveAudioEngine/Main/GUI/CI paths. Please reconcile cherry-pick-by-function onto latest main when integrating FX drag; NEVER replace whole engine/Main or overwrite dry routing guards, sample-accurate bypass, Orbit, portable backup or approved GUI. P1E is test-lab only (no competing plugin chain).

masarray added a commit that referenced this pull request Oct 28, 2026
…ASTER (#120)

Restore requested full-height fader rail recess visually, using only reviewed CSS from stale PR #102; no old audio graph/FX reorder cherry-pick. Graphite smooth four-sided metal lips, narrow 5px slit, no glowing white rectangular frame, no blur/gradients/motion, bounded 46px to avoid meter/ruler collision. Preserve exact 36x77 thumb art, 38px travel detent, real VU ballistics, channel/master alignment, latest Orbit, portable Studio and 10CH routing work. Source-owned CSS and embedded standalone HTML synchronized. Exact-head Chromium CSS ownership parity, original fader asset verification and computed-style validation across all 11 faders PASS; no unresolved reviews. CI Windows executable to be packaged on main push.

Copy link
Copy Markdown
Owner Author

Superseded by merged #122 (main@15450e64d6fbb683150a624859a6351ca5ad2c34). Its verified DAW ghost drag, atomic physical-slot FX order, popup/Orbit marker, and single-instance safeguards were selectively ported onto current main while preserving PR #107 sample-accurate bypass, #106 meter easing, #120 folded-metal fader, #116 backup and #121 dry-routing LAB. DO NOT merge this stale branch wholesale. Branch/commits remain accessible as history; latest main has passing exact-head Windows MSVC/CTest + Chromium in #122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant