Skip to content

Commit 61b2971

Browse files
authored
P0 GUI: restore physical folded-metal fader track recess for 10CH + MASTER (#120)
Restore requested full-height fader rail recess visually, using only reviewed CSS from stale PR #102; no old audio graph/FX reorder cherry-pick. Graphite smooth four-sided metal lips, narrow 5px slit, no glowing white rectangular frame, no blur/gradients/motion, bounded 46px to avoid meter/ruler collision. Preserve exact 36x77 thumb art, 38px travel detent, real VU ballistics, channel/master alignment, latest Orbit, portable Studio and 10CH routing work. Source-owned CSS and embedded standalone HTML synchronized. Exact-head Chromium CSS ownership parity, original fader asset verification and computed-style validation across all 11 faders PASS; no unresolved reviews. CI Windows executable to be packaged on main push.
1 parent 4951f3b commit 61b2971

5 files changed

Lines changed: 124 additions & 0 deletions

File tree

‎AR-MIX-Live-FX-Host-Standalone-v0.3.html‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1143,6 +1143,35 @@
11431143
}
11441144
/* LED increments stay fixed and the meter keeps its native dBFS conversion.
11451145
No hot-path DOM reads, filters, blur or per-frame scale animation. */
1146+
1147+
/* P0 FADER BED RECOVERY, main-aligned from PR #102 (visual CSS ONLY).
1148+
Full-height smooth graphite metal folds; zero white rectangular border.
1149+
No blur, gradients, interactive filters, animation or pointer listeners.
1150+
Recess width is bounded to the actual rail so CH1-10/MASTER VU and rulers
1151+
remain unobstructed on narrower displays. 36×77 PNG and 38px detent kept. */
1152+
#app #mixer .fader-zone .fader{
1153+
position:relative;isolation:isolate;min-width:36px;
1154+
background:transparent!important;border:0!important;box-shadow:none!important;
1155+
}
1156+
#app #mixer .fader-zone .fader::before{
1157+
content:"";position:absolute;top:0;bottom:0;left:50%;
1158+
width:min(46px,100%);transform:translateX(-50%);
1159+
z-index:0;pointer-events:none;box-sizing:border-box;
1160+
background:#26343c;border:0;border-radius:6px;
1161+
box-shadow:
1162+
inset 0 4px 4px -3px #070e13,
1163+
inset 0 -4px 4px -3px #070e13,
1164+
inset 4px 0 5px -4px #081116,
1165+
inset -4px 0 5px -4px #081116;
1166+
}
1167+
#app #mixer .fader-zone .fader::after{
1168+
content:"";position:absolute;left:50%;top:38px;bottom:39px;
1169+
width:5px;transform:translateX(-50%);
1170+
z-index:0;pointer-events:none;
1171+
background:#05090c;border:0;
1172+
box-shadow:inset 1px 0 #34434b,inset -1px 0 #34434b;
1173+
}
1174+
#app #mixer .fader-zone .fader-travel{z-index:1}
11461175
</style></head>
11471176
<body>
11481177
<div id="app" class="app">

‎tests/fader_asset_test.py‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,22 @@
7575
assert 'fader-tools master-tools' not in js
7676
assert 'masterMono' in js
7777
assert 'class="btn-180 master-mode' in js
78+
79+
# P0 physical recess is source-owned, not merely present in a stale screenshot.
80+
# These selectors must be last so the old narrow line can't override the bay.
81+
for marker in (
82+
"P0 FADER BED RECOVERY",
83+
"width:min(46px,100%)",
84+
"background:#26343c;border:0;border-radius:6px",
85+
"inset 0 4px 4px -3px #070e13",
86+
"inset 0 -4px 4px -3px #070e13",
87+
"inset 4px 0 5px -4px #081116",
88+
"inset -4px 0 5px -4px #081116",
89+
"width:5px;transform:translateX(-50%)",
90+
"#app #mixer .fader-zone .fader-travel{z-index:1}",
91+
):
92+
assert marker in finish, "Latest fader recess lost from source: "+marker
93+
assert "backdrop-filter" not in finish.split("P0 FADER BED RECOVERY",1)[1]
94+
assert "filter:" not in finish.split("P0 FADER BED RECOVERY",1)[1]
95+
7896
print("PASS: rose-gold MASTER, 10 channels, button mode/clip layout, offline parity")

‎tests/ui_smoke.py‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -563,6 +563,25 @@ def same_rect(a,b):
563563
assert len(geometry)==11 and all(x['nameTop']>=x['faderBottom']-1 for x in geometry),geometry
564564
assert all(not x['hasTools'] for x in geometry if not x['master']),geometry
565565
assert not any(x['hasTools'] for x in geometry),geometry
566+
# Fader rail must be an actual smooth bent-metal recess (not old slit-only
567+
# or a bright white rectangular frame); checked for all 10 + MASTER
568+
# in the Browser before approving the Windows distribution.
569+
fader_recess=await page.evaluate("""() => [...document.querySelectorAll('#mixer [data-fader]')].map(f=>{
570+
const bay=getComputedStyle(f,'::before'),slit=getComputedStyle(f,'::after');
571+
const rail=f.getBoundingClientRect(),cap=f.querySelector('.cap');
572+
return {id:f.dataset.fader,rail:rail.width,bay:parseFloat(bay.width),
573+
fill:bay.backgroundColor,edge:bay.boxShadow,border:bay.borderTopWidth,
574+
top:bay.top,bottom:bay.bottom,slit:parseFloat(slit.width),
575+
slitColor:slit.backgroundColor,capWidth:cap.getBoundingClientRect().width};
576+
})""")
577+
assert len(fader_recess)==11,fader_recess
578+
assert all(x['bay']>=30 and x['bay']<=46.1 and x['bay']<=x['rail']+.1
579+
and x['fill']=='rgb(38, 52, 60)' and x['border']=='0px'
580+
and 'inset' in x['edge'] and x['top']=='0px'
581+
and x['bottom']=='0px' and x['slit']==5
582+
and x['slitColor']=='rgb(5, 9, 12)' and x['capWidth']==36
583+
for x in fader_recess),fader_recess
584+
566585
# Both resting states share depth; while pointer is down only, cap sinks 1px
567586
# with a stronger inner shadow and unchanged width/height/layout slot.
568587
btn=page.locator('[data-mute="0"]')

‎web/styles-src/42-mixer-premium.css‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,3 +183,32 @@ html:not([data-mixperf="baseline"]):not([data-mixperf="layers-off"]):not([data-m
183183
}
184184
/* LED increments stay fixed and the meter keeps its native dBFS conversion.
185185
No hot-path DOM reads, filters, blur or per-frame scale animation. */
186+
187+
/* P0 FADER BED RECOVERY, main-aligned from PR #102 (visual CSS ONLY).
188+
Full-height smooth graphite metal folds; zero white rectangular border.
189+
No blur, gradients, interactive filters, animation or pointer listeners.
190+
Recess width is bounded to the actual rail so CH1-10/MASTER VU and rulers
191+
remain unobstructed on narrower displays. 36×77 PNG and 38px detent kept. */
192+
#app #mixer .fader-zone .fader{
193+
position:relative;isolation:isolate;min-width:36px;
194+
background:transparent!important;border:0!important;box-shadow:none!important;
195+
}
196+
#app #mixer .fader-zone .fader::before{
197+
content:"";position:absolute;top:0;bottom:0;left:50%;
198+
width:min(46px,100%);transform:translateX(-50%);
199+
z-index:0;pointer-events:none;box-sizing:border-box;
200+
background:#26343c;border:0;border-radius:6px;
201+
box-shadow:
202+
inset 0 4px 4px -3px #070e13,
203+
inset 0 -4px 4px -3px #070e13,
204+
inset 4px 0 5px -4px #081116,
205+
inset -4px 0 5px -4px #081116;
206+
}
207+
#app #mixer .fader-zone .fader::after{
208+
content:"";position:absolute;left:50%;top:38px;bottom:39px;
209+
width:5px;transform:translateX(-50%);
210+
z-index:0;pointer-events:none;
211+
background:#05090c;border:0;
212+
box-shadow:inset 1px 0 #34434b,inset -1px 0 #34434b;
213+
}
214+
#app #mixer .fader-zone .fader-travel{z-index:1}

‎web/styles.css‎

Lines changed: 29 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)