Skip to content

ci: lean native/GUI gates, single release artifact and stale-safe Pages - #101

Merged
masarray merged 1 commit into
mainfrom
ci/lean-single-fat-artifact-20261028
Oct 27, 2026
Merged

masarray merged 1 commit into
mainfrom
ci/lean-single-fat-artifact-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

Motivation

Recent ArSonMix PR history shows Windows Release MSVC and both Chromium+Firefox executing for every iterative PR, including GUI-only changes. Subsequent Pages deployment is appropriately gated on a successful main UI run but can enqueue obsolete revisions. Avoid burning Windows runners or waiting on unneeded browser installs while preserving the one verified Windows FAT artifact.

Changes

  • Windows Native VST3 Host: only main runtime/native inputs trigger a release build (including shipped web/**); PR runs when changes can affect native JUCE/engine, CMake, Windows packaging or native test contracts. Remove ancient named-branch push triggers. PR still performs Release MSVC, CTest, packaging and independent ZIP provenance audit, but no automatic artifact upload. workflow_dispatch explicitly builds+uploads FAT for a branch. main produces one verified ZIP after merge.
  • UI Chromium: gate PRs by relevant GUI/asset/UI-test paths; add cancellable per-PR/main concurrency. Run Chromium each relevant PR. Download/run heavier Firefox performance smoke only on main or manual dispatch; retain manual route for premerge targeted performance FAT. Keep screenshots 3 days.
  • Pages: retain existing single qualified publisher. Only successful main push UI runs may auto-publish. Resolve checked-out qualified SHA against current main before building/deploying; obsolete queued publishers skip cleanly. Do not introduce competing deploy workflows.
  • New Node contract tests and detailed docs/CI_WORKFLOW_STRATEGY_20261028.md describe expected behavior and required-check caveat. No modifications to DSP, GUI, Orbit or release packaging scripts.

Verification gates

  • Check UI smoke (includes CI policy Node regression) and Windows MSVC Release/CTest. Merge only if green.
  • After merge check main Windows uploads exactly one verified artifact and Pages publishes only successful non-superseded main UI revision.
  • Note: if branch-protection required status checks include Windows on all PRs, update required-check policy to reflect path-filtered workflows; this connector cannot change repo administration rules.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-27T20:24:51.422748Z 108e281 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Cross-thread synchronization (2026-10-28): approved source main now includes Orbit/POLAR PR #105 and meter ballistics PR #106 (20222c6), and PR #107 is validating a zero-added-latency FX bypass de-click. Please reconcile this lean-CI PR with the then-current main before merging; do not reintroduce branch push duplicates or extra Windows artifact producers. One Windows Release+CTest+verified ZIP artifact pipeline is the authoritative native gate. Confirm required status-check rules match path-filtered workflow triggers before changing PR filters. Handoff: docs/ARSONMIX_CROSS_THREAD_HANDOFF_20261028.md (PR #107). No GUI/Orbit/DSP implementation should be copied from the older CI PR.

Copy link
Copy Markdown
Owner Author

Update (2026-10-28): main is now c0d7c79, with meter #106 and audio FX bypass de-click #107 merged. Continue lean-CI implementation based on this head rather than older hashes. PR #101 remains independent/open. Audit required checks before path-filtered native/GUI triggers, and preserve the single verified Windows artifact workflow and new ARMixFxBypassEnvelopeTests target when reconciling.

Copy link
Copy Markdown
Owner Author

CI sync · 2026-10-28. Main at c0d7c79 now includes new Windows target ARMixFxBypassEnvelopeTests and PASS de-click CTest. Routing stack #108/#110/#111 and GUI PR #102 are in flight. Reconcile CMakeLists.txt, status-check policy and current p1-windows.yml before merging lean CI. The single Windows Release + CTest + independent ZIP audit must retain all newly introduced native test targets; protect required checks against path-filtered skipped workflows. Avoid extra Windows packaging producers, and prefer one verified main artifact or explicit manual FAT per needed SHA, not one download per intermediate stack commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant