Repository navigation
P1F–P1G: native 10-channel BUS/Pre-Post sends + verified JUCE ports and live meter - #123
Merged
masarray merged 21 commits intoOct 28, 2026
Merged
Conversation
…-to-callback mapping
…d no partial publication
…mixer graph to actual samples
… Windows workflow
…ative release gates
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
6 tasks
… sends, BUS return, per-channel meters and port mask attestation
…mute/solo/main and truthful channel peaks
…mmands and transactional rollback
…ted device restart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated P1F + P1G — real live 10-channel dry routing with native BUS/PRE/POST sends
Reconciled against current GUI main@3b327bd5f9513ad405122258665457eb8ee07e73 (merged FX drag, Orbit, meter, master/CH layout, backup, CI). This extends the already-live P1E Routing LAB rather than creating a second callback/audio engine. A conflict-safe two-parent reconciliation retains all main GUI edits.
Functional milestone (not just architectural primitives)
Scope / hardware truth
The LAB is real routed audio, still explicitly dry (zero VST3 FX chains). CH2–10 VST3, output bus hardware routing, PDC/sidechain, portable performance recall, source selector in main mixer, and zero-FX crackle #15 are not marked completed. Labs require user to mute output before APPLY and headphone monitoring low volume. Do not claim CI alone qualifies hardware latency/click-free performance.
Compatibility
The previous PR #123 (P1F only) passed Windows CI as of 6a17a51. The new P1G changes are unverified until the fresh exact-head CI completes. Full engineer FAT guide. Refs #109 #95 #15 #85.