Skip to content

P1F–P1G: native 10-channel BUS/Pre-Post sends + verified JUCE ports and live meter - #123

Merged
masarray merged 21 commits into
mainfrom
feature/p1f-juce-portmask-bound-session-20261028
Oct 28, 2026
Merged

masarray merged 21 commits into
mainfrom
feature/p1f-juce-portmask-bound-session-20261028

Conversation

@masarray

@masarray masarray commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Integrated P1F + P1G — real live 10-channel dry routing with native BUS/PRE/POST sends

Reconciled against current GUI main@3b327bd5f9513ad405122258665457eb8ee07e73 (merged FX drag, Orbit, meter, master/CH layout, backup, CI). This extends the already-live P1E Routing LAB rather than creating a second callback/audio engine. A conflict-safe two-parent reconciliation retains all main GUI edits.

Functional milestone (not just architectural primitives)

  • Real JUCE active input and output port-mask attestation, including non-contiguous physical inputs; reject disconnected/reconfigured devices and swapped callback channel counts. Input/output topology fault is latched until device restart. No implicit activation of inactive hardware pins.
  • Native Routing LAB: 10 independent physical MONO/STEREO or virtual stereo BUS return lanes; up to 32 concurrent internal PRE/POST-fader sends, DAG validation (reject self-feedback/cycles/duplicate routes), MAIN direct toggle, mute and solo, per-source gain. Source with fader at zero remains audible via PRE send, but not POST. All routing prepared/validated and transactionally published with device epoch and revision ACK; invalid route leaves previous DSP unchanged.
  • Real post-fader channel peak telemetry from P1D audio vectors, no fabricated meter. Routing inspector adds BUS, MAIN, MUTE, SOLO and user-editable sends, with low-cost 12Hz text peaks and no blur, large canvases or duplicate timers. Existing approved console is not touched.
  • Preserves 256-sample transition ramps, single existing DRY routing callback, realtime graph ownership/quiescent retirement, emergency output MUTE, DirectFence, CH1 FX catalog/presets/Orbit, ASIO/Independent Clock diagnostics and 0-FX FAT path. No additional Windows CI matrix.
  • Adds NativeDryRouteCommand decoder and native CTest executing real PRE vs POST signal paths, BUS return, cycle rejection, invalid command and rollback. Existing P1F native JUCE port tests and UI contracts remain. Guard CI on exact-head Windows CTest and UI Chromium.

Scope / hardware truth

The LAB is real routed audio, still explicitly dry (zero VST3 FX chains). CH2–10 VST3, output bus hardware routing, PDC/sidechain, portable performance recall, source selector in main mixer, and zero-FX crackle #15 are not marked completed. Labs require user to mute output before APPLY and headphone monitoring low volume. Do not claim CI alone qualifies hardware latency/click-free performance.

Compatibility

The previous PR #123 (P1F only) passed Windows CI as of 6a17a51. The new P1G changes are unverified until the fresh exact-head CI completes. Full engineer FAT guide. Refs #109 #95 #15 #85.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T04:05:45.525465Z 6a17a51 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray masarray changed the title P1F: bind real JUCE active port masks to revision-safe 10-channel native DSP session P1F–P1G: native 10-channel BUS/Pre-Post sends + verified JUCE ports and live meter Oct 28, 2026
@masarray
masarray merged commit 240b901 into main Oct 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant