Repository navigation
P1D: integrated 10-channel physical routing, MONO/ST, FX returns, sends and master DSP - #114
Conversation
… FX return and master DSP into current main baseline
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Concurrent-main reconciliation completed (2026-10-28): |
Major milestone: complete prepared 10-channel DSP graph, reconciled against current main
Consolidates the working P1A #108 + P1B #110 + P1C #111 source/routing/sends foundations and actually executes them together as a physical-input → channel FX seam → pre/post-fader sends → internal returns → stereo master DSP engine.
Implementation:
engine/core/PreparedMixerBlock.h, four source headers, four executable C++ tests, the existing CMake/Windows CI and full P1A–D design/acceptance documentation.End-to-end test uses physical mono/stereo inputs in intentionally sparse callback order, simultaneous channel FX hooks, pre-fader return with fader zero, post-fader output, internal FX returns with no physical input, realtime SOLO closure, MUTE, mono fold-down, master peaks, 1000 block renders and a global new-counter assertion for zero callback allocations. Uses Windows Release assertion-safe tests (NDEBUG override). No thread-per-strip.
Current-main reconciliation: branch derived from
main@c0d7c794a27fcdc7adbe77c6166a2e97b848b82c; native codesrc/LiveAudioEngine.h, JUCE device paths, GUI/Orbit and FX bypass remain intact. CMake/CI are extended using narrow inserts, not copied from older feature branches, preserving all P0 targets.Safety: This is a real, reusable, device-independent DSP block, NOT activated in current Windows audio callback. CH2–10 VST3 and SOURCE GUI are still not live. Hardware crackle #15 remains a release-blocking issue. The next phase is verified physical-port negotiation, per-strip plugin instance bus-layout handling, device/graph epochs and RT-safe graph publisher/ACK; only then activate GUI with real native meters. Do NOT claim software test == hardware qualification.
Merge gate: exact-head Windows Native CTest plus Chromium smoke success, review actual outputs and no current-main drift. This integration PR supersedes duplicated stacked source PR changes, but parent PRs must be explicitly reconciled on merge; do not merge duplicates or overwrite #102 FX drag.
Refs #109 #95 #15 #85 #108 #110 #111. Full architecture & FAT plan.