Skip to content

P1D: integrated 10-channel physical routing, MONO/ST, FX returns, sends and master DSP - #114

Merged
masarray merged 2 commits into
mainfrom
integration/p1d-multichannel-render-validated-20261028
Oct 27, 2026
Merged

masarray merged 2 commits into
mainfrom
integration/p1d-multichannel-render-validated-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

Major milestone: complete prepared 10-channel DSP graph, reconciled against current main

Consolidates the working P1A #108 + P1B #110 + P1C #111 source/routing/sends foundations and actually executes them together as a physical-input → channel FX seam → pre/post-fader sends → internal returns → stereo master DSP engine.

Implementation: engine/core/PreparedMixerBlock.h, four source headers, four executable C++ tests, the existing CMake/Windows CI and full P1A–D design/acceptance documentation.

End-to-end test uses physical mono/stereo inputs in intentionally sparse callback order, simultaneous channel FX hooks, pre-fader return with fader zero, post-fader output, internal FX returns with no physical input, realtime SOLO closure, MUTE, mono fold-down, master peaks, 1000 block renders and a global new-counter assertion for zero callback allocations. Uses Windows Release assertion-safe tests (NDEBUG override). No thread-per-strip.

Current-main reconciliation: branch derived from main@c0d7c794a27fcdc7adbe77c6166a2e97b848b82c; native code src/LiveAudioEngine.h, JUCE device paths, GUI/Orbit and FX bypass remain intact. CMake/CI are extended using narrow inserts, not copied from older feature branches, preserving all P0 targets.

Safety: This is a real, reusable, device-independent DSP block, NOT activated in current Windows audio callback. CH2–10 VST3 and SOURCE GUI are still not live. Hardware crackle #15 remains a release-blocking issue. The next phase is verified physical-port negotiation, per-strip plugin instance bus-layout handling, device/graph epochs and RT-safe graph publisher/ACK; only then activate GUI with real native meters. Do NOT claim software test == hardware qualification.

Merge gate: exact-head Windows Native CTest plus Chromium smoke success, review actual outputs and no current-main drift. This integration PR supersedes duplicated stacked source PR changes, but parent PRs must be explicitly reconciled on merge; do not merge duplicates or overwrite #102 FX drag.

Refs #109 #95 #15 #85 #108 #110 #111. Full architecture & FAT plan.

… FX return and master DSP into current main baseline
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T23:34:40.112959Z 3a047ce PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Concurrent-main reconciliation completed (2026-10-28): main advanced to 66989fa by merged lean-CI PR #101 while the initial P1D build was compiling. I created merge commit d18c2d6 with both the prior P1D head and new main as parents; its tree preserves #101's paths-aware CI, upload policy, Pages/Chromium workflow changes, and all P0 runtime code. Only the four routing CTest targets were added to the updated Windows build command. PR is now clean against latest main. Fresh exact-head Windows CI: https://github.com/masarray/arsonmix/actions/runs/40603684568. Do not merge until this run is green; old run is now stale. SOURCE/Mono/Stereo GUI controls and native CH2–10 remain disabled until real hardware callback/port-mask/graph lifecycle and #15 FAT are addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant