Skip to content

P1C: runnable 10-strip + 2-AUX offline DSP routing graph with cycle-proof sends - #117

Closed
masarray wants to merge 2 commits into
feature/p1b-mono-stereo-port-contract-20261028from
feature/p1c-prepared-aux-send-graph-20261028
Closed

masarray wants to merge 2 commits into
feature/p1b-mono-stereo-port-contract-20261028from
feature/p1c-prepared-aux-send-graph-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

Meaningful milestone

Adds PreparedBusGraph.h: a genuine block-processing DSP engine for ten native-source strips and two auxiliary buses. Supports sparse physical mono/stereo input mapping, strip-to-strip input, strip-to-AUX sends, AUX return-to-MAIN, explicit main routing, mute, per-node gain and a prepared FX processing callable. The route compiler validates every edge and builds deterministic topological execution order; feedback cycles and missing device ports reject the entire candidate plan without mutating the live-safe previous plan. Preallocated scratch; no RT allocation/lock/IO/device management.

Adds deterministic audio-vector CTest for mixing, auxiliary FX, channel cross-feed, cycle rejection, failure rollback, missing physical ports and repeat-block consistency; builds the test target in existing Windows Native CI.

Important boundaries

This is functional hardware-independent DSP, not yet JUCE callback activation or physically tested audio. The provided processing hook is not VST3 lifecycle integration; native FX ownership, safe graph swap and input/output device masks are remaining gates. No source selector GUI is enabled, no claim of ASIO click-free switching, #15 hardware crackle still unqualified. Preserve #102 and current approved GUI.

Stack

PR #108 (P1A) → #110 (P1B) → this P1C PR. Do not merge to main until earlier stacked PRs pass and are merged in order, exact-head CI passes, and final integration is reconciled with latest main. Refs #109 #95 #15.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T23:47:20.192502Z a694e97 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a694e97dc3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}
for(int i=0;i<frames;++i){l[i]+=addLeft_[n][i];r[i]+=addRight_[n][i];}
insert(n,l,r,frames);
if(x.mute)continue;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear muted node buffers before downstream routes read them

When a muted node is the source of a RouteKind::strip or RouteKind::aux route, continue skips its direct MAIN/send contributions but leaves its processed audio in left_/right_. The downstream node then copies those buffers and makes the muted signal audible again. A compiled graph with muted mono node 0 feeding node 1 produces nonzero MAIN output. Clear the muted node's output buffers before continuing so all downstream routes observe silence.

Useful? React with 👍 / 👎.

for(int i=0;i<frames;++i){l[i]+=addLeft_[n][i];r[i]+=addRight_[n][i];}
insert(n,l,r,frames);
if(x.mute)continue;
for(int i=0;i<frames;++i){l[i]*=x.level;r[i]*=x.level;}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply the compiled channel fader and pan coefficients

When callers set fader or pan through RouteSetup.channels.stripsAndMaster, compilation retains those settings and computes device.base.strips[n].leftGain/rightGain, but processing never applies them: extraction supplies raw samples and this loop applies only RouteNode.level. For example, a mono input of 1 with channel fader 0.25 and pan -1 renders (1, 1) instead of (0.25, 0). This also bypasses the existing default equal-power mono pan law. Apply the compiled channel coefficients at the appropriate post-insert routing stage rather than silently ignoring the accepted channel controls.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Cross-thread authoritative baseline (2026-10-28): main@4951f3b already contains P1D integrated 10-strip DSP from merged #114, Studio Backup P3 from #116, and pre-fader/DAG corrections from #118. New P1E PR #119 advances to opt-in real JUCE callback DRY 10-input routing with device epoch/revision, native GUI ACK, fail-closed stale device and real Windows FAT operator flow. #102 FX drag remains pending/isolated. Please do not bulk merge older stacked P1A/B/C/D routing code over main or treat isolated offline FX hooks as live per-strip VST3. Reconcile any improvements as small tested deltas on current main. P1E Windows native CI is being verified; #15 zero-VST crackle still requires physical FAT, not inferred from CI.

Copy link
Copy Markdown
Owner Author

Architecture reconciliation — superseded, closing without merge. Old 10-strip/2-AUX offline PreparedBusGraph implementation is superseded by current prepared 10CH+4AUX and dynamic PCM+VST migration work. Its branch was stacked on an obsolete base; archive unique tests, do not overwrite native accepted M4.

Canonical PRD v5 / ARD v5. Active native graph #266, operator UI #265, issue #192. This historic branch/commit remains available for selective reference; no source deletion and no loss-of-working-audio merge.

@masarray masarray closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant