Skip to content

[MS1 P0] True native MONO↔STEREO channel format independent of physical input — end-to-end DSP + GUI #173

Closed as duplicate

Description

@masarray

R6 CURRENT EXECUTION / L2 PRESERVATION — 2026-10-30: Code-audited architecture and priorities · Operator GUI contract · Merged PR #181 · UX implementation #182 · L2 immutable GUI #176. Source baseline main@8251bd6 (re-fetch HEAD before editing): G3 and L2 merged; channelFormat MS1 #173, typed bus MS2 #174, independent hardware outputs MS3 #175 and uniform FX/PDC #95 are NOT completed. #15 real zero-FX audio hardware blocker remains unresolved. Protect ONE seven-row grid and fader alignment for CH1–10+MASTER, FX/ROUTE/SENDS left rail, top MIXER/FX RACK/PATCH, CH1 VST+Orbit, native epoch/revision ACK/MUTE. No old PR bulk-merge, fake Master FX/monitor pins or GUI-only LIVE.

Goal — meaningful vertical release, not a checkbox

Deliver live independently switchable MONO/STEREO processing channel format, including NONE and BUS-receiving channels, regardless of whether the physical source consumes 0, 1 or 2 capture pins. Product owner explicitly requests DAW-like format flips. Implement native signal behavior, controller/ACK, GUI and exact-head artifact together. This issue is NEW work, not the already delivered source Mono/Stereo input selector in #109.

Canonical requirements: ADR R5 / R5 Execution Handoff / product epic #170. Audited baseline main@890cc310 has ChannelRoutingContract ChannelFormat + foldStereoToMono but live NativeDryRouteCommand forces source mode=channel mode, BUS always stereo; input stereo-pair shortcut assumes adjacent; legacy app.js preview format tied to strip indices.

Done only when

  • v2 typed input source kind/format and independent channelFormat implemented with backwards-compatible NativeDryRouteCommand/Show migration; maintain stable channel identity, previous physical R assignment and vendor FX state.
  • Real processing for MONO physical→MONO channel, MONO physical→STEREO channel via deliberate projection (no fabricated R), STEREO physical L/R→STEREO channel, STEREO physical→MONO channel with once-only 0.5(L+R) fold.
  • Mono equal-power panning and stereo balance proven at DSP sample level; no unintentional +6dB or duplicated capture.
  • Stereo patch accepts two different, independently valid nonadjacent enabled physical input ports; sparse masks, same-pin and stale device epoch validations are enforced.
  • BUS receiver may be mono/stereo even without physical input; NONE retains declared channel format and remains silent until a source is accepted.
  • MIX selected-channel M / L·R format badge, distinct source selector, native DRAFT→MUTED APPLY→ACK→LIVE/REJECTED; existing fader, mute, meter, FX Rack, Orbit remain mounted.
  • Incompatible VST layout rejected or explicit proven adapter; preserve CH1 vendor multi-insert/Orbit and no callback plugin lifecycle operations.
  • Deterministic MS01–MS07, MS10–MS12 and MS15 tests in ADR plus negative ACK/rollback and 20× FX/ROUTE/SENDS navigation. One Windows CTest+Chromium/ZIP on exact head once local tests green.
  • Real hardware FAT instructions; P0 — Crackling with 0 VST3: diagnose WASAPI clock/input/output buffering before engine expansion #15 remains open until actual 0-VST crackle is qualified. Do not advertise "production ready" from CI.

Owner / collision prevention

Native control & DSP: ChannelRoutingContract.h, NativeDryRouteCommand.h, PreparedMixerBlock.h, LiveDryRoutingLab.h. GUI: mixer-io.js, monitor.js; bridge.js and app.js only with explicit compatibility review. Extends #109, not a competing routing engine. Exactly ONE prepared graph, no new callback, zero allocation/locks/JSON inside callback. Start from fresh main; no old #115/#117/#128 bulk merges.

Acceptance artifact: one full user-testable release with real mono↔stereo format, not tiny UI-only PRs.

Activity

  1. masarray commented on Oct 30, 2026

    @masarray
    OwnerAuthor

    MS1 IMPLEMENTATION (2026-10-30) — REAL CODE IN PR #184

    PR: #184
    Latest code HEAD: e76f5533e107e9bf5bf27a9ef97ce5be20b34df3, based on main@05d6fdc7. DRAFT pending Windows exact-head CTest/package.

    Delivered in branch (NOT yet merged)

    • NativeDryRouteCommand v2 typed sourceKind/sourceFormat/channelFormat with strict mismatch rejection, legacy v1 command/DRY Show decode retained.
    • Real LiveDryRoutingLab mono-physical→stereo-processing runtime equal-power pan-law fix; existing channel mono fold and sparse input pin routing used (no duplicate DSP graph).
    • Operator MIX and PATCH independent M/L·R channel-format selectors share the SAME muted native routing APPLY + ACK, no fake device or FX. L2 L2 GUI BASELINE LOCK — aligned CH1–10/MASTER faders, left-rail layers, three-tab workspace #176 11-strip fader track invariants preserved.
    • Native PCM test + negative decoder/old schema tests; native/UI ownership contract and Chromium multi-viewport ACK/revert, with generated standalone module CSS/JS parity.
    • Handoff: docs/MS1_NATIVE_CHANNEL_FORMAT_20261030.md on branch.

    Verified today

    Chromium 40982904966 SUCCESS, exact code head e76f5533. Initial UI run failed an existing approved PATCH select minimum-width requirement (75px vs 80px); corrected to 85px without moving L2 geometry. Windows MSVC/CTest/package 40982904925 is still executing. No release/merge/hardware qualification claim until green.

    Concurrency

    G5A #178 remains draft; this MS1 PR does NOT touch its FX graph, plugin-ui or bridge files. No stale PR bulk merge; once Windows GREEN, reconcile latest main, merge exact HEAD, and update AGENTS/README and issue status. #15 actual 0FX hardware crackle remains OPEN. Follow-up MS2 #174 owns typed MONO/STEREO AUX/GROUP conversion, PDC per #95 still pending.

  2. masarray commented on Oct 30, 2026

    @masarray
    OwnerAuthor

    MS1 code + CI MERGED and cross-thread protected (2026-10-30)

    PR #184 merged as 961c286d0f12e0f6223bb52251e67580922e4ca5; exact-head Chromium run 40984090092 SUCCESS and Windows MSVC/native RT CTest/package run 40984090111 SUCCESS. G5A #178 merged to main before MS1; no implementation file overlaps. Docs reconciliation main@aa9b9c810353ed78c3df941213c939432d486d26 writes an explicit next-thread required entry to AGENTS.md, README.md and the LV1/Studio Pro roadmap.

    Functional coding delivered: single native typed v2 sourceKind/sourceFormat/channelFormat control transaction + original fail-closed MUTE/APPLY/ACK; real independent mono-physical→stereo-processing and stereo-physical→mono 0.5 fold, mono/stereo BUS receiving and sparse pin validation via existing compiled native graph. UI exposes CH M/L·R independent source mode in MIX and PATCH without breaking L2 #176 11 fader alignment. Same renderer, no callbacks added. Native DRY Show snapshot V4 persists independent channel formats, migrates V2/V3, captures from accepted route and reconstructs typed v2 recall (tested with corrupt-file/rebind negative rollback). Original VST3 CH1/Orbit unaffected; G5A graph foundation preserved.

    Do not close this issue as hardware-FAT qualified yet: real 2×2 and sparse ASIO/WASAPI tests, plugin layout negotiation (future MS2/MS4) and actual 0FX crackle #15 remain independent validation gates; post-merge combined main CI also tracked separately. Full VST-equipped Show #180 and GROUP/mono AUX #174 are not part of MS1.

    Next real milestone: MS2 #174 format-aware FX AUX/GROUP typed DSP graph, then MS3 #175 verified physical output patch; G5B user FX/PDC through #95. Don't redevelop MS1 as a GUI-only task.

  3. masarray commented on Oct 31, 2026

    @masarray
    OwnerAuthor

    ISSUE RECONCILIATION (2026-11-01). Closed as duplicate/superseded (NOT a 'feature done' assertion). Native fixed-strip channel-format support was partly delivered by MS1; user-reported GUI mono/stereo/meter regression remains open in #265 and universal CH11 parity is still #192. Closing old partial milestone is NOT a declaration that regression is fixed.

    Single product/engine authority: PRD v5, ARD v5, #192. Physical audible quality: #15. This ticket's prior evidence remains searchable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions