Skip to content

P1D: prepared 10-strip dry execution — sparse inputs → FX tap → bus sends → MASTER - #115

Closed
masarray wants to merge 9 commits into
integration/p1abc-routing-core-main-20261028from
feature/p1d-prepared-mixer-executor-20261028
Closed

masarray wants to merge 9 commits into
integration/p1abc-routing-core-main-20261028from
feature/p1d-prepared-mixer-executor-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

Stacked follow-on milestone to #112 (P1A+B+C)

Implements PreparedMixerFlow.h, a coherent offline, allocation-free execution path across the already prepared physical-source, channel-format and send-DAG contracts. Its immutable compilation composes source identity, channel processing format, pre/post taps, solo/mute, internal bus returns and master output.

Specific engineering fixes

  • Inputless FX return with internal send audio really passes through master; it is not accidentally muted by a nonexistent physical source.
  • A source with fader at zero can drive PRE-fader sends, but POST taps cannot leak it; explicit pre-tap mute/solo policy.
  • Physical mono forced to stereo uses stereo unity balance, not unwanted mono -3dB law; forced stereo-to-mono follows the compiled mono law.
  • Missing native capture pins cannot wake orphan plugins and synthesize misleading output. Actual bus returns can keep processing tails.
  • Data flow strictly follows the checked acyclic topological schedule; an FX hook is invoked after physical/internal sum and before post-fader/send.
  • Fixed caller-owned per-block buffers, no heap, locks, trigonometry, or device restart on RT path. Not installed on live JUCE callback, no fake claim of CH2–10 FX.

Regression tests/CI

ARMixPreparedMixerFlowTests covers real synthetic stereo/mono vectors, sparse 3/9 port identity, 2-hop send, internal returns, pre/post effects, solo/mute, full block reset, source loss, invalid graph rollback and workspace frame limits. Integrated into existing Windows CMake/CTest and Release assertions.

Merge/integration order

Stacked on #112. First land #112 after exact-head Windows and GUI CI green; then retarget this PR onto current main and reverify all checks. Never merge older conflicted #108, #102 or overwrite #107 de-click. Hardware qualification #15 still blocks activating P2.6. Related #95 #109 #15.

See docs/P1D_PREPARED_MIXER_FLOW_20261028.md.

Copy link
Copy Markdown
Owner Author

Cross-thread authoritative baseline (2026-10-28): main@4951f3b already contains P1D integrated 10-strip DSP from merged #114, Studio Backup P3 from #116, and pre-fader/DAG corrections from #118. New P1E PR #119 advances to opt-in real JUCE callback DRY 10-input routing with device epoch/revision, native GUI ACK, fail-closed stale device and real Windows FAT operator flow. #102 FX drag remains pending/isolated. Please do not bulk merge older stacked P1A/B/C/D routing code over main or treat isolated offline FX hooks as live per-strip VST3. Reconcile any improvements as small tested deltas on current main. P1E Windows native CI is being verified; #15 zero-VST crackle still requires physical FAT, not inferred from CI.

Copy link
Copy Markdown
Owner Author

Backlog reconciliation — archived as SUPERSEDED (NOT merged). Stacked offline prepared mixer proof is historical; current DynamicPreparedMixerBlock / LegacyGraphMigration and #266 are canonical. Any unique deterministic PCM test must be rehosted against active core.

Current PRD v5 / ARD v5. Active owners: native #266 / epic #192, UI #265, physical #15, Show #180 and owner GUI #176. This PR's historical commits remain accessible, and no head is blindly merged into modern engine.

@masarray masarray closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant