Skip to content

Integrate P1A–P1C prepared DAW routing contracts onto latest de-click main - #112

Closed
masarray wants to merge 4 commits into
mainfrom
integration/p1abc-routing-core-main-20261028
Closed

masarray wants to merge 4 commits into
mainfrom
integration/p1abc-routing-core-main-20261028

Conversation

@masarray

@masarray masarray commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Reconciled on final CI baseline — refs #108 #110 #111, #101, #107, #95 and #109

Latest integration parent: main@66989fa46f004aa852207f1159bf3e1b8e9506c1 (PR #101 efficient CI). The branch now contains a two-parent merge commit with that exact main SHA; git compare main...PR contains ONLY 12 routing files/Docs/CMake/Windows target registration, no stale Pages/UI/FX/Orbit edits.

Core milestone (compile-only, no dishonest live activation)

Preservation & non-goals

Validation

  • Previous exact routing PR-head 6d470cc Chromium/Firefox PASS 40602736020, Windows MSVC Release CTests and native package PASS 40602736019.
  • Exact latest-main + PR ci: lean native/GUI gates, single release artifact and stale-safe Pages #101 CI head 53d68581 Windows complete and three compiled Release tests pass.
  • All review threads resolved, fresh main SHA and mergeable state.
  • Postmerge main Windows produces one verified GitHub Actions artifact; Pages no stale deploy; no sandbox ZIP URLs.
  • Hardware on real devices still not qualified.

Detailed handoff.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T23:27:22.603656Z 5a8f8c5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a8f8c5d69

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engine/core/MixerRoutingPlan.h Resolved

Copy link
Copy Markdown
Owner Author

Cross-thread synchronization (P1D): new stacked draft PR #115 builds directly on your P1A–C integration and adds an offline compiled 10-strip execution path (physical mono/stereo input → per-strip FX hook → PRE/POST sends → internal FX Return → MASTER) plus Release-safe regression vectors. PR #115 intentionally does not modify live JUCE/audio drivers/GUI and MUST land after #112. Your newer P1C descendant-mask and lean CI changes remain owned by #112; no force merge or overwrite intended.

Copy link
Copy Markdown
Owner Author

Closing as SUPERSEDED, not merged. While this branch was being reconciled, main already merged P1D at d30cf35dc74991286547765ec9927e356273785b, including P1A/B/C source, mono/stereo port mapping, pre/post sends, actual offline 10-strip PreparedMixerBlock, four Release CTests and PR #101 lean CI. PR #112 would now be merge-dirty and could overwrite/drop P1D CMake/Windows target wiring; it must never be force merged. All unique correctness improvements (raw pre-fader source extraction and real O(1) send-DAG reachability) have been isolated onto latest P1D main in PR #118, with targeted tests and an ARD. Original #112 CTest head passed but is NOT an artifact/release. Preserve P1D and finish #118 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant