Repository navigation
P1D integration hardening: pre-fader source independence and exact DAG reachability - #118
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 27, 2026
Closed
masarray
added a commit
that referenced
this pull request
Oct 28, 2026
…out regressing native progress
This was referenced Oct 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes stale PR #112 without overriding P1D
Latest
main@d30cf35dc74991286547765ec9927e356273785balready merged P1D, containing independently compiled P1A/B/C + real offline 10-strip prepared DSP block, CMake/Windows CTest wiring and PR #101 efficient CI. Therefore PR #112 must not be merged wholesale (its old CMake would drop P1D). This small branch includes only the two correctness fixes developed and reviewed during #112, rebased directly onto P1D main.Fix 1: raw physical source remains available with fader at -∞
Plan::extractSourceand format-awareChannelRoutingPlan::extractSourceread real validated hardware input independently of fader/mute/solo for pre-fader FX/send use.extract()/master accumulation still gate inactive routes; no fake channel audio.PreparedMixerBlockalready handles fader-zero pre-sends correctly and is entirely preserved/unmodified. No performance penalty to its active DSP path.Fix 2: strict precomputed send connectivity
ChannelSendPlan::upstreamOf()previously confused topological rank with directed reachability; disconnected sources could be reported upstream.Test gates & change ownership
TenChannelAcyclicPrePostSendsCTest: fader-zero raw→pre-fader send active while MASTER remains silent, muted source read, stereo-to-mono raw fold, multi-hop directed paths, ordered-but-unconnected negative cases, reverse/self/invalid cases.TenChannelEndToEndPreparedAudioRender, FX de-click, Orbit, mono/stereo and Master real VU all untouched.CMakeLists.txt, CI workflow,PreparedMixerBlock.h, JUCE callback,webor VST3 edits.Must pass: latest main exact-head Windows MSVC Release CTest, CI contracts, review, final-main check. Existing PR #112 should be closed as superseded; original stacked #108/#110/#111 already integrated via P1D. ARD.
Hardware: new routing remains OFFLINE executor only. CH2–10 live device/FX, graph epoch/ACK, physical port registry and #15 crackle FAT are not accomplished here.