Skip to content

P1D integration hardening: pre-fader source independence and exact DAG reachability - #118

Merged
masarray merged 1 commit into
mainfrom
fix/p1d-prefader-and-send-reachability-20261028
Oct 28, 2026
Merged

masarray merged 1 commit into
mainfrom
fix/p1d-prefader-and-send-reachability-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

Supersedes stale PR #112 without overriding P1D

Latest main@d30cf35dc74991286547765ec9927e356273785b already merged P1D, containing independently compiled P1A/B/C + real offline 10-strip prepared DSP block, CMake/Windows CTest wiring and PR #101 efficient CI. Therefore PR #112 must not be merged wholesale (its old CMake would drop P1D). This small branch includes only the two correctness fixes developed and reviewed during #112, rebased directly onto P1D main.

Fix 1: raw physical source remains available with fader at -∞

  • New Plan::extractSource and format-aware ChannelRoutingPlan::extractSource read real validated hardware input independently of fader/mute/solo for pre-fader FX/send use.
  • Existing extract()/master accumulation still gate inactive routes; no fake channel audio.
  • P1D PreparedMixerBlock already handles fader-zero pre-sends correctly and is entirely preserved/unmodified. No performance penalty to its active DSP path.

Fix 2: strict precomputed send connectivity

  • ChannelSendPlan::upstreamOf() previously confused topological rank with directed reachability; disconnected sources could be reported upstream.
  • Precompute 10-bit downstream masks once during compile, reverse topological order; query O(1), zero RT heap and no graph walk.

Test gates & change ownership

  • In the existing Release TenChannelAcyclicPrePostSends CTest: fader-zero raw→pre-fader send active while MASTER remains silent, muted source read, stereo-to-mono raw fold, multi-hop directed paths, ordered-but-unconnected negative cases, reverse/self/invalid cases.
  • P1D TenChannelEndToEndPreparedAudioRender, FX de-click, Orbit, mono/stereo and Master real VU all untouched.
  • Exactly six files (3 routing headers, 1 C++ test, 2 documentation). No CMakeLists.txt, CI workflow, PreparedMixerBlock.h, JUCE callback, web or VST3 edits.

Must pass: latest main exact-head Windows MSVC Release CTest, CI contracts, review, final-main check. Existing PR #112 should be closed as superseded; original stacked #108/#110/#111 already integrated via P1D. ARD.

Hardware: new routing remains OFFLINE executor only. CH2–10 live device/FX, graph epoch/ACK, physical port registry and #15 crackle FAT are not accomplished here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T23:56:30.331523Z 875da98 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 4951f3b into main Oct 28, 2026
1 check passed
masarray added a commit that referenced this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant