Skip to content

P1C: deterministic DAW channel sends, pre/post-fader taps and cycle-safe bus routing - #111

Closed
masarray wants to merge 8 commits into
feature/p1b-mono-stereo-port-contract-20261028from
feature/p1c-acyclic-sends-plan-20261028
Closed

masarray wants to merge 8 commits into
feature/p1b-mono-stereo-port-contract-20261028from
feature/p1c-acyclic-sends-plan-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

New milestone — extends P1A #108 → P1B #110 by composition

Adds a bounded 10-strip / 32-send DAG scheduler for internal routing, without changing or restarting JUCE devices and without enabling cosmetic/fake native FX.

Implemented

  • engine/core/ChannelSendPlan.h: immutable prepared send plan, validates strip IDs/taps/gain/PAN/duplicates, detects all directed feedback cycles, deterministic topological order, optional sends-only toMaster=false, and sparse per-source O(edges × frames) dispatch to preallocated buffers.
  • tests/channel_send_plan_test.cpp: synthetic audio pre/post tap separation, fanout/fanin and send pan, full 10-strip ordering, cycle/self-send/duplicate/error guards, transactional rollback, and Release assertions.
  • Existing Windows CMake/CTest/Actions updated for ARMixChannelSendTests. No extra workflows.
  • docs/P1C_INTERNAL_SENDS_DAG_20261028.md captures signal tap semantics, mandatory callback ownership, integration and hardware acceptance gates.

Strict scope

Pure DSP architecture — NOT installed on the live callback or GUI. Source registry and DSP instance ownership still require validated device identity, graph epoch/ACK and #15 clean zero-VST hardware FAT. CH2–10 native FX remain unavailable. Avoid importing conflicting #102 GUI branch or overwriting other thread work.

Merge order

This PR is stacked on #110 which is stacked on #108. After #108 merges, land #110, retarget this PR to main, and check exact-head CI again. Do not bypass parents. #95 #109 #15 #85.

Copy link
Copy Markdown
Owner Author

P1C stack sync · 2026-10-28. Verified current main c0d7c79; accepted #107 FX bypass de-click and #105 Orbit/POLAR must survive. This PR is based on #110, itself stacked on #108. Keep integration order #108 → #110 → #111, retarget each child after its parent is merged, then run exact-head Release/MSVC CTest. Use only existing Windows native workflow and retain #107's ARMixFxBypassEnvelopeTests. Preserve DAG cycle rejection, pre/post taps, plan preparation off RT, and source identity; no activation of live sends, CH2–10 FX, or hardware claims until routing graph epoch/ACK and #15 no-FX capture diagnostics are qualified.

Copy link
Copy Markdown
Owner Author

P1C send DAG and pre/post-fader bus plan sources/tests are already on main following P1D merge d30cf35dc74991286547765ec9927e356273785b; P1D now also provides genuine, device-independent 10-channel offline audio block execution. Stacked merge order #108→#110→#111 is obsolete; never merge this old draft as another native master plan. PR #118 adds strict O(1) downstream connectivity and pre-fader raw-source independence with Release regressions on top of current main, without replacing P1D. Closing as superseded with historical branch intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant