Repository navigation
P1B: independent mono/stereo channel formats + sparse physical-port mapping (P1A stack) - #110
Conversation
…cal input contracts
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c85843de69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| add_executable(ARMixChannelRoutingContractTests tests/channel_routing_contract_test.cpp) | ||
| target_compile_features(ARMixChannelRoutingContractTests PRIVATE cxx_std_20) | ||
| add_test(NAME MonoStereoSparsePhysicalPortRouting COMMAND ARMixChannelRoutingContractTests) |
There was a problem hiding this comment.
Build the new test target in the Windows workflow
On a clean Windows CI run, this registers a test whose executable is never built: .github/workflows/p1-windows.yml:66 explicitly enumerates build targets but omits ARMixChannelRoutingContractTests, then line 68 runs the full CTest suite. The local cmake --build usage confirms that --target means “Build instead of default targets.” Consequently, CTest cannot find the new executable, failing the required Windows gate and preventing the subsequent artifact-packaging step. Add the new target to the workflow's build list.
AGENTS.md reference: AGENTS.md:L26-L26
Useful? React with 👍 / 👎.
|
P1B dependency and acceptance sync · 2026-10-28. Main is |
|
P1B independent mono/stereo format and sparse physical port-mapping source/tests were already integrated into main by P1D merge |
P1B milestone — real code, stacked on verified P1A PR #108
Implements the owner's approved independent mono/stereo strip format without confusing source width, channel processing format, and physical callback index. Extends the already-built P1A
MixerRoutingPlanby composition, not a competing audio engine.Scope
engine/core/ChannelRoutingContract.h: compile-only format modesfollowSource/mono/stereo, sparse physical-port-to-callback mapping, nonadjacent stereo L/R, stereo→mono fold and mono→stereo dual-mono calibrated center. All-or-nothing validation. No audio callback lifecycle changes.tests/channel_routing_contract_test.cpp: physical ports 5/2/7 in custom callback order, channel isolation, input fanout, mono/stereo conversions, invalid/missing/duplicate ports, NaN and transactional plan rollback.assert()even with-DNDEBUG(Windows Release test gate otherwise silently skips all assertions).Verified locally
GCC C++20 with optimization,
-DNDEBUG,-Wall -Wextra -Werror, AddressSanitizer + UndefinedBehaviorSanitizer: PASS for the new P1B contract. Must still pass exact-head Windows MSVC CTest, native build, and hardware gates.Critical integration boundaries
Not yet connected to JUCE LiveAudioEngine, hardware or WebView2. CH2–10 are still native preview-only; no live sends/true native mono FX instances yet. This code is not evidence of click-free live operation or a fix for #15 crackles. Do NOT enable GUI SOURCE/MONO/ST controls until real channel DSP, verified physical port mapping, graph epoch publication and ACK exist. Plugin stereo output after mono input is a separate bus negotiation gate. Existing P1A, Orbit, #102 FX drag, #101 CI and public/portable feature parity are unchanged.
Merge sequencing
This PR is stacked on PR #108 (
feature/p1-static-multichannel-routing-core-20261028). Merge #108 first after its green exact-head CI and reconciliation with latest main, then retarget this P1B PR to the updated main and check exact-head CI. Do not merge a stacked branch into main without its parent.Refs #109 #95 #15 #85, implementation guide.