Repository navigation
perf(meter): pro fast-fall / ease-out LED ballistics without extra GPU work - #106
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 27, 2026
Merged
Closed
Closed
masarray
added a commit
that referenced
this pull request
Oct 27, 2026
Keep approved meter #106, dearVR Orbit/POLAR #105, and GUI unchanged. Sample-accurate wet/dry bypass transition or fade-to-silence for latent plugins; no added audio buffering or realtime allocations. Add native CTest, static wiring contract, cross-thread handoff. Windows x64 Release/CTest/artifact audit and Chromium PASS.
This was referenced Oct 27, 2026
masarray
added a commit
that referenced
this pull request
Oct 28, 2026
…#118) Reconcile and integrate P1D routing correctness on top of latest main including P3 Studio Backup #116 and the approved pro meter ease-out #106. Source extraction independent of post-fader/mute gate; constant-time transitive DAG checks; regression CTests. Preserve P1D native/offline test targets, latest Orbit, GUI and CI. Existing PR-head Windows MSVC PASS; exact merged-main retest required.
This was referenced Oct 28, 2026
P0: integrate FX drag + atomic reorder into latest main without losing bypass/Orbit/meter/fader
#122
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request / current-main reconciliation
Owner wants the peak LED bar to fall aggressively immediately, then ease smoothly as it approaches actual measured signal; preserve pro audio honesty, not a fake animated VU. Based on latest main
de683b001(includes PR #104 MASTER L/R visibility, PR #105 Orbit/capture diagnostics). Unmerged concurrent PRs #102 (FX reorder), #101 (CI), #97 (GUI), #60 (experimental canvas) are not overwritten.Audited root cause and precise remedy
Current native JS meter visual integrates gravity-style acceleration (slow start, fast finish), the inverse of the requested feel. Replace it with a calibrated visual-only exponential envelope: fast upward attack
tau=18ms; falling releasetau=165ms, fastest when far from native level and naturally decelerating as the meter lands. No overshoot, bounce, fake meter values or synthetic waveform. Maintain the 34ms lazy shared timer + single rAF (~29.4 scheduled fps), exact 7px LED cells with dirty CSS writes, original colors, CH1 and real MASTER L/R, all peak/clip semantics. Scalar return drops per-frame{level, velocity}allocations and unnecessary per-meter acceleration state. Existing?metermotion=direct, reduced motion, hide/suspend and detached DOM lifecycle remain.Tests and CI
web/app.js↔ standalone embedded JS byte parity.Important boundaries
This is a visual peak activity meter, not a calibrated IEC/ITU peak or true-peak/loudness instrument; retain real DSP measurement sources and separate peak/clip indicators. No claim of real low-spec-PC FPS gain without profiling. Issue #56 remains open for physical performance acceptance.