Repository navigation
P0: sample-accurate FX bypass de-click, zero added latency and cross-thread reconciliation - #107
Conversation
…r and pending parallel PRs
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c437a8851a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| staged->bypassEnvelope[i].prepare (staged->slots[i].bypass, rate, | ||
| staged->slots[i].latency); | ||
| staged->slots[i].latency = staged->slots[i].processor->getLatencySamples(); |
There was a problem hiding this comment.
Read restored plugin latency before preparing its bypass envelope
When recalling a preset containing a latency-bearing VST3, every staged Slot still has its default latency = 0 when passed to prepare(). The actual latency is read immediately afterward, but the envelope retains zero internally. Subsequent bypass toggles therefore use the zero-latency wet/dry crossfade instead of switching at silence, mixing time-misaligned signals and introducing comb filtering or cancellation during the transition. Since live recall does not restart the device, this persists until a later device restart. Populate the slot latency before preparing its envelope.
Useful? React with 👍 / 👎.
|
Live reconciliation update: While PR #107 was being prepared, meter PR #106 merged to |
Root cause
Current
setBypasspublishes a bare atomic boolean and the audio callback jumps betweenVST3 processBlockand untouched dry samples at a buffer edge; this can cause an audible discontinuity regardless of callback CPU budget. Distinct from Issue #15 zero-plugin WASAPI crackles, still open.Engine fix
FxBypassEnvelope, exclusively RT-owned; UI thread only publishes desiredbypassFlags.processBlock, stable active path has no dry snapshot overhead. Preset staged graphs and device reopen reset envelope to the appropriate flag, not stale sample state. Latency telemetry updated on message thread.Parallel thread reconciliation
20222c6after meter PR perf(meter): pro fast-fall / ease-out LED ballistics without extra GPU work #106 merged. Preserve accepted Orbit/POLAR PR P0: no-FX capture crackle triage + dearVR-only Orbit with safe POLAR auto-selection #105, master meter and GUI; no GUI/Orbit changes.docs/ARSONMIX_CROSS_THREAD_HANDOFF_20261028.mdas durable state handoff for other threads.Hardware FAT still needed
Toggle real plugin several times in sustained audio; test both zero-latency and latency-bearing effects; assess rapid toggles and simultaneous FX. This PR addresses discontinuities due to host bypass only. A passing CI cannot prove total elimination of audible clicks or fix capture discontinuities.