Skip to content

P0: integrate FX drag + atomic reorder into latest main without losing bypass/Orbit/meter/fader - #122

Merged
masarray merged 22 commits into
mainfrom
integration/p0-fx-drag-preserve-main-20261028
Oct 28, 2026
Merged

masarray merged 22 commits into
mainfrom
integration/p0-fx-drag-preserve-main-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

P0 cross-thread reconciliation — implementation, not a handoff

Base: latest main e5c95a9 (includes PR #120 true folded-metal fader, PR #116 verified portable Studio backup, PR #121 10-channel DRY LAB, PR #107 FX bypass de-click, PR #106 meter ease-out and dearVR Orbit fixes).

What is actually ported from old PR #102

Do not overwrite

Native P1E LAB, P1D DAG, Portable Vault/Backup, the meter 30fps / easer, MASTER real LED, Orbit motions/POLAR and 8ms ON/OFF de-click, source CSS ownership and GUI resources.

Pending evidence

Exact-head Windows native/MSVC+CTest & Chromium/Firefox checks; after green verify artifact provenance. Physical sound FAT still needed to certify click-free MOVE across plugins and 0-FX issue #15. This PR does not claim all 10 channels have live VST3 chains.

Supersedes conflicting stale PR #102 implementation while keeping it as a readable historical source; refs #95 #56 #15.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T02:08:05.416255Z 7d739bf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d739bff2b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/fx_drag_reorder_contract_test.mjs Outdated
Comment on lines +63 to +64
const trough=css.slice(css.indexOf('/* P0: one folded-sheet-metal trough'),css.indexOf('/* DAW insertion markers'));
assert.match(trough,/background:#26343c/);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Extract the fader rules using a marker present in the stylesheet

The new contract test fails deterministically: 42-mixer-premium.css does not contain /* P0: one folded-sheet-metal trough, so the starting indexOf returns -1, trough becomes empty, and the assertion on line 64 fails. Running node --test tests/fx_drag_reorder_contract_test.mjs reproduces this failure. Both changed workflows now execute this test, blocking the Windows and UI gates even though the retained fader styles contain the expected values. Use an existing section boundary or inspect the actual fader selector instead. AGENTS.md requires passing Windows/Chromium validation.

AGENTS.md reference: AGENTS.md:L26-L26

Useful? React with 👍 / 👎.

Comment thread web/app.js
Comment on lines +471 to +473
let insertion=d.count;
for(let i=0;i<d.count;i++)
if(d.y<(bounds[i].rect.top+bounds[i].rect.bottom)/2){insertion=i;break}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Bound preview drag hit-testing by the visible insert count

In the standalone preview, a channel can contain eight effects (insertPlugin and setChain allow this), but makeStrip renders only six insert slots. With seven or eight effects loaded, dragging into the bottom half of the sixth visible slot makes this loop access bounds[6].rect, throwing instead of updating the insertion target; releasing can consequently apply the previous target. Limit hit-testing and drop-index calculation to rendered slots, while preserving the hidden chain entries. AGENTS.md explicitly fixes the mixer at six visible FX slots per strip.

AGENTS.md reference: AGENTS.md:L12-L12

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant