Skip to content

R0A: execute existing CH1 FX rack and Orbit inside real native 10CH+4AUX graph - #144

Merged
masarray merged 3 commits into
mainfrom
feature/r0-unified-ch1-fx-native-routing-20261029
Oct 29, 2026
Merged

masarray merged 3 commits into
mainfrom
feature/r0-unified-ch1-fx-native-routing-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

P0 R0A — real native engine integration (part 1 of R0), fixes #143 in part

Implementation: CH1's already owned and preprepared real VST3 multi-insert rack / Orbit is processed within the same LiveChannelFxGraph render pass as 10 input channels, 4 native AUX buses, PRE/POST sends and master output. The existing LiveGraphHandoff callback lease guards plugin lifetime. No duplicate plugin, no second mixer, no audio callback ownership allocation, no client-facing fake preview.

  • LiveChannelFxGraph::ExternalStripFx allows only CH1 and only if no internally installed CH1 VST3. All other lanes use their original native per-channel VST3 and FX return processors.
  • LiveDryRoutingLab::process accepts an explicit callback-scoped leased host context and forwards it through existing graph publication/retirement. Structural routing still validates actual hardware port mask, epoch, revision, zero-PDC chain and output mute.
  • LiveAudioEngine::processLegacyChannelOne performs existing real JUCE processBlock, respects physical slot order and bypass crossfade, using preallocated stereo scratch with no graph/refcount change, and fails the strip silent if a vendor throws. CH1 plugin instances/Orbit parameter identity remain unchanged during routing APPLY.
  • Rejects unsafe duplicate CH1 native insert when legacy CH1 has rack, and nonzero-latency CH1 rack until PDC.
  • Added native CTest regression for CH1 borrowed insert in 10-channel bus render, exactly one invocation and no host callback heap allocation.
  • Updates on-panel documentation truthfully. Current LAB control names retained as internal compatibility; does not falsely claim full R0 completion.

Remaining R0B (blocking R1/main): promote the unified route graph to default selected-device production path; move CH1 add/remove/reorder and snapshot/Orbit lifecycle to unified graph without callback detach/graph epoch invalidation; remove operator START/STOP LAB; make console channels truthful by default. This is required by #143. Physical zero-FX crackle #15 and hardware FAT still open.

Review gates: exact-head Windows MSVC app + native CTest; Chromium smoke; no regressions to merged #140 splash, #142 LUFS/dBTP, #122 FX reorder or Orbit. Do not merge if CI or source review fails; minimize CI reruns.

Details: docs/R0_UNIFIED_CH1_LANE_MILESTONE_20261029.md.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T06:24:37.629482Z 809b32f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 809b32f8d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/LiveAudioEngine.h Resolved
Comment thread src/LiveDryRoutingLab.h Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P0 PRODUCT ROUTING: replace LAB with unified native live mixer + eMotion-LV1-inspired INPUT/INTERNAL/OUTPUT patch matrix

1 participant