Repository navigation
R0A: execute existing CH1 FX rack and Orbit inside real native 10CH+4AUX graph - #144
Merged
masarray merged 3 commits intoOct 29, 2026
Merged
Conversation
…outing graph without duplicate VST3
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 809b32f8d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0 R0A — real native engine integration (part 1 of R0), fixes #143 in part
Implementation: CH1's already owned and preprepared real VST3 multi-insert rack / Orbit is processed within the same
LiveChannelFxGraphrender pass as 10 input channels, 4 native AUX buses, PRE/POST sends and master output. The existingLiveGraphHandoffcallback lease guards plugin lifetime. No duplicate plugin, no second mixer, no audio callback ownership allocation, no client-facing fake preview.LiveChannelFxGraph::ExternalStripFxallows only CH1 and only if no internally installed CH1 VST3. All other lanes use their original native per-channel VST3 and FX return processors.LiveDryRoutingLab::processaccepts an explicit callback-scoped leased host context and forwards it through existing graph publication/retirement. Structural routing still validates actual hardware port mask, epoch, revision, zero-PDC chain and output mute.LiveAudioEngine::processLegacyChannelOneperforms existing real JUCEprocessBlock, respects physical slot order and bypass crossfade, using preallocated stereo scratch with no graph/refcount change, and fails the strip silent if a vendor throws. CH1 plugin instances/Orbit parameter identity remain unchanged during routing APPLY.Remaining R0B (blocking R1/main): promote the unified route graph to default selected-device production path; move CH1 add/remove/reorder and snapshot/Orbit lifecycle to unified graph without callback detach/graph epoch invalidation; remove operator START/STOP LAB; make console channels truthful by default. This is required by #143. Physical zero-FX crackle #15 and hardware FAT still open.
Review gates: exact-head Windows MSVC app + native CTest; Chromium smoke; no regressions to merged #140 splash, #142 LUFS/dBTP, #122 FX reorder or Orbit. Do not merge if CI or source review fails; minimize CI reruns.
Details:
docs/R0_UNIFIED_CH1_LANE_MILESTONE_20261029.md.