Skip to content

P0 R0B: complete unified always-on native 10CH+4AUX production mixer and FX lifecycle #149

Closed as duplicate

Description

@masarray

R0B — finish unified always-on production mixer (not an operator LAB)

Reconciled 2026-10-29 against main 4d14251bc21ed755e08a51b50aa3f1bcd2008cb2. R0A #144, native INPUT PATCH #146, and premium routing workbench in main are already delivered. Do not rebuild any of them. Issue #143 was closed after partial work but R0B's underlying structural acceptance has not been demonstrated. This issue isolates the remaining functional work.

Current proven foundation

Functional Definition of Done

  1. On selected supported device, one production mixer topology is active by default; CH1 and CH2..10 are not hidden behind mutually exclusive legacy vs LiveDryRoutingLab start/stop modes. Disconnects are silent until explicit valid patch; never display preview as LIVE.
  2. Migrate CH1 and other supported strip FX add/remove/reorder, bypass, Orbit, editor/preset ownership to a single device-aware native lifecycle; preserve identity/vendor state/tails across routing edits. Do not duplicate FX instances or callbacks.
  3. Prepared immutable topology and control-plane commands, bounded callback-safe handoff and retirement; audio callback has no allocation, lock, I/O, JSON, scan, vendor state serialization, window call, callback detach/reopen, or destruction.
  4. Preserve explicit Output MUTE, device DIRECT/epoch/revision and output-arm fences. Stale/unavailable device or rejected graph leaves last valid routing intact and reports actionable negative ACK; integrate pending-state hardening R1 hardening: guaranteed native routing rejection ACK during Studio backup #147 before further routing UX.
  5. Remove user-facing LAB/START/STOP dependency after production engine path is proven; keep old command aliases temporarily if needed, then retire only with compatibility tests.
  6. Complete deterministic native + Chromium acceptance for startup/patch/FX swap/Orbit/rollback/repeated device changes; exact-head Windows MSVC+CTest and UI smoke. Physical 0-FX and real VST3 ASIO/WASAPI FAT still required for public live-ready claim.

Scope exclusions / dependencies

Priority: P0 product integrity; split into small executable vertical slices, with hardware FAT as explicit independent release gate.

Activity

  1. masarray commented on Oct 29, 2026

    @masarray
    OwnerAuthor

    R0B native implementation audit (2026-10-29; main f997fb3; independent of G0 ACK PR #151/#152)

    This is a code-level dependency map, not a completion claim. Source reviewed: src/LiveAudioEngine.h, src/LiveDryRoutingLab.h, src/LiveGraphHandoff.h, engine/core/LiveChannelFxGraph.h, and merged R0A evidence.

    Current real split

    • JUCE callback calls dryRoutingLab_.process(..., LegacyChannelOneLease, processLegacyChannelOne) only while dryRoutingLab_.active(); otherwise falls through to the preexisting CH1 path. A route has a separate publisher, epoch, revision, active bit, and its own process rendering.
    • Native start() opens device/callback and enables MONITOR without constructing the 10CH production graph. LiveDryRoutingLab::apply() validates masks/epoch and publishes only on explicit UI APPLY. This is not yet unified always-on startup.
    • addVst3, captureSnapshot, FX structural paths still reject while routing is active. addVst3 detaches callback before mutating CH1 Graph unique_ptr slots; reusing that code for live 10CH would violate RT continuity. R0A only borrows the CH1 processor pointer via a buffer-cycle lease, preserving Orbit/tails while routes change.
    • LiveChannelFxGraph already owns reusable per-lane FX instances and preallocated scratch; RealtimeRoutePublisher already provides epoch/revision publication and bounded retirement. Do not instantiate duplicate VSTs or add another audio callback.

    R0B executable slice order (each with deterministic tests, ONE Windows+Chromium pair per meaningful PR):

    1. A coherent control-thread session/graph owner: device binding and startup state NO_DEVICE → VERIFIED_UNPATCHED_MUTED → ACKED_ROUTE_MUTED → LIVE; STALE/DEVICE_LOSS → SILENT. No guessed input or auto-unmute; only authoritative ACK may label LIVE. Preserve diagnostic OUTPUT_ONLY/CAPTURE_ONLY flow separately.
    2. Migrate CH1 FX ADD/REMOVE/MOVE/bypass/Orbit to that owner's prepared graph transition, with stable identity and bounded retirement; vendor prepareToPlay/release and state operations off RT, reject latent FX without PDC. Avoid copying the current detach-on-add path.
    3. Ensure the single callback always renders the selected session graph (unpatched = silent), still supports 10 INPUT+4 AUX PRE/POST and CH1 original FX/Orbit with zero duplicate processing. Retire legacy path only after acceptance, not via a UI rename.
    4. Device-change rollback, stale epoch/revision/port-mask tests, rapid edits/retirement full, plugin failure, muted/no-device startup, plugin editor state and 0-FX meter provenance. Then remove visible LAB/STOP workflow and verify physical ASIO/WASAPI separately against P0 — Crackling with 0 VST3: diagnose WASAPI clock/input/output buffering before engine expansion #15.

    Parallel G0: ACK hardening of Studio-busy APPLY is isolated in #151; #152 was independently opened with near-identical changes. Only one should merge. Neither resolves this issue's engine split.

  2. masarray commented on Oct 29, 2026

    @masarray
    OwnerAuthor

    Source-level R0B execution guard — audited against main f997fb3c6afc8ffc6af297ae78128c985da3cf34 (2026-10-29)

    Do not interpret merged R0A/#146 or the premium Routing workspace as the removal of the legacy/native dual path. Confirmed from current source:

    • src/LiveAudioEngine.h::start registers/opens JUCE DIRECT, then approves device; the default production audio route is still the CH1 legacy path. audioDeviceIOCallbackWithContext explicitly branches on dryRoutingLab_.active() (native 10CH) and otherwise processes CH1.
    • applyDryRoutingLab requires OUTPUT MUTE, validated device/epoch and zero latency where no PDC exists. disableDryRoutingLab returns to CH1 path; deleting its button alone would not create a unified engine.
    • addVst3, removeAt, moveSlot, captureSnapshot, restoreSnapshot explicitly reject when dryRoutingLab_.active(). ADD/REMOVE still use detach()/attach() to mutate the legacy graph. Unblock only after safe native processor ownership, prepared swap and state/Orbit lifetime are proven.
    • LiveDryRoutingLab::apply already validates device physical port masks, generation/revision, zero-PDC FX and reuses unchanged prepared lane VST3. It MUST remain the foundation, not be replaced by a second mixer graph.
    • Main.cpp::onAction and web/monitor.js currently retain routingDryApply/routingDryStop internal actions. Keep aliases until real production startup is integrated and tested.

    Suggested independent executable slices: (a) correct ACK/pending rejection (#152 supersedes stale #147), (b) unified silent/verified startup session and single topology authority, (c) migrate legacy CH1 ADD/REMOVE/MOVE/Orbit to safe lane ownership, (d) remove user-facing start/stop LAB only after proven real native defaults; test device hotplug, rollback, vendor lifecycle and no RT allocation at every step. Consolidate real hardware FAT for #15.

    No change to real-time files is claimed by this comment. Do not relax MUTE/DirectFence/epoch/revision or fake LIVE state to make UI appear finished.

  3. masarray commented on Oct 29, 2026

    @masarray
    OwnerAuthor

    R0B B1 delivered to main (2026-10-29)

    Merged #153 as eb9420332efb5ea364cc3a70f281b006e01d5f62: existing CH1 multi-insert vendor FX order can now MOVE while the native 10CH+4AUX route is active. Reuses existing atomic logical order + FxMoveRamp two-buffer de-click inside the same routed audio callback; CH1 processor identity, editor/Orbit and tails are not reinstantiated, real output meters are sampled after the ramp. Independent clock remains gated; ADD/REMOVE, default session, device routing epoch and Show recall are untouched.

    Exact-head evidence: Windows Native VST3 Host run 40865180442 SUCCESS, including source contract suite, MSVC executable, native RT/CTest and ZIP verification. First attempt failed only a brittle STOP-race source-test comment boundary; fixed by anchoring to actual legacy fallback boundary and rerun passed. No separate redundant CI matrix.

    #149 remains OPEN. Next B2/B3: shared prepared-owner FX ADD/REMOVE live lifecycle without callback detach, stable VST3/Orbit instance + safe bounded retirement; always-on verified/unpatched muted native mixer session and strict device rollback. R2/R3 and physical issue #15 hardware clean-audio FAT remain separate and unqualified. AGENTS.md, canonical reconciliation and Routing handoff updated on main 1d2d618 (docs-only).

  4. masarray commented on Oct 29, 2026

    @masarray
    OwnerAuthor

    Cross-thread execution update (2026-10-29): G0 native rejected-ACK #152 is MERGED; R0B B1 CH1 live-routed FX MOVE/de-click #153 is MERGED (exact PR head Windows Native CI SUCCESS: https://github.com/masarray/arsonmix/actions/runs/40865180442). Parallel release-quality UI storage #154 and R2 lazy shared native 10CH+4AUX FX picker #155 are also MERGED; #155 head Chromium SUCCESS: https://github.com/masarray/arsonmix/actions/runs/40867303280. Current main after #155 9ad3f4c2c4df207e8a1c5c5aa4c9b06680c9bc9f. NOT COMPLETE: B2 safe ADD/REMOVE VST3 prepared ownership / vendor state and B3 unified always-on 10CH startup/retirement remain; output hardware routing/PDC and physical zero-VST FAT #15 remain separate gates. Do not redo merged #152/#153/#154/#155, do not remove safety fences or claim hardware certification from CI. Source ownership for next B2: src/LiveAudioEngine.h, legacy CH1 graph handoff, native per-lane graph; first reconcile current main and safe graph lifetime. No duplicate callback/second FX graph.

  5. masarray commented on Oct 29, 2026

    @masarray
    OwnerAuthor

    2026-10-29 — R0B B2 major engine milestone MERGED (#156)

    Native CH1 VST3 ADD / REMOVE / MOVE / preset recall now share one prepared graph-handoff ownership model across the original CH1 callback and the native 10CH+4AUX single-pass route. #156 merged as e62d377.

    Functional change: no routine detach() / attach() for FX ADD/REMOVE. Message thread prepares/bus-validates/loads VST3, builds graph retaining original vendor instances/Orbit/state, checks device epoch/rate/buffer and PDC, then publishes through an output de-clicked 2-buffer handoff. PluginRelease guarantees final-owner releaseResources/deletion only on control; rejected candidate cleans up without mutating currently accepted route. GUI's positive arMixAddResult, chain and revision update wait for native handoff ACK. Orbit rebinding by identity occurs at ACK. Independent clock live structural edits remain explicitly blocked.

    Evidence: exact-head PR 0c53f9a Windows Native Host run 40871937375 PASS: MSVC executable, source contracts, 50/50 CTests, including R0BStructuralFxAckAndControlThreadRetirement (2,000 alternating ADD/REMOVE graph ownership cycles), packaging/verification. Old pre-ACK JS test assumptions corrected rather than removed. No extra CI matrix. Routing/GUI theme unchanged. Canonical docs, AGENTS.md and handoff updated on main e046d041.

    DO NOT CLOSE #149 YET. Remaining B3 functional definition: one selected-device always-on 10CH+4AUX native production session from startup with unpatched SILENT state, explicit physical INPUT PATCH / output safety fences, device-loss/epoch/revision rollback, and removal of user-facing LAB/STOP split only after acceptance. Then R2 INTERNAL/AUX and R3 physical ASIO/WASAPI sound FAT. Zero-VST physical crackle #15 still OPEN; green CI does not prove clean audio hardware.

  6. masarray commented on Oct 29, 2026

    @masarray
    OwnerAuthor

    2026-10-29 B3 coordination: B2 #156 is merged/green. Parallel B3 branches #157 and #158 both targeted production NORMAL fail-silent start/STOP/hotplug. #158 was closed superseded after reviewing #157's more focused native callback guard and truthful productionRoutingState. #157 now correctly invokes handoff_.endCycle(cycle) in the unpatched-silent branch so pending CH1 FX ADD/REMOVE/recall can finish and retire even with no route. Its current exact-head Windows CI is not yet green/complete; do not claim B3 merged or hardware-qualified until validated. Issue #15 remains open. No duplicated CI/merge.

  7. masarray commented on Oct 29, 2026

    @masarray
    OwnerAuthor

    2026-10-29 source/CI reconciliation: R0B B3 #157 is MERGED in main a9afddc after exact-head Windows Native/MSVC/CTest/package run 40890927975 SUCCESS. NORMAL production routing fails silent on startup/clear/hotplug without native route; FX handoff endCycle still progresses in silence. R2 compact 10×4 CH→AUX send matrix/inspector #159 is also MERGED in main 2acb509 after exact-head Chromium 40897545528 SUCCESS (post-merge Chromium 40897799937 SUCCESS). R2 supports separate PRE and POST tap per pair, level, pan, DRAFT/LIVE/REMOVED, advanced CH→CH sends, duplicate and DAG preflight, unchanged native prepared graph authority. Canonical AGENTS/handoff docs updated in docs-only ce5f06b. Issue #149 remains open for true selected-device/full product acceptance and legacy command/API cleanup; zero-FX real ASIO/WASAPI crackle FAT #15 remains OPEN. Main merged-source Windows packaging run 40897800124 is in progress; do not claim success until verified. Next substantial gate: test device-loss/rollback/ACK under physical audio conditions, then R3 GUI performance/onboard-GPU, hardware OUTPUT patch/PDC/full native FX Show as separate unqualified work. No repeat of B1/B2/B3/R2 matrix.

  8. masarray commented on Oct 29, 2026

    @masarray
    OwnerAuthor

    R0B B3 cross-thread ownership update (2026-10-29): #157 merged (a9afddc) NORMAL fail-silent with FX graph lease ACK. #160 OPEN head f12f255b10418d4df3198c0b2f4dbfcb17eef19b implements major always-on verified DIRECT 10CH+4AUX unpatched production session, authoritative CLEAR PATCH, diagnostics/device reinit, safe no-user-patch realtime bypass of all channel/AUX/MASTER VST3, CH1 preset and PDC guard compatibility, 10CH native CTest + Chromium regression. Integrated on main@ce5f06b retaining R2 CH→AUX matrix #159; #160 Chromium exact head SUCCESS, Windows native 50/50 CTest + package verification running: https://github.com/masarray/arsonmix/actions/runs/40902409129. Do not redo or overwrite #160 while CI runs. Do not merge until Windows/Chromium final-head PASS. Still not verified on physical ASIO/WASAPI (#15); no physical AUX output patch/PDC/full FX Show recall. Issue #149 remains OPEN pending full product qualification and any remaining lifecycle gaps.

  9. masarray commented on Oct 29, 2026

    @masarray
    OwnerAuthor

    2026-10-29 verified delivery for device-bounded production mixer: #160 B3 merged as 3af8470; 10CH+4AUX native prepared session starts output-MUTED, unpatched and fail-silent on device mismatch, CLEAR PATCH remains native and no CH1 auto-restore. Windows main package run 40904834549 success and experimental ZIP available. #163 P4 native DRY Show SAVE→BROWSE→RECALL merged as 5667eec after exact-head Windows CTest/package 40905958127 and Chromium 40905958087 both SUCCESS. Release metadata falsely labeled CH1-only; fixed by main fb0193e, final main package CI pending; docs/FAT 10CH + DRY Show test matrix updated at eca3627. #141 closed as superseded. Keep #149 OPEN for independent real-device #15 crackle FAT and supported VST3 strip/Orbit, device-change stress, full vendor state Show recall / PDC / physical output patch not proven. Green source CI is not hardware qualification.

  10. masarray commented on Oct 29, 2026

    @masarray
    OwnerAuthor

    2026-10-30 product architecture update for all concurrent threads: The owner's digital-mixer reference screenshots require MIX with FX/ROUTE/SENDS toggle, standalone working FX RACK, custom Audio I/O mono/stereo patch, 4 authentic internal AUX FX returns and future real physical output busses. Read ARD v2.0, PRD v2.0, execution handoff. Issue #109 is the consolidated G1–G6 UX/IO/AUX/Output implementation checklist. Preserve R0B native 10CH+4AUX/CH1 FX/epoch ACK. No more overlay hiding the live rack; output MAIN L/R remains read-only until actual output patch exists; #15 real-hardware 0-VST crackle FAT is still unqualified. This comment does not close R0B or imply delivered G1–G6 features.

  11. masarray commented on Oct 31, 2026

    @masarray
    OwnerAuthor

    ISSUE RECONCILIATION — historical/overlap closed, NOT declared solved. The old fixed 10CH+4AUX R0B production-graph milestone was incrementally delivered in M4 but is not universal parity. Its unfinished full lease/Orbit/FX/Show work is explicitly owned by #192 and M-U1 PR #266; old ticket's status and code ownership are no longer a safe current guide.

    Current authority: PRD v5, ARD v5, native epic #192, GUI L2 #176, and hardware #15. Existing original comments and links remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions